You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2018/11/01 23:59:30 UTC

[Impala-ASF-CR] IMPALA-7244: [DOCS] Impala supports ADSL Gen 2 (ABFS)

Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11853


Change subject: IMPALA-7244: [DOCS] Impala supports ADSL Gen 2 (ABFS)
......................................................................

IMPALA-7244: [DOCS] Impala supports ADSL Gen 2 (ABFS)

Change-Id: Ic06d9ac92ed78b9092369e211de8a81db1d7ce90
---
M docs/shared/impala_common.xml
M docs/topics/impala_adls.xml
M docs/topics/impala_insert.xml
M docs/topics/impala_load_data.xml
4 files changed, 122 insertions(+), 87 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/53/11853/1
-- 
To view, visit http://gerrit.cloudera.org:8080/11853
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic06d9ac92ed78b9092369e211de8a81db1d7ce90
Gerrit-Change-Number: 11853
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>

[Impala-ASF-CR] IMPALA-7244: [DOCS] Impala supports ADSL Gen 2 (ABFS)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11853 )

Change subject: IMPALA-7244: [DOCS] Impala supports ADSL Gen 2 (ABFS)
......................................................................


Patch Set 1:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/129/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/11853
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic06d9ac92ed78b9092369e211de8a81db1d7ce90
Gerrit-Change-Number: 11853
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Nov 2018 23:59:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7244: [DOCS] Impala supports ADLS Gen 2 (ABFS)

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.

Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11853 )

Change subject: IMPALA-7244: [DOCS] Impala supports ADLS Gen 2 (ABFS)
......................................................................


Patch Set 2:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/11853/1/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:

http://gerrit.cloudera.org:8080/#/c/11853/1/docs/shared/impala_common.xml@1304
PS1, Line 1304: Gen2
> Use "Gen 2" rather than "Gen2"
I checked the MS docs, and they use "Gen2". I will consistently use "Gen2" to match the MS official naming.


http://gerrit.cloudera.org:8080/#/c/11853/1/docs/shared/impala_common.xml@1310
PS1, Line 1310: Gen2
> Nit: We seem to use "Gen 1"/"Gen 2" rather than "Gen1"/"Gen2" in other docs
Will be consistent with "Gen2"


http://gerrit.cloudera.org:8080/#/c/11853/1/docs/topics/impala_adls.xml
File docs/topics/impala_adls.xml:

http://gerrit.cloudera.org:8080/#/c/11853/1/docs/topics/impala_adls.xml@99
PS1, Line 99: <codeblock>abfs://<varname>your_account</varname>.azuredatalakestore.net/<varname>rest_of_directory_path</varname>
            : abfss://<varname>your_account</varname>.azuredatalakestore.net/<varname>rest_of_directory_path</varname>
> The URI format is not the same as ADLS Gen 1. This link describes the new U
Removed here and fixed in the section below, CREATE DB and TABLES.


http://gerrit.cloudera.org:8080/#/c/11853/2/docs/topics/impala_adls.xml
File docs/topics/impala_adls.xml:

http://gerrit.cloudera.org:8080/#/c/11853/2/docs/topics/impala_adls.xml@92
PS2, Line 92:               <codeph>abfs(s)://</codeph> for ADLS Gen 2, for the
> nit: let's expand it out "abfs:// or abfss://".
Moved below and expanded - CREAT TABLE section.



-- 
To view, visit http://gerrit.cloudera.org:8080/11853
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic06d9ac92ed78b9092369e211de8a81db1d7ce90
Gerrit-Change-Number: 11853
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Mon, 05 Nov 2018 23:06:59 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7788: [DOCS] Impala supports ADLS Gen 2 (ABFS)

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.

Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11853 )

Change subject: IMPALA-7788: [DOCS] Impala supports ADLS Gen 2 (ABFS)
......................................................................

IMPALA-7788: [DOCS] Impala supports ADLS Gen 2 (ABFS)

Change-Id: Ic06d9ac92ed78b9092369e211de8a81db1d7ce90
Reviewed-on: http://gerrit.cloudera.org:8080/11853
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Reviewed-by: Jim Apple <jb...@apache.org>
---
M docs/shared/impala_common.xml
M docs/topics/impala_adls.xml
M docs/topics/impala_insert.xml
M docs/topics/impala_load_data.xml
4 files changed, 127 insertions(+), 97 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Joe McDonnell: Looks good to me, but someone else must approve
  Jim Apple: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/11853
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic06d9ac92ed78b9092369e211de8a81db1d7ce90
Gerrit-Change-Number: 11853
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] IMPALA-7244: [DOCS] Impala supports ADLS Gen 2 (ABFS)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11853 )

Change subject: IMPALA-7244: [DOCS] Impala supports ADLS Gen 2 (ABFS)
......................................................................


Patch Set 3: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/134/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/11853
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic06d9ac92ed78b9092369e211de8a81db1d7ce90
Gerrit-Change-Number: 11853
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Mon, 05 Nov 2018 23:18:45 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7244: [DOCS] Impala supports ADLS Gen 2 (ABFS)

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.

Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11853 )

Change subject: IMPALA-7244: [DOCS] Impala supports ADLS Gen 2 (ABFS)
......................................................................


Patch Set 3:

(4 comments)

A few minor comments.

http://gerrit.cloudera.org:8080/#/c/11853/3/docs/topics/impala_adls.xml
File docs/topics/impala_adls.xml:

http://gerrit.cloudera.org:8080/#/c/11853/3/docs/topics/impala_adls.xml@94
PS3, Line 94: abfs(s)://
Nit: I think it would make more sense to split this out.


http://gerrit.cloudera.org:8080/#/c/11853/3/docs/topics/impala_adls.xml@166
PS3, Line 166:       <p>For ADLS Gen2:</p>
             :       <codeblock> &lt;property>
             :     &lt;name>fs.azure.account.auth.type&lt;/name>
             :     &lt;value>OAuth&lt;/value>
             :   &lt;/property>
             : 
             :   &lt;property>
             :     &lt;name>fs.azure.account.oauth.provider.type&lt;/name>
             :     &lt;value>org.apache.hadoop.fs.azurebfs.oauth2.ClientCredsTokenProvider&lt;/value>
             :   &lt;/property>
             : 
             :   &lt;property>
             :     &lt;name>fs.azure.account.oauth2.client.id&lt;/name>
             :     &lt;value><varname>your_client_id</varname>&lt;/value>
             :   &lt;/property>
             : 
             :   &lt;property>
             :     &lt;name>fs.azure.account.oauth2.client.secret&lt;/name>
             :     &lt;value><varname>your_client_secret</varname>&lt;/value>
             :   &lt;/property>
             : 
             :   &lt;property>
             :     &lt;name>fs.azure.account.oauth2.client.endpoint&lt;/name>
             :     &lt;value>https://login.microsoftonline.com/<varname>your_azure_tenant_id</varname>/oauth2/token&lt;/value>
             :   &lt;/property></codeblock>
Double-checked this, and it matches what we are doing in core-site.xml for our tests.


http://gerrit.cloudera.org:8080/#/c/11853/3/docs/topics/impala_insert.xml
File docs/topics/impala_insert.xml:

http://gerrit.cloudera.org:8080/#/c/11853/3/docs/topics/impala_insert.xml@567
PS3, Line 567:       <p
             :         conref="../shared/impala_common.xml#common/insert_hidden_work_directory"/>
Nit: Do we need these whitespace-only changes?


http://gerrit.cloudera.org:8080/#/c/11853/3/docs/topics/impala_insert.xml@658
PS3, Line 658:       <p
             :         conref="../shared/impala_common.xml#common/char_varchar_cast_from_string"/>
             : 
             :       <p conref="../shared/impala_common.xml#common/related_options"/>
             : 
             :       <p rev="1.3.1"
             :         conref="../shared/impala_common.xml#common/insert_inherit_permissions"/>
Same here: whitespace-only changes



-- 
To view, visit http://gerrit.cloudera.org:8080/11853
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic06d9ac92ed78b9092369e211de8a81db1d7ce90
Gerrit-Change-Number: 11853
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Nov 2018 01:05:13 +0000
Gerrit-HasComments: Yes