You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/10/05 04:20:12 UTC
[GitHub] [superset] graceguo-supercat opened a new issue #16972: [native filters][filter]
graceguo-supercat opened a new issue #16972:
URL: https://github.com/apache/superset/issues/16972
#### How to reproduce the bug
1. Create a new dashboard with nested tabs like this layout:
<img width="1199" alt="Screen Shot 2021-10-04 at 9 00 26 PM" src="https://user-images.githubusercontent.com/27990562/135958048-4b97e68e-6bb0-4026-87e4-32290d65a6f3.png">
Tab1 has 1 row of markdown, and a few nested Tabs.
In tab "nested Tab1" and "nested Tab2", each has only 1 chart.
2. Add a few filter components:
- State Filter: Apply to **nested tab 2**
- Time Filter: Apply to **nested tab 1** and **nested tab 2**
3. Save dashboard
4. Go to dashboard list page, and visit the just created dashboard again: in nested tab 1, filter bar shows all filters out of scope.
#### Note ####
1. the filter scope data stored in dashboard metadata, is correct,
2. if i switch a few tabs back and forth, the in-scope filters and out-of-scope filters will display correct,
3. But if the landing tab has nested tab, it always show all filters are out of scope.
### Environment
(please complete the following information):
Latest master
- any feature flags active: dashboard filter component is enabled.
### Checklist
Make sure to follow these steps before submitting your issue - thank you!
- [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version of superset.
- [x] I have checked the issue tracker for the same issue and I haven't found one similar.
### Additional context
I label this bug as P1, since most users will feel their filter scope is totally messed up when they first seeing this issue. But probably this is only a small React render issue.
@michael-s-molina @kgabryje @junlincc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #16972: [native filters] Filters displayed as out of scope for dashboard with nested tabs
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #16972:
URL: https://github.com/apache/superset/issues/16972#issuecomment-937064640
@graceguo-supercat I agree with the priority! thanks for filing with details. @jinghua-qa can you make sure we have test case for this?
@kgabryje please add test in your fix PR. 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #16972: [native filters] Filters displayed as out of scope for dashboard with nested tabs
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #16972:
URL: https://github.com/apache/superset/issues/16972#issuecomment-937064640
@graceguo-supercat I agree with the priority! thanks for filing with details. @jinghua-qa can you make sure we have test case for this?
@kgabryje please add test in your fix PR. 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje closed issue #16972: [native filters] Filters displayed as out of scope for dashboard with nested tabs
Posted by GitBox <gi...@apache.org>.
kgabryje closed issue #16972:
URL: https://github.com/apache/superset/issues/16972
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jinghua-qa commented on issue #16972: [native filters] Filters displayed as out of scope for dashboard with nested tabs
Posted by GitBox <gi...@apache.org>.
jinghua-qa commented on issue #16972:
URL: https://github.com/apache/superset/issues/16972#issuecomment-940412366
test case added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on issue #16972: [native filters] Filters displayed as out of scope for dashboard with nested tabs
Posted by GitBox <gi...@apache.org>.
kgabryje commented on issue #16972:
URL: https://github.com/apache/superset/issues/16972#issuecomment-937668454
@graceguo-supercat Thanks for adding very detailed description and repro steps, that cut down time spent on debugging by half! 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje closed issue #16972: [native filters] Filters displayed as out of scope for dashboard with nested tabs
Posted by GitBox <gi...@apache.org>.
kgabryje closed issue #16972:
URL: https://github.com/apache/superset/issues/16972
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on issue #16972: [native filters] Filters displayed as out of scope for dashboard with nested tabs
Posted by GitBox <gi...@apache.org>.
kgabryje commented on issue #16972:
URL: https://github.com/apache/superset/issues/16972#issuecomment-937668454
@graceguo-supercat Thanks for adding very detailed description and repro steps, that cut down time spent on debugging by half! 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org