[GitHub] [incubator-echarts] 100pah opened a new pull request #11303: fix: dataZoom toolbox can not return to the original state.

[GitBox <gi...@apache.org>]

100pah opened a new pull request #11303: fix: dataZoom toolbox can not return to the original state.
URL: https://github.com/apache/incubator-echarts/pull/11303
 
 
   Suppose a "main process" start at the point that model prepared (that is,
   model initialized or merged or method called in `action`).
   We should keep the `main process` idempotent, that is, given a set of values
   on `option`, we get the same result.
   
   But sometimes, values on `option` will be updated for providing users
   a "final calculated value" (`dataZoomProcessor` will do that). Those value
   should not be the base/input of the `main process`.
   
   So in that case we should save and keep the input of the `main process`
   separately, called `settledOption`.
   
   For example, consider the case:
   (Step_1) brush zoom the grid by `toolbox.dataZoom`,
       where the original input `option.startValue`, `option.endValue` are earsed by
       calculated value.
   (Step)2) click the legend to hide and show a series,
       where the new range is calculated by the earsed `startValue` and `endValue`,
       which brings incorrect result.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org