You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "chesnokoff (via GitHub)" <gi...@apache.org> on 2026/04/29 15:57:57 UTC
[PR] IGNITE-28621 SQL: Add H2 map query details to system view and logs [ignite]
chesnokoff opened a new pull request, #13091:
URL: https://github.com/apache/ignite/pull/13091
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see tab `PR Check` at [TC.Bot - Instance 1](https://tcbot2.sbt-ignite-dev.ru/prs.html) or [TC.Bot - Instance 2](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28621 SQL: Add H2 map query details to system view and logs [ignite]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13091:
URL: https://github.com/apache/ignite/pull/13091#issuecomment-4450809549
## Possible compatibility issues. Please, check rolling upgrade cases
This PR modifies protected classes (with **Order** annotation).
Changes to these classes can break rolling upgrade compatibility.
**Affected files:**
- `modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/twostep/msg/GridH2DmlRequest.java`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28621 SQL: Add H2 map query details to system view and logs [ignite]
Posted by "chesnokoff (via GitHub)" <gi...@apache.org>.
chesnokoff commented on code in PR #13091:
URL: https://github.com/apache/ignite/pull/13091#discussion_r3199452920
##########
modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/twostep/GridMapQueryExecutor.java:
##########
@@ -567,6 +589,8 @@ private void onQueryRequest0(
if (qryInfo != null)
h2.heavyQueriesTracker().stopTracking(qryInfo, e);
+ h2.runningQueryManager().unregister(runningQryId, e);
Review Comment:
onNextPageRequest -> qryResults.cancel() (L974) -> MapQueryResult#close() -> Result#close -> h2.runningQueryManager().unregister(qryInfo.localQueryId(), null)
So looks like we already unregister it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28621 SQL: Add H2 map query details to system view and logs [ignite]
Posted by "alex-plekhanov (via GitHub)" <gi...@apache.org>.
alex-plekhanov commented on PR #13091:
URL: https://github.com/apache/ignite/pull/13091#issuecomment-4380882719
Any test for SqlQueryView?
Any test for query leakage (register - success - check that unregistered, register - throw an error on init of map phase - check that unregistered, register - throw an error on next page request - chech that unregistered)?
Any test for DML queries?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28621 SQL: Add H2 map query details to system view and logs [ignite]
Posted by "alex-plekhanov (via GitHub)" <gi...@apache.org>.
alex-plekhanov commented on code in PR #13091:
URL: https://github.com/apache/ignite/pull/13091#discussion_r3240166685
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/query/running/GridRunningQueryInfo.java:
##########
@@ -33,9 +33,12 @@ public class GridRunningQueryInfo {
/** */
private final long id;
- /** Originating Node ID. */
+ /** Node that owns query. */
private final UUID nodeId;
Review Comment:
It's a correct behaviour. `QUERY_ID` for map queries should be the same as for reduce queries. If someone wants to kill map query by query id, global query id should be used to kill the whole query, not only the map query.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28621 SQL: Add H2 map query details to system view and logs [ignite]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13091:
URL: https://github.com/apache/ignite/pull/13091#issuecomment-4425556233
## Possible compatibility issues. Please, check rolling upgrade cases
This PR modifies protected classes (with **Order** annotation).
Changes to these classes can break rolling upgrade compatibility.
**Affected files:**
- `modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/twostep/msg/GridH2DmlRequest.java`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28621 SQL: Add H2 map query details to system view and logs [ignite]
Posted by "alex-plekhanov (via GitHub)" <gi...@apache.org>.
alex-plekhanov commented on code in PR #13091:
URL: https://github.com/apache/ignite/pull/13091#discussion_r3241402599
##########
modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/SqlSystemViewsSelfTest.java:
##########
@@ -681,6 +682,84 @@ public void testRunningQueriesViewDuration() throws Exception {
}
}
+ /** Test SELECT and DML map query flags in running queries system view. */
+ @Test
+ public void testMapQueryRunningQueriesView() throws Exception {
+ IgniteEx ignite = startGrids(2);
+
+ IgniteCache<Integer, Integer> cache = createMapQueryTestCache(ignite);
+
+ checkMapQueryView(ignite, cache, "SELECT * FROM Integer WHERE sleep(?) >= 0");
+
+ checkMapQueryView(ignite, cache, "DELETE FROM Integer WHERE sleep(?) >= 0");
+ }
+
+ /** Test map query is unregistered from running queries system view on error. */
+ @Test
+ public void testMapQueryRunningQueriesViewOnError() throws Exception {
+ IgniteEx ignite = startGrids(2);
+
+ IgniteCache<Integer, Integer> cache = createMapQueryTestCache(ignite);
+
+ String initiatorId = UUID.randomUUID().toString();
+
+ GridTestUtils.assertThrows(log,
+ () -> cache.query(new SqlFieldsQuery("SELECT * FROM Integer WHERE can_fail(_key = 0) = 0")
+ .setQueryInitiatorId(initiatorId)).getAll(),
+ CacheException.class,
+ "Exception calling user-defined function");
+
+ assertTrue(waitForCondition(() -> !hasMapQueryView(ignite, initiatorId), 5_000));
+ }
+
+ /** */
+ private void checkMapQueryView(IgniteEx ignite, IgniteCache<Integer, Integer> cache, String sql) throws Exception {
+ String initiatorId = UUID.randomUUID().toString();
+
+ IgniteInternalFuture<?> fut = GridTestUtils.runAsync(() ->
+ cache.query(new SqlFieldsQuery(sql).setQueryInitiatorId(initiatorId).setArgs(5_000)).getAll()
Review Comment:
5 seconds sleep for each query delay test for 10 seconds. I think 1 second here is enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28621 SQL: Add H2 map query details to system view and logs [ignite]
Posted by "chesnokoff (via GitHub)" <gi...@apache.org>.
chesnokoff commented on code in PR #13091:
URL: https://github.com/apache/ignite/pull/13091#discussion_r3226203409
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/query/running/GridRunningQueryInfo.java:
##########
@@ -33,9 +33,12 @@ public class GridRunningQueryInfo {
/** */
private final long id;
- /** Originating Node ID. */
+ /** Node that owns query. */
private final UUID nodeId;
Review Comment:
Rolled back the `nodeId` & `originNodeId` split
But for now map-query entries still use a locally generated running query id, so `SYS.SQL_QUERIES.QUERY_ID` for map rows is built as `<originNodeId>_<localMapQueryId>`. This means different map nodes can theoretically have the same `QUERY_ID` for their map rows
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28621 SQL: Add H2 map query details to system view and logs [ignite]
Posted by "chesnokoff (via GitHub)" <gi...@apache.org>.
chesnokoff commented on code in PR #13091:
URL: https://github.com/apache/ignite/pull/13091#discussion_r3179584473
##########
modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/SqlSystemViewsSelfTest.java:
##########
@@ -681,50 +681,6 @@ public void testRunningQueriesViewDuration() throws Exception {
}
}
- /** Test map query flag in running queries system view. */
- @Test
- public void testMapQueryRunningQueriesView() throws Exception {
- IgniteEx ignite = startGrids(2);
-
- IgniteCache<Integer, String> cache = ignite.createCache(
- new CacheConfiguration<Integer, String>(DEFAULT_CACHE_NAME)
- .setCacheMode(CacheMode.PARTITIONED)
- .setIndexedTypes(Integer.class, String.class)
- );
-
- for (int i = 0; i < 10; i++)
- cache.put(i, Integer.toString(i));
-
- awaitPartitionMapExchange();
-
- String initiatorId = UUID.randomUUID().toString();
-
- try (FieldsQueryCursor<List<?>> cursor = cache.query(new SqlFieldsQuery("SELECT * FROM String")
- .setQueryInitiatorId(initiatorId)
- .setPageSize(1))) {
- cursor.iterator().next();
-
- for (int i = 0; i < 2; i++) {
- int nodeIdx = i;
- UUID nodeId = grid(nodeIdx).localNode().id();
-
- assertTrue(waitForCondition(() -> {
- SystemView<SqlQueryView> view = grid(nodeIdx).context().systemView().view(SQL_QRY_VIEW);
-
- for (SqlQueryView qry : view) {
- if (qry.mapQuery()
- && nodeId.equals(qry.nodeId())
- && ignite.localNode().id().equals(qry.originNodeId())
- && initiatorId.equals(qry.initiatorId()))
- return true;
- }
-
- return false;
- }, 5_000));
- }
- }
- }
Review Comment:
Initially, created this test to check map queries but now I think the test may be flaky so I decided to rollback it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28621 SQL: Add H2 map query details to system view and logs [ignite]
Posted by "chesnokoff (via GitHub)" <gi...@apache.org>.
chesnokoff commented on code in PR #13091:
URL: https://github.com/apache/ignite/pull/13091#discussion_r3178565584
##########
modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/SqlSystemViewsSelfTest.java:
##########
@@ -681,6 +681,50 @@ public void testRunningQueriesViewDuration() throws Exception {
}
}
+ /** Test map query flag in running queries system view. */
+ @Test
+ public void testMapQueryRunningQueriesView() throws Exception {
+ IgniteEx ignite = startGrids(2);
+
+ IgniteCache<Integer, String> cache = ignite.createCache(
+ new CacheConfiguration<Integer, String>(DEFAULT_CACHE_NAME)
+ .setCacheMode(CacheMode.PARTITIONED)
+ .setIndexedTypes(Integer.class, String.class)
+ );
+
+ for (int i = 0; i < 10; i++)
+ cache.put(i, Integer.toString(i));
+
+ awaitPartitionMapExchange();
+
+ String initiatorId = UUID.randomUUID().toString();
+
+ try (FieldsQueryCursor<List<?>> cursor = cache.query(new SqlFieldsQuery("SELECT * FROM String")
+ .setQueryInitiatorId(initiatorId)
+ .setPageSize(1))) {
+ cursor.iterator().next();
+
+ for (int i = 0; i < 2; i++) {
+ int nodeIdx = i;
Review Comment:
effective final variable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28621 SQL: Add H2 map query details to system view and logs [ignite]
Posted by "alex-plekhanov (via GitHub)" <gi...@apache.org>.
alex-plekhanov commented on code in PR #13091:
URL: https://github.com/apache/ignite/pull/13091#discussion_r3189417082
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/query/running/RunningQueryManager.java:
##########
@@ -375,26 +439,28 @@ public void unregister(long qryId, @Nullable Throwable failReason) {
if (failed)
qrySpan.addTag(ERROR, failReason::getMessage);
- //We need to collect query history and metrics only for SQL queries.
Review Comment:
Looks like we can replace all futher changes in this method with just:
```
if (qry.mapQuery())
return;
```
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/query/running/GridRunningQueryInfo.java:
##########
@@ -33,9 +33,12 @@ public class GridRunningQueryInfo {
/** */
private final long id;
- /** Originating Node ID. */
+ /** Node that owns query. */
private final UUID nodeId;
Review Comment:
Such renaming is not quite correct. Global query id still uses `nodeId` as originator node. Performance statistics use `nodeId` as originator node (yes, it's currently only collected for reduce node, but it still not correct to pass `current node` as `originator node`). Also I'm not sure we need `current node` field at all. Maybe we should keep old naming and pass originator node id to this field for map queries.
##########
modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/twostep/GridMapQueryExecutor.java:
##########
@@ -567,6 +589,8 @@ private void onQueryRequest0(
if (qryInfo != null)
h2.heavyQueriesTracker().stopTracking(qryInfo, e);
+ h2.runningQueryManager().unregister(runningQryId, e);
Review Comment:
Do we need to unregister also in `onNextPageRequest` (in case of error)?
##########
modules/clients/src/test/java/org/apache/ignite/common/RunningQueryInfoCheckInitiatorTest.java:
##########
@@ -336,7 +336,7 @@ private String initiatorId(IgniteEx node, String sqlMatch, int timeout) throws E
fail("Timeout. Cannot find query with: " + sqlMatch);
List<List<?>> res = node.context().query().querySqlFields(
- new SqlFieldsQuery("SELECT sql, initiator_id FROM SYS.SQL_QUERIES"), false).getAll();
+ new SqlFieldsQuery("SELECT sql, initiator_id FROM SYS.SQL_QUERIES WHERE MAP_QUERY = FALSE"), false).getAll();
Review Comment:
Looks like an issue. Users use `initiatorId` like `label`. Maybe it's worth to pass it together with map query request (maybe by another ticket)
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/query/running/RunningQueryManager.java:
##########
@@ -375,26 +439,28 @@ public void unregister(long qryId, @Nullable Throwable failReason) {
if (failed)
qrySpan.addTag(ERROR, failReason::getMessage);
- //We need to collect query history and metrics only for SQL queries.
if (isSqlQuery(qry)) {
qry.runningFuture().onDone();
- qryHistTracker.collectHistory(qry, failed);
+ // We need to collect query history and metrics only for external SQL queries.
Review Comment:
`External` is not a good definition here. I think something like `Initiated by user` is better.
##########
modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/MapH2QueryInfo.java:
##########
@@ -30,11 +30,15 @@ public class MapH2QueryInfo extends H2QueryInfo {
/** Segment. */
private final int segment;
+ /** Running query id. */
+ private final long runningQryId;
Review Comment:
Maybe "local query id"?
##########
modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/SqlSystemViewsSelfTest.java:
##########
@@ -681,50 +681,6 @@ public void testRunningQueriesViewDuration() throws Exception {
}
}
- /** Test map query flag in running queries system view. */
- @Test
- public void testMapQueryRunningQueriesView() throws Exception {
- IgniteEx ignite = startGrids(2);
-
- IgniteCache<Integer, String> cache = ignite.createCache(
- new CacheConfiguration<Integer, String>(DEFAULT_CACHE_NAME)
- .setCacheMode(CacheMode.PARTITIONED)
- .setIndexedTypes(Integer.class, String.class)
- );
-
- for (int i = 0; i < 10; i++)
- cache.put(i, Integer.toString(i));
-
- awaitPartitionMapExchange();
-
- String initiatorId = UUID.randomUUID().toString();
-
- try (FieldsQueryCursor<List<?>> cursor = cache.query(new SqlFieldsQuery("SELECT * FROM String")
- .setQueryInitiatorId(initiatorId)
- .setPageSize(1))) {
- cursor.iterator().next();
-
- for (int i = 0; i < 2; i++) {
- int nodeIdx = i;
- UUID nodeId = grid(nodeIdx).localNode().id();
-
- assertTrue(waitForCondition(() -> {
- SystemView<SqlQueryView> view = grid(nodeIdx).context().systemView().view(SQL_QRY_VIEW);
-
- for (SqlQueryView qry : view) {
- if (qry.mapQuery()
- && nodeId.equals(qry.nodeId())
- && ignite.localNode().id().equals(qry.originNodeId())
- && initiatorId.equals(qry.initiatorId()))
- return true;
- }
-
- return false;
- }, 5_000));
- }
- }
- }
Review Comment:
To make it non flaky you can use some user-defined function with latch or sleep.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28621 SQL: Add H2 map query details to system view and logs [ignite]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #13091:
URL: https://github.com/apache/ignite/pull/13091#issuecomment-4457560892
## [](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=13091) **Quality Gate failed**
Failed conditions
 [2 New Code Smells](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=13091) (required ≤ 1)
<!-- sqra:qg_revision=5ab9100c5c415d3983c5ae70d21b8b66572276bda36d5afb5d6455598d33875c -->
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=13091)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28621 SQL: Add H2 map query details to system view and logs [ignite]
Posted by "asf-gitbox-commits (via GitHub)" <gi...@apache.org>.
asf-gitbox-commits closed pull request #13091: IGNITE-28621 SQL: Add H2 map query details to system view and logs
URL: https://github.com/apache/ignite/pull/13091
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28621 SQL: Add H2 map query details to system view and logs [ignite]
Posted by "chesnokoff (via GitHub)" <gi...@apache.org>.
chesnokoff commented on code in PR #13091:
URL: https://github.com/apache/ignite/pull/13091#discussion_r3179584473
##########
modules/indexing/src/test/java/org/apache/ignite/internal/processors/query/SqlSystemViewsSelfTest.java:
##########
@@ -681,50 +681,6 @@ public void testRunningQueriesViewDuration() throws Exception {
}
}
- /** Test map query flag in running queries system view. */
- @Test
- public void testMapQueryRunningQueriesView() throws Exception {
- IgniteEx ignite = startGrids(2);
-
- IgniteCache<Integer, String> cache = ignite.createCache(
- new CacheConfiguration<Integer, String>(DEFAULT_CACHE_NAME)
- .setCacheMode(CacheMode.PARTITIONED)
- .setIndexedTypes(Integer.class, String.class)
- );
-
- for (int i = 0; i < 10; i++)
- cache.put(i, Integer.toString(i));
-
- awaitPartitionMapExchange();
-
- String initiatorId = UUID.randomUUID().toString();
-
- try (FieldsQueryCursor<List<?>> cursor = cache.query(new SqlFieldsQuery("SELECT * FROM String")
- .setQueryInitiatorId(initiatorId)
- .setPageSize(1))) {
- cursor.iterator().next();
-
- for (int i = 0; i < 2; i++) {
- int nodeIdx = i;
- UUID nodeId = grid(nodeIdx).localNode().id();
-
- assertTrue(waitForCondition(() -> {
- SystemView<SqlQueryView> view = grid(nodeIdx).context().systemView().view(SQL_QRY_VIEW);
-
- for (SqlQueryView qry : view) {
- if (qry.mapQuery()
- && nodeId.equals(qry.nodeId())
- && ignite.localNode().id().equals(qry.originNodeId())
- && initiatorId.equals(qry.initiatorId()))
- return true;
- }
-
- return false;
- }, 5_000));
- }
- }
- }
Review Comment:
Initially, created this test to check map queries but now I think the test may be flaky so I decided to rollback it (the test passed for visa)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28621 SQL: Add H2 map query details to system view and logs [ignite]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13091:
URL: https://github.com/apache/ignite/pull/13091#issuecomment-4430245017
## Possible compatibility issues. Please, check rolling upgrade cases
This PR modifies protected classes (with **Order** annotation).
Changes to these classes can break rolling upgrade compatibility.
**Affected files:**
- `modules/indexing/src/main/java/org/apache/ignite/internal/processors/query/h2/twostep/msg/GridH2DmlRequest.java`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org