[GitHub] [spark] wzhfy commented on a change in pull request #34587: [SPARK-36876][SQL][TESTS][FOLLOW-UP] Support Dynamic Partition pruning for HiveTableScanExec

[GitBox <gi...@apache.org>]

wzhfy commented on a change in pull request #34587:
URL: https://github.com/apache/spark/pull/34587#discussion_r748964913



##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/DynamicPartitionPruningHiveScanSuite.scala
##########
@@ -33,12 +32,6 @@ abstract class DynamicPartitionPruningHiveScanSuite
 
   override protected def collectDynamicPruningExpressions(plan: SparkPlan): Seq[Expression] = {
     flatMap(plan) {
-      case s: FileSourceScanExec => s.partitionFilters.collect {
-        case d: DynamicPruningExpression => d.child
-      }
-      case s: BatchScanExec => s.runtimeFilters.collect {
-        case d: DynamicPruningExpression => d.child
-      }

Review comment:
       not related to this change, but better to also rename `DynamicPartitionPruningHiveScanSuite` to `DynamicPartitionPruningHiveScanSuiteBase`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org