You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@netbeans.apache.org by geertjanw <gi...@git.apache.org> on 2017/10/08 21:17:54 UTC

[GitHub] incubator-netbeans pull request #104: [NETBEANS-54] Module Review libs.osgi

GitHub user geertjanw opened a pull request:

    https://github.com/apache/incubator-netbeans/pull/104

    [NETBEANS-54] Module Review libs.osgi

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/geertjanw/incubator-netbeans netbeans-54-review-libs.osgi

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-netbeans/pull/104.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #104
    
----
commit 96c48b315a585197672e5a0975cedfa1a2b30438
Author: geertjan <ge...@oracle.com>
Date:   2017-10-08T21:17:22Z

    [NETBEANS-54] Module Review libs.osgi

----


---

[GitHub] incubator-netbeans pull request #104: [NETBEANS-54] Module Review libs.osgi

Posted by geertjanw <gi...@git.apache.org>.

Github user geertjanw commented on a diff in the pull request:

    https://github.com/apache/incubator-netbeans/pull/104#discussion_r144721265
  
    --- Diff: libs.osgi/external/binaries-list ---
    @@ -14,5 +14,5 @@
     # KIND, either express or implied.  See the License for the
     # specific language governing permissions and limitations
     # under the License.
    -972E6455724DC6ADB1C1912F53B5E3D7DF20C5FD osgi.cmpn-4.2.jar
    -2F2FBFF3FB80F91B159A7FA9F0C42A894BB8BCC5 osgi.core-5.0.0.jar
    +972E6455724DC6ADB1C1912F53B5E3D7DF20C5FD org.netbeans.external:osgi.cmpn:4.2
    --- End diff --
    
    I'd rather wait until later to do this. This co-ordinate works (http://mvnrepository.com/artifact/org.netbeans.external/osgi.cmpn-4.2/RELEASE82) and is closer to the original entry in binaries-list than the primary equivalent.


---

[GitHub] incubator-netbeans pull request #104: [NETBEANS-54] Module Review libs.osgi

Posted by matthiasblaesing <gi...@git.apache.org>.

Github user matthiasblaesing commented on a diff in the pull request:

    https://github.com/apache/incubator-netbeans/pull/104#discussion_r144722875
  
    --- Diff: libs.osgi/external/binaries-list ---
    @@ -14,5 +14,5 @@
     # KIND, either express or implied.  See the License for the
     # specific language governing permissions and limitations
     # under the License.
    -972E6455724DC6ADB1C1912F53B5E3D7DF20C5FD osgi.cmpn-4.2.jar
    -2F2FBFF3FB80F91B159A7FA9F0C42A894BB8BCC5 osgi.core-5.0.0.jar
    +972E6455724DC6ADB1C1912F53B5E3D7DF20C5FD org.netbeans.external:osgi.cmpn:4.2
    --- End diff --
    
    Your link shows, that the referenced binary is not present in maven central, but only in the netbeans repository (see the "Repositories" row). The download binaries task has maven central hard-coded, so the binary won't be found.
    
    It works for you (and me), because there are multiple fallbacks:
    - local maven2 cache ($HOME/.m2/repository)
    - fallback to load the file from `http://hg.netbeans.org/binaries/`
    
    I would not change the binary reference, as currently there is no valuable alternative. And I can support your assessment not to change the binary right now. This makes it clear, that this needs to be tackled later.


---

[GitHub] incubator-netbeans pull request #104: [NETBEANS-54] Module Review libs.osgi

Posted by matthiasblaesing <gi...@git.apache.org>.

Github user matthiasblaesing commented on a diff in the pull request:

    https://github.com/apache/incubator-netbeans/pull/104#discussion_r143545978
  
    --- Diff: libs.osgi/external/binaries-list ---
    @@ -14,5 +14,5 @@
     # KIND, either express or implied.  See the License for the
     # specific language governing permissions and limitations
     # under the License.
    -972E6455724DC6ADB1C1912F53B5E3D7DF20C5FD osgi.cmpn-4.2.jar
    -2F2FBFF3FB80F91B159A7FA9F0C42A894BB8BCC5 osgi.core-5.0.0.jar
    +972E6455724DC6ADB1C1912F53B5E3D7DF20C5FD org.netbeans.external:osgi.cmpn:4.2
    --- End diff --
    
    How does this work? I don't see this on maven central. There are osgi.cmpn artifacts in the org.osgi group, just different versions. I would use this opportunity to move to the "primary" ones.


---