You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "mengw15 (via GitHub)" <gi...@apache.org> on 2026/04/15 22:02:06 UTC
[PR] restore `../../sql` mount path in single-node docker-compose so Postgres init scripts run [texera]
mengw15 opened a new pull request, #4391:
URL: https://github.com/apache/texera/pull/4391
<!--
Thanks for sending a pull request (PR)! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
[Contributing to Texera](https://github.com/apache/texera/blob/main/CONTRIBUTING.md)
2. Ensure you have added or run the appropriate tests for your PR
3. If the PR is work in progress, mark it a draft on GitHub.
4. Please write your PR title to summarize what this PR proposes, we
are following Conventional Commits style for PR titles as well.
5. Be sure to keep the PR description updated to reflect all changes.
-->
### What changes were proposed in this PR?
<!--
Please clarify what changes you are proposing. The purpose of this section
is to outline the changes. Here are some tips for you:
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
3. If it is a refactoring, clarify what has been changed.
3. It would be helpful to include a before-and-after comparison using
screenshots or GIFs.
4. Please consider writing useful notes for better and faster reviews.
-->
Restore the Postgres init-script volume mount in bin/single-node/docker-compose.yml from ./sql back to ../../sql
### Any related issues, documentation, discussions?
<!--
Please use this section to link other resources if not mentioned already.
1. If this PR fixes an issue, please include `Fixes #1234`, `Resolves #1234`
or `Closes #1234`. If it is only related, simply mention the issue number.
2. If there is design documentation, please add the link.
3. If there is a discussion in the mailing list, please add the link.
-->
close #4390
### How was this PR tested?
<!--
If tests were added, say they were added here. Or simply mention that if the PR
is tested with existing test cases. Make sure to include/update test cases that
check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how
you tested step by step, ideally copy and paste-able, so that other reviewers can
test and check, and descendants can verify in the future. If tests were not added,
please describe why they were not added and/or why it was difficult to add.
-->
manually
### Was this PR authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please include the phrase: 'Generated-by: ' followed by the name of the tool
and its version. If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: restore `../../sql` mount path in single-node docker-compose so Postgres init scripts run [texera]
Posted by "mengw15 (via GitHub)" <gi...@apache.org>.
mengw15 commented on PR #4391:
URL: https://github.com/apache/texera/pull/4391#issuecomment-4257295894
> Can you try to create a symlink under bin/single-node pointing to sql/ at the root ? Basically mimic what bin/k8s/files did?
Currently, in .github/workflows/create-release-candidate.yml
line 160-162
` # Patch the SQL mount path for the self-contained bundle layout`
` # In the repo it's ../../sql (relative to bin/single-node/), in the bundle it's ./sql`
` sed -i 's|../../sql|./sql|g' "$BUNDLE_DIR/docker-compose.yml"`
we sed ../../sql with ./sql
if we mimic the bin/k8s/files, we may need to adjust here as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: restore `../../sql` mount path in single-node docker-compose so Postgres init scripts run [texera]
Posted by "mengw15 (via GitHub)" <gi...@apache.org>.
mengw15 commented on PR #4391:
URL: https://github.com/apache/texera/pull/4391#issuecomment-4271770960
> Try: docker compose -f bin/single-node --project-directory . --env-file bin/single-node/.env up
I tried docker compose -f bin/single-node --project-directory . --env-file bin/single-node/.env up, but it did not work on my side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: restore `../../sql` mount path in single-node docker-compose so Postgres init scripts run [texera]
Posted by "bobbai00 (via GitHub)" <gi...@apache.org>.
bobbai00 commented on PR #4391:
URL: https://github.com/apache/texera/pull/4391#issuecomment-4258249048
> > Can you try to create a symlink under bin/single-node pointing to sql/ at the root ? Basically mimic what bin/k8s/files did?
>
> Currently, in .github/workflows/create-release-candidate.yml line 160-162
>
> ` # Patch the SQL mount path for the self-contained bundle layout` ` # In the repo it's ../../sql (relative to bin/single-node/), in the bundle it's ./sql` ` sed -i 's|../../sql|./sql|g' "$BUNDLE_DIR/docker-compose.yml"`
>
> we sed ../../sql with ./sql
>
> if we mimic the bin/k8s/files, we may need to adjust here as well
sure, you may adjust the CI as well. I feel '../../sql' should be avoided. Please try the symlink way and see if it works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: restore `../../sql` mount path in single-node docker-compose so Postgres init scripts run [texera]
Posted by "bobbai00 (via GitHub)" <gi...@apache.org>.
bobbai00 commented on PR #4391:
URL: https://github.com/apache/texera/pull/4391#issuecomment-4257267265
Can you try to create a symlink under bin/single-node pointing to `sql/` at the root ? Basically mimic what `bin/k8s/files` did?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: restore `../../sql` mount path in single-node docker-compose so Postgres init scripts run [texera]
Posted by "mengw15 (via GitHub)" <gi...@apache.org>.
mengw15 commented on PR #4391:
URL: https://github.com/apache/texera/pull/4391#issuecomment-4258344093
> sure, you may adjust the CI as well. I feel '../../sql' should be avoided. Please try the symlink way and see if it works.
I tested this by running docker compose up under bin/single-node, but this symlink way seems doesn't work. The reason could be Docker bind mounts preserve symlinks as-is rather than resolving them. Inside the container, the symlink target ../../../sql/xxx.sql resolves against the container's filesystem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: restore `../../sql` mount path in single-node docker-compose so Postgres init scripts run [texera]
Posted by "bobbai00 (via GitHub)" <gi...@apache.org>.
bobbai00 commented on PR #4391:
URL: https://github.com/apache/texera/pull/4391#issuecomment-4274842969
> > Try: docker compose -f bin/single-node --project-directory . --env-file bin/single-node/.env up
>
> I tried docker compose -f bin/single-node --project-directory . --env-file bin/single-node/.env up, but it did not work on my side.
OK. Approved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: restore `../../sql` mount path in single-node docker-compose so Postgres init scripts run [texera]
Posted by "bobbai00 (via GitHub)" <gi...@apache.org>.
bobbai00 commented on PR #4391:
URL: https://github.com/apache/texera/pull/4391#issuecomment-4261735051
> > sure, you may adjust the CI as well. I feel '../../sql' should be avoided. Please try the symlink way and see if it works.
>
> I tested this by running docker compose up under bin/single-node, but this symlink way seems doesn't work. The reason could be Docker bind mounts preserve symlinks as-is rather than resolving them. Inside the container, the symlink target ../../../sql/xxx.sql resolves against the container's filesystem.
>
> I remember we were using '../../sql' in the past
Try: `docker compose -f bin/single-node --project-directory . --env-file bin/single-node/.env up`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: restore `../../sql` mount path in single-node docker-compose so Postgres init scripts run [texera]
Posted by "mengw15 (via GitHub)" <gi...@apache.org>.
mengw15 merged PR #4391:
URL: https://github.com/apache/texera/pull/4391
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org