[GitHub] [hbase] openinx commented on a change in pull request #796: HBASE-23251 - Add Column Family and Table Names to HFileContext and u…

[GitBox <gi...@apache.org>]

openinx commented on a change in pull request #796: HBASE-23251 - Add Column Family and Table Names to HFileContext and u…
URL: https://github.com/apache/hbase/pull/796#discussion_r343960468
 
 

 ##########
 File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileContext.java
 ##########
 @@ -233,6 +255,14 @@ public String toString() {
       sb.append(", name=");
       sb.append(hfileName);
     }
+    if (tableName != null) {
+      sb.append(", tableName=");
+      sb.append(Bytes.toString(tableName));
+    }
+    if (columnFamily != null) {
+      sb.append(", columnFamily=");
+      sb.append(Bytes.toString(columnFamily));
 
 Review comment:
   Also better to use the Bytes.toStringBinary(columnFamily) ? because there's some unprintable char in the byte[] ....

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services