You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/09/14 10:40:53 UTC

[GitHub] [superset] dpgaspar commented on a change in pull request #16674: fix: report with timeout chart

dpgaspar commented on a change in pull request #16674:
URL: https://github.com/apache/superset/pull/16674#discussion_r708141925



##########
File path: superset/utils/webdriver.py
##########
@@ -141,6 +141,7 @@ def get_screenshot(
             img = element.screenshot_as_png
         except TimeoutException:
             logger.warning("Selenium timed out requesting url %s", url, exc_info=True)
+            img = element.screenshot_as_png

Review comment:
       is it always possible to call `element.screenshot_as_png` without raising when a `TimeoutException` occurs?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org