You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Joshua Cohen <jc...@apache.org> on 2016/01/29 18:53:00 UTC
Review Request 42964: Add flag to optionally disable the leader
redirect filter.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42964/
-----------------------------------------------------------
Review request for Aurora, Bill Farner and Zameer Manji.
Bugs: AURORA-1601
https://issues.apache.org/jira/browse/AURORA-1601
Repository: aurora
Description
-------
Add flag to optionally disable the leader redirect filter.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java df649ff4ffdc741afdbc4850c2dbf98bd3e218f1
src/test/java/org/apache/aurora/scheduler/http/AbstractJettyTest.java 19c8a1fe06a333324022da11f74d7c96b2942587
Diff: https://reviews.apache.org/r/42964/diff/
Testing
-------
./gradlew build -Pq
Thanks,
Joshua Cohen
Re: Review Request 42964: Add flag to optionally disable the leader
redirect filter.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42964/#review116974
-----------------------------------------------------------
Ship it!
Master (0eb753d) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 29, 2016, 5:53 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42964/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2016, 5:53 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1601
> https://issues.apache.org/jira/browse/AURORA-1601
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add flag to optionally disable the leader redirect filter.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java df649ff4ffdc741afdbc4850c2dbf98bd3e218f1
> src/test/java/org/apache/aurora/scheduler/http/AbstractJettyTest.java 19c8a1fe06a333324022da11f74d7c96b2942587
>
> Diff: https://reviews.apache.org/r/42964/diff/
>
>
> Testing
> -------
>
> ./gradlew build -Pq
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 42964: Add flag to optionally disable the leader
redirect filter.
Posted by Joshua Cohen <jc...@apache.org>.
> On Jan. 29, 2016, 6:18 p.m., Bill Farner wrote:
> > Exploring ideas - would an HTTP header be more handy for this?
I like that idea, would save a restart and it would potentially be more generally useful. Will send an update going in that direction.
- Joshua
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42964/#review116973
-----------------------------------------------------------
On Jan. 29, 2016, 5:53 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42964/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2016, 5:53 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1601
> https://issues.apache.org/jira/browse/AURORA-1601
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add flag to optionally disable the leader redirect filter.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java df649ff4ffdc741afdbc4850c2dbf98bd3e218f1
> src/test/java/org/apache/aurora/scheduler/http/AbstractJettyTest.java 19c8a1fe06a333324022da11f74d7c96b2942587
>
> Diff: https://reviews.apache.org/r/42964/diff/
>
>
> Testing
> -------
>
> ./gradlew build -Pq
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 42964: Add flag to optionally disable the leader
redirect filter.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42964/#review116973
-----------------------------------------------------------
Exploring ideas - would an HTTP header be more handy for this?
- Bill Farner
On Jan. 29, 2016, 9:53 a.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42964/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2016, 9:53 a.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1601
> https://issues.apache.org/jira/browse/AURORA-1601
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add flag to optionally disable the leader redirect filter.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java df649ff4ffdc741afdbc4850c2dbf98bd3e218f1
> src/test/java/org/apache/aurora/scheduler/http/AbstractJettyTest.java 19c8a1fe06a333324022da11f74d7c96b2942587
>
> Diff: https://reviews.apache.org/r/42964/diff/
>
>
> Testing
> -------
>
> ./gradlew build -Pq
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 42964: Add header to allow bypassing the
LeaderRedirectFilter.
Posted by Joshua Cohen <jc...@apache.org>.
> On Jan. 29, 2016, 10:42 p.m., Stephan Erb wrote:
> > If this is crucial for recovery, this should really be documented.
Yeah, for sure. I filed https://issues.apache.org/jira/browse/AURORA-1605 to track updating the recovery docs.
- Joshua
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42964/#review117036
-----------------------------------------------------------
On Jan. 29, 2016, 8:54 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42964/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2016, 8:54 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1601
> https://issues.apache.org/jira/browse/AURORA-1601
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add header to allow bypassing the LeaderRedirectFilter.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java 41b99846bff65c4d10d5d74ca8534768b0ce3fd3
> src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 21371d951f8c6e44c40f97793d6acd26d3ca5614
>
> Diff: https://reviews.apache.org/r/42964/diff/
>
>
> Testing
> -------
>
> ./gradlew build -Pq
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 42964: Add header to allow bypassing the
LeaderRedirectFilter.
Posted by Stephan Erb <st...@dev.static-void.de>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42964/#review117036
-----------------------------------------------------------
If this is crucial for recovery, this should really be documented.
- Stephan Erb
On Jan. 29, 2016, 9:54 nachm., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42964/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2016, 9:54 nachm.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1601
> https://issues.apache.org/jira/browse/AURORA-1601
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add header to allow bypassing the LeaderRedirectFilter.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java 41b99846bff65c4d10d5d74ca8534768b0ce3fd3
> src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 21371d951f8c6e44c40f97793d6acd26d3ca5614
>
> Diff: https://reviews.apache.org/r/42964/diff/
>
>
> Testing
> -------
>
> ./gradlew build -Pq
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 42964: Add header to allow bypassing the
LeaderRedirectFilter.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42964/#review117026
-----------------------------------------------------------
Ship it!
Master (0eb753d) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 29, 2016, 8:54 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42964/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2016, 8:54 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1601
> https://issues.apache.org/jira/browse/AURORA-1601
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add header to allow bypassing the LeaderRedirectFilter.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java 41b99846bff65c4d10d5d74ca8534768b0ce3fd3
> src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 21371d951f8c6e44c40f97793d6acd26d3ca5614
>
> Diff: https://reviews.apache.org/r/42964/diff/
>
>
> Testing
> -------
>
> ./gradlew build -Pq
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 42964: Add header to allow bypassing the
LeaderRedirectFilter.
Posted by Joshua Cohen <jc...@apache.org>.
> On Feb. 1, 2016, 8:38 p.m., Bill Farner wrote:
> > src/main/python/apache/aurora/client/api/scheduler_client.py, line 56
> > <https://reviews.apache.org/r/42964/diff/3/?file=1228596#file1228596line56>
> >
> > Strings don't match - all the more reason this demands:
> >
> > a.) a constant, likely in api.thrift
> > b.) an end-to-end test (you could turn off ZK and make sure you can still send a simple API request to the scheduler)
Added a constant and an end to end test to validate the behavior.
- Joshua
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42964/#review117259
-----------------------------------------------------------
On Feb. 2, 2016, 8:54 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42964/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2016, 8:54 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1601
> https://issues.apache.org/jira/browse/AURORA-1601
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add header to allow bypassing the LeaderRedirectFilter.
>
>
> Diffs
> -----
>
> api/src/main/thrift/org/apache/aurora/gen/api.thrift 12400a77db71084e91fc9082132d1e601f8088f0
> examples/vagrant/clusters_direct.json PRE-CREATION
> examples/vagrant/upstart/aurora-scheduler-await-registration.conf PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java 41b99846bff65c4d10d5d74ca8534768b0ce3fd3
> src/main/python/apache/aurora/admin/admin.py 750b616dc9c4855733ddb2ff89c29d5a85af29af
> src/main/python/apache/aurora/admin/aurora_admin.py 470b2d2339284de9246b35daa0af1c2b832c232d
> src/main/python/apache/aurora/client/api/__init__.py 1b2ce4d44f3650d7136006ed12319cdf37ae353e
> src/main/python/apache/aurora/client/api/scheduler_client.py 86366240a48ebb576f7e3e5406cbc207fcd8df59
> src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 21371d951f8c6e44c40f97793d6acd26d3ca5614
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 4c4caaf76ce9f529c834f33f786036022766044d
> src/test/sh/org/apache/aurora/e2e/test_bypass_leader_redirect_end_to_end.sh PRE-CREATION
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 1171dca4af01a11e684f0b7a63a50250a8da1d22
>
> Diff: https://reviews.apache.org/r/42964/diff/
>
>
> Testing
> -------
>
> ./gradlew build -Pq
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 42964: Add header to allow bypassing the
LeaderRedirectFilter.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42964/#review117259
-----------------------------------------------------------
src/main/python/apache/aurora/client/api/scheduler_client.py (line 56)
<https://reviews.apache.org/r/42964/#comment178410>
Strings don't match - all the more reason this demands:
a.) a constant, likely in api.thrift
b.) an end-to-end test (you could turn off ZK and make sure you can still send a simple API request to the scheduler)
- Bill Farner
On Feb. 1, 2016, 12:05 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42964/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2016, 12:05 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1601
> https://issues.apache.org/jira/browse/AURORA-1601
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add header to allow bypassing the LeaderRedirectFilter.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java 41b99846bff65c4d10d5d74ca8534768b0ce3fd3
> src/main/python/apache/aurora/admin/admin.py 750b616dc9c4855733ddb2ff89c29d5a85af29af
> src/main/python/apache/aurora/admin/aurora_admin.py 470b2d2339284de9246b35daa0af1c2b832c232d
> src/main/python/apache/aurora/client/api/__init__.py 1b2ce4d44f3650d7136006ed12319cdf37ae353e
> src/main/python/apache/aurora/client/api/scheduler_client.py 86366240a48ebb576f7e3e5406cbc207fcd8df59
> src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 21371d951f8c6e44c40f97793d6acd26d3ca5614
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 4c4caaf76ce9f529c834f33f786036022766044d
>
> Diff: https://reviews.apache.org/r/42964/diff/
>
>
> Testing
> -------
>
> ./gradlew build -Pq
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 42964: Add header to allow bypassing the
LeaderRedirectFilter.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42964/#review117258
-----------------------------------------------------------
Ship it!
Master (de0029b) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 1, 2016, 8:05 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42964/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2016, 8:05 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1601
> https://issues.apache.org/jira/browse/AURORA-1601
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add header to allow bypassing the LeaderRedirectFilter.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java 41b99846bff65c4d10d5d74ca8534768b0ce3fd3
> src/main/python/apache/aurora/admin/admin.py 750b616dc9c4855733ddb2ff89c29d5a85af29af
> src/main/python/apache/aurora/admin/aurora_admin.py 470b2d2339284de9246b35daa0af1c2b832c232d
> src/main/python/apache/aurora/client/api/__init__.py 1b2ce4d44f3650d7136006ed12319cdf37ae353e
> src/main/python/apache/aurora/client/api/scheduler_client.py 86366240a48ebb576f7e3e5406cbc207fcd8df59
> src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 21371d951f8c6e44c40f97793d6acd26d3ca5614
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 4c4caaf76ce9f529c834f33f786036022766044d
>
> Diff: https://reviews.apache.org/r/42964/diff/
>
>
> Testing
> -------
>
> ./gradlew build -Pq
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 42964: Add header to allow bypassing the
LeaderRedirectFilter.
Posted by Joshua Cohen <jc...@apache.org>.
> On Feb. 1, 2016, 8:41 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java, line 64
> > <https://reviews.apache.org/r/42964/diff/3/?file=1228592#file1228592line64>
> >
> > Mini drive-by, but personally i'd rather just see `!= null` here. More readable.
Done.
- Joshua
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42964/#review117261
-----------------------------------------------------------
On Feb. 2, 2016, 8:54 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42964/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2016, 8:54 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1601
> https://issues.apache.org/jira/browse/AURORA-1601
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add header to allow bypassing the LeaderRedirectFilter.
>
>
> Diffs
> -----
>
> api/src/main/thrift/org/apache/aurora/gen/api.thrift 12400a77db71084e91fc9082132d1e601f8088f0
> examples/vagrant/clusters_direct.json PRE-CREATION
> examples/vagrant/upstart/aurora-scheduler-await-registration.conf PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java 41b99846bff65c4d10d5d74ca8534768b0ce3fd3
> src/main/python/apache/aurora/admin/admin.py 750b616dc9c4855733ddb2ff89c29d5a85af29af
> src/main/python/apache/aurora/admin/aurora_admin.py 470b2d2339284de9246b35daa0af1c2b832c232d
> src/main/python/apache/aurora/client/api/__init__.py 1b2ce4d44f3650d7136006ed12319cdf37ae353e
> src/main/python/apache/aurora/client/api/scheduler_client.py 86366240a48ebb576f7e3e5406cbc207fcd8df59
> src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 21371d951f8c6e44c40f97793d6acd26d3ca5614
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 4c4caaf76ce9f529c834f33f786036022766044d
> src/test/sh/org/apache/aurora/e2e/test_bypass_leader_redirect_end_to_end.sh PRE-CREATION
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 1171dca4af01a11e684f0b7a63a50250a8da1d22
>
> Diff: https://reviews.apache.org/r/42964/diff/
>
>
> Testing
> -------
>
> ./gradlew build -Pq
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 42964: Add header to allow bypassing the
LeaderRedirectFilter.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42964/#review117261
-----------------------------------------------------------
src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java (line 64)
<https://reviews.apache.org/r/42964/#comment178412>
Mini drive-by, but personally i'd rather just see `!= null` here. More readable.
- Bill Farner
On Feb. 1, 2016, 12:05 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42964/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2016, 12:05 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1601
> https://issues.apache.org/jira/browse/AURORA-1601
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add header to allow bypassing the LeaderRedirectFilter.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java 41b99846bff65c4d10d5d74ca8534768b0ce3fd3
> src/main/python/apache/aurora/admin/admin.py 750b616dc9c4855733ddb2ff89c29d5a85af29af
> src/main/python/apache/aurora/admin/aurora_admin.py 470b2d2339284de9246b35daa0af1c2b832c232d
> src/main/python/apache/aurora/client/api/__init__.py 1b2ce4d44f3650d7136006ed12319cdf37ae353e
> src/main/python/apache/aurora/client/api/scheduler_client.py 86366240a48ebb576f7e3e5406cbc207fcd8df59
> src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 21371d951f8c6e44c40f97793d6acd26d3ca5614
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 4c4caaf76ce9f529c834f33f786036022766044d
>
> Diff: https://reviews.apache.org/r/42964/diff/
>
>
> Testing
> -------
>
> ./gradlew build -Pq
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 42964: Add header to allow bypassing the
LeaderRedirectFilter.
Posted by Joshua Cohen <jc...@apache.org>.
> On Feb. 1, 2016, 8:40 p.m., Zameer Manji wrote:
> > src/main/python/apache/aurora/admin/admin.py, line 72
> > <https://reviews.apache.org/r/42964/diff/3/?file=1228593#file1228593line72>
> >
> > I think you can just do `options.bypass_leader_redirect` because there is a default.
Yep, fixed.
- Joshua
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42964/#review117260
-----------------------------------------------------------
On Feb. 2, 2016, 8:54 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42964/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2016, 8:54 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1601
> https://issues.apache.org/jira/browse/AURORA-1601
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add header to allow bypassing the LeaderRedirectFilter.
>
>
> Diffs
> -----
>
> api/src/main/thrift/org/apache/aurora/gen/api.thrift 12400a77db71084e91fc9082132d1e601f8088f0
> examples/vagrant/clusters_direct.json PRE-CREATION
> examples/vagrant/upstart/aurora-scheduler-await-registration.conf PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java 41b99846bff65c4d10d5d74ca8534768b0ce3fd3
> src/main/python/apache/aurora/admin/admin.py 750b616dc9c4855733ddb2ff89c29d5a85af29af
> src/main/python/apache/aurora/admin/aurora_admin.py 470b2d2339284de9246b35daa0af1c2b832c232d
> src/main/python/apache/aurora/client/api/__init__.py 1b2ce4d44f3650d7136006ed12319cdf37ae353e
> src/main/python/apache/aurora/client/api/scheduler_client.py 86366240a48ebb576f7e3e5406cbc207fcd8df59
> src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 21371d951f8c6e44c40f97793d6acd26d3ca5614
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 4c4caaf76ce9f529c834f33f786036022766044d
> src/test/sh/org/apache/aurora/e2e/test_bypass_leader_redirect_end_to_end.sh PRE-CREATION
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 1171dca4af01a11e684f0b7a63a50250a8da1d22
>
> Diff: https://reviews.apache.org/r/42964/diff/
>
>
> Testing
> -------
>
> ./gradlew build -Pq
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 42964: Add header to allow bypassing the
LeaderRedirectFilter.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42964/#review117260
-----------------------------------------------------------
Fix it, then Ship it!
src/main/python/apache/aurora/admin/admin.py (line 72)
<https://reviews.apache.org/r/42964/#comment178411>
I think you can just do `options.bypass_leader_redirect` because there is a default.
- Zameer Manji
On Feb. 1, 2016, 12:05 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42964/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2016, 12:05 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1601
> https://issues.apache.org/jira/browse/AURORA-1601
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add header to allow bypassing the LeaderRedirectFilter.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java 41b99846bff65c4d10d5d74ca8534768b0ce3fd3
> src/main/python/apache/aurora/admin/admin.py 750b616dc9c4855733ddb2ff89c29d5a85af29af
> src/main/python/apache/aurora/admin/aurora_admin.py 470b2d2339284de9246b35daa0af1c2b832c232d
> src/main/python/apache/aurora/client/api/__init__.py 1b2ce4d44f3650d7136006ed12319cdf37ae353e
> src/main/python/apache/aurora/client/api/scheduler_client.py 86366240a48ebb576f7e3e5406cbc207fcd8df59
> src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 21371d951f8c6e44c40f97793d6acd26d3ca5614
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 4c4caaf76ce9f529c834f33f786036022766044d
>
> Diff: https://reviews.apache.org/r/42964/diff/
>
>
> Testing
> -------
>
> ./gradlew build -Pq
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 42964: Add header to allow bypassing the
LeaderRedirectFilter.
Posted by Joshua Cohen <jc...@apache.org>.
> On Feb. 2, 2016, 9:29 p.m., Bill Farner wrote:
> > api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 1172
> > <https://reviews.apache.org/r/42964/diff/5/?file=1229950#file1229950line1172>
> >
> > Nit - rather than track the class name `LeaderRedirectFilter`, refer to the behavior.
Fixed.
> On Feb. 2, 2016, 9:29 p.m., Bill Farner wrote:
> > examples/vagrant/upstart/aurora-scheduler-await-registration.conf, line 1
> > <https://reviews.apache.org/r/42964/diff/5/?file=1229952#file1229952line1>
> >
> > Did you consider tearing down the master and restarting the scheduler instead?
> >
> > ```
> > sudo stop mesos-master
> > sudo restart aurora-scheduler
> > ```
Ahh, yes, that's a bit simpler, thanks.
- Joshua
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42964/#review117471
-----------------------------------------------------------
On Feb. 2, 2016, 9:51 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42964/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2016, 9:51 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1601
> https://issues.apache.org/jira/browse/AURORA-1601
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add header to allow bypassing the LeaderRedirectFilter.
>
>
> Diffs
> -----
>
> api/src/main/thrift/org/apache/aurora/gen/api.thrift 12400a77db71084e91fc9082132d1e601f8088f0
> examples/vagrant/clusters_direct.json PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java 41b99846bff65c4d10d5d74ca8534768b0ce3fd3
> src/main/python/apache/aurora/admin/admin.py 750b616dc9c4855733ddb2ff89c29d5a85af29af
> src/main/python/apache/aurora/admin/aurora_admin.py 470b2d2339284de9246b35daa0af1c2b832c232d
> src/main/python/apache/aurora/client/api/__init__.py 1b2ce4d44f3650d7136006ed12319cdf37ae353e
> src/main/python/apache/aurora/client/api/scheduler_client.py 86366240a48ebb576f7e3e5406cbc207fcd8df59
> src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 21371d951f8c6e44c40f97793d6acd26d3ca5614
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 4c4caaf76ce9f529c834f33f786036022766044d
> src/test/sh/org/apache/aurora/e2e/test_bypass_leader_redirect_end_to_end.sh PRE-CREATION
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 1171dca4af01a11e684f0b7a63a50250a8da1d22
>
> Diff: https://reviews.apache.org/r/42964/diff/
>
>
> Testing
> -------
>
> ./gradlew build -Pq
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 42964: Add header to allow bypassing the
LeaderRedirectFilter.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42964/#review117471
-----------------------------------------------------------
api/src/main/thrift/org/apache/aurora/gen/api.thrift (line 1172)
<https://reviews.apache.org/r/42964/#comment178676>
Nit - rather than track the class name `LeaderRedirectFilter`, refer to the behavior.
examples/vagrant/upstart/aurora-scheduler-await-registration.conf (line 1)
<https://reviews.apache.org/r/42964/#comment178681>
Did you consider tearing down the master and restarting the scheduler instead?
```
sudo stop mesos-master
sudo restart aurora-scheduler
```
- Bill Farner
On Feb. 2, 2016, 12:54 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42964/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2016, 12:54 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1601
> https://issues.apache.org/jira/browse/AURORA-1601
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add header to allow bypassing the LeaderRedirectFilter.
>
>
> Diffs
> -----
>
> api/src/main/thrift/org/apache/aurora/gen/api.thrift 12400a77db71084e91fc9082132d1e601f8088f0
> examples/vagrant/clusters_direct.json PRE-CREATION
> examples/vagrant/upstart/aurora-scheduler-await-registration.conf PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java 41b99846bff65c4d10d5d74ca8534768b0ce3fd3
> src/main/python/apache/aurora/admin/admin.py 750b616dc9c4855733ddb2ff89c29d5a85af29af
> src/main/python/apache/aurora/admin/aurora_admin.py 470b2d2339284de9246b35daa0af1c2b832c232d
> src/main/python/apache/aurora/client/api/__init__.py 1b2ce4d44f3650d7136006ed12319cdf37ae353e
> src/main/python/apache/aurora/client/api/scheduler_client.py 86366240a48ebb576f7e3e5406cbc207fcd8df59
> src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 21371d951f8c6e44c40f97793d6acd26d3ca5614
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 4c4caaf76ce9f529c834f33f786036022766044d
> src/test/sh/org/apache/aurora/e2e/test_bypass_leader_redirect_end_to_end.sh PRE-CREATION
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 1171dca4af01a11e684f0b7a63a50250a8da1d22
>
> Diff: https://reviews.apache.org/r/42964/diff/
>
>
> Testing
> -------
>
> ./gradlew build -Pq
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 42964: Add header to allow bypassing the
LeaderRedirectFilter.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42964/#review117473
-----------------------------------------------------------
Ship it!
Master (3fc9dc2) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 2, 2016, 8:54 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42964/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2016, 8:54 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1601
> https://issues.apache.org/jira/browse/AURORA-1601
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add header to allow bypassing the LeaderRedirectFilter.
>
>
> Diffs
> -----
>
> api/src/main/thrift/org/apache/aurora/gen/api.thrift 12400a77db71084e91fc9082132d1e601f8088f0
> examples/vagrant/clusters_direct.json PRE-CREATION
> examples/vagrant/upstart/aurora-scheduler-await-registration.conf PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java 41b99846bff65c4d10d5d74ca8534768b0ce3fd3
> src/main/python/apache/aurora/admin/admin.py 750b616dc9c4855733ddb2ff89c29d5a85af29af
> src/main/python/apache/aurora/admin/aurora_admin.py 470b2d2339284de9246b35daa0af1c2b832c232d
> src/main/python/apache/aurora/client/api/__init__.py 1b2ce4d44f3650d7136006ed12319cdf37ae353e
> src/main/python/apache/aurora/client/api/scheduler_client.py 86366240a48ebb576f7e3e5406cbc207fcd8df59
> src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 21371d951f8c6e44c40f97793d6acd26d3ca5614
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 4c4caaf76ce9f529c834f33f786036022766044d
> src/test/sh/org/apache/aurora/e2e/test_bypass_leader_redirect_end_to_end.sh PRE-CREATION
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 1171dca4af01a11e684f0b7a63a50250a8da1d22
>
> Diff: https://reviews.apache.org/r/42964/diff/
>
>
> Testing
> -------
>
> ./gradlew build -Pq
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 42964: Add header to allow bypassing the
LeaderRedirectFilter.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42964/#review117488
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On Feb. 2, 2016, 1:51 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42964/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2016, 1:51 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1601
> https://issues.apache.org/jira/browse/AURORA-1601
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add header to allow bypassing the LeaderRedirectFilter.
>
>
> Diffs
> -----
>
> api/src/main/thrift/org/apache/aurora/gen/api.thrift 12400a77db71084e91fc9082132d1e601f8088f0
> examples/vagrant/clusters_direct.json PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java 41b99846bff65c4d10d5d74ca8534768b0ce3fd3
> src/main/python/apache/aurora/admin/admin.py 750b616dc9c4855733ddb2ff89c29d5a85af29af
> src/main/python/apache/aurora/admin/aurora_admin.py 470b2d2339284de9246b35daa0af1c2b832c232d
> src/main/python/apache/aurora/client/api/__init__.py 1b2ce4d44f3650d7136006ed12319cdf37ae353e
> src/main/python/apache/aurora/client/api/scheduler_client.py 86366240a48ebb576f7e3e5406cbc207fcd8df59
> src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 21371d951f8c6e44c40f97793d6acd26d3ca5614
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 4c4caaf76ce9f529c834f33f786036022766044d
> src/test/sh/org/apache/aurora/e2e/test_bypass_leader_redirect_end_to_end.sh PRE-CREATION
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 1171dca4af01a11e684f0b7a63a50250a8da1d22
>
> Diff: https://reviews.apache.org/r/42964/diff/
>
>
> Testing
> -------
>
> ./gradlew build -Pq
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 42964: Add header to allow bypassing the
LeaderRedirectFilter.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42964/#review117491
-----------------------------------------------------------
Ship it!
Thanks for adding the test coverage!
- Bill Farner
On Feb. 2, 2016, 1:51 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42964/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2016, 1:51 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1601
> https://issues.apache.org/jira/browse/AURORA-1601
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add header to allow bypassing the LeaderRedirectFilter.
>
>
> Diffs
> -----
>
> api/src/main/thrift/org/apache/aurora/gen/api.thrift 12400a77db71084e91fc9082132d1e601f8088f0
> examples/vagrant/clusters_direct.json PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java 41b99846bff65c4d10d5d74ca8534768b0ce3fd3
> src/main/python/apache/aurora/admin/admin.py 750b616dc9c4855733ddb2ff89c29d5a85af29af
> src/main/python/apache/aurora/admin/aurora_admin.py 470b2d2339284de9246b35daa0af1c2b832c232d
> src/main/python/apache/aurora/client/api/__init__.py 1b2ce4d44f3650d7136006ed12319cdf37ae353e
> src/main/python/apache/aurora/client/api/scheduler_client.py 86366240a48ebb576f7e3e5406cbc207fcd8df59
> src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 21371d951f8c6e44c40f97793d6acd26d3ca5614
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 4c4caaf76ce9f529c834f33f786036022766044d
> src/test/sh/org/apache/aurora/e2e/test_bypass_leader_redirect_end_to_end.sh PRE-CREATION
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 1171dca4af01a11e684f0b7a63a50250a8da1d22
>
> Diff: https://reviews.apache.org/r/42964/diff/
>
>
> Testing
> -------
>
> ./gradlew build -Pq
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 42964: Add header to allow bypassing the
LeaderRedirectFilter.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42964/#review117516
-----------------------------------------------------------
Ship it!
Master (2f485e8) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 2, 2016, 9:51 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42964/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2016, 9:51 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1601
> https://issues.apache.org/jira/browse/AURORA-1601
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add header to allow bypassing the LeaderRedirectFilter.
>
>
> Diffs
> -----
>
> api/src/main/thrift/org/apache/aurora/gen/api.thrift 12400a77db71084e91fc9082132d1e601f8088f0
> examples/vagrant/clusters_direct.json PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java 41b99846bff65c4d10d5d74ca8534768b0ce3fd3
> src/main/python/apache/aurora/admin/admin.py 750b616dc9c4855733ddb2ff89c29d5a85af29af
> src/main/python/apache/aurora/admin/aurora_admin.py 470b2d2339284de9246b35daa0af1c2b832c232d
> src/main/python/apache/aurora/client/api/__init__.py 1b2ce4d44f3650d7136006ed12319cdf37ae353e
> src/main/python/apache/aurora/client/api/scheduler_client.py 86366240a48ebb576f7e3e5406cbc207fcd8df59
> src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 21371d951f8c6e44c40f97793d6acd26d3ca5614
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 4c4caaf76ce9f529c834f33f786036022766044d
> src/test/sh/org/apache/aurora/e2e/test_bypass_leader_redirect_end_to_end.sh PRE-CREATION
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 1171dca4af01a11e684f0b7a63a50250a8da1d22
>
> Diff: https://reviews.apache.org/r/42964/diff/
>
>
> Testing
> -------
>
> ./gradlew build -Pq
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 42964: Add header to allow bypassing the
LeaderRedirectFilter.
Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42964/
-----------------------------------------------------------
(Updated Feb. 2, 2016, 9:51 p.m.)
Review request for Aurora, Bill Farner and Zameer Manji.
Changes
-------
Simplify end to end test.
Bugs: AURORA-1601
https://issues.apache.org/jira/browse/AURORA-1601
Repository: aurora
Description
-------
Add header to allow bypassing the LeaderRedirectFilter.
Diffs (updated)
-----
api/src/main/thrift/org/apache/aurora/gen/api.thrift 12400a77db71084e91fc9082132d1e601f8088f0
examples/vagrant/clusters_direct.json PRE-CREATION
src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java 41b99846bff65c4d10d5d74ca8534768b0ce3fd3
src/main/python/apache/aurora/admin/admin.py 750b616dc9c4855733ddb2ff89c29d5a85af29af
src/main/python/apache/aurora/admin/aurora_admin.py 470b2d2339284de9246b35daa0af1c2b832c232d
src/main/python/apache/aurora/client/api/__init__.py 1b2ce4d44f3650d7136006ed12319cdf37ae353e
src/main/python/apache/aurora/client/api/scheduler_client.py 86366240a48ebb576f7e3e5406cbc207fcd8df59
src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 21371d951f8c6e44c40f97793d6acd26d3ca5614
src/test/python/apache/aurora/client/api/test_scheduler_client.py 4c4caaf76ce9f529c834f33f786036022766044d
src/test/sh/org/apache/aurora/e2e/test_bypass_leader_redirect_end_to_end.sh PRE-CREATION
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 1171dca4af01a11e684f0b7a63a50250a8da1d22
Diff: https://reviews.apache.org/r/42964/diff/
Testing
-------
./gradlew build -Pq
Thanks,
Joshua Cohen
Re: Review Request 42964: Add header to allow bypassing the
LeaderRedirectFilter.
Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42964/
-----------------------------------------------------------
(Updated Feb. 2, 2016, 8:54 p.m.)
Review request for Aurora, Bill Farner and Zameer Manji.
Changes
-------
Fix admin client option checking.
Bugs: AURORA-1601
https://issues.apache.org/jira/browse/AURORA-1601
Repository: aurora
Description
-------
Add header to allow bypassing the LeaderRedirectFilter.
Diffs (updated)
-----
api/src/main/thrift/org/apache/aurora/gen/api.thrift 12400a77db71084e91fc9082132d1e601f8088f0
examples/vagrant/clusters_direct.json PRE-CREATION
examples/vagrant/upstart/aurora-scheduler-await-registration.conf PRE-CREATION
src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java 41b99846bff65c4d10d5d74ca8534768b0ce3fd3
src/main/python/apache/aurora/admin/admin.py 750b616dc9c4855733ddb2ff89c29d5a85af29af
src/main/python/apache/aurora/admin/aurora_admin.py 470b2d2339284de9246b35daa0af1c2b832c232d
src/main/python/apache/aurora/client/api/__init__.py 1b2ce4d44f3650d7136006ed12319cdf37ae353e
src/main/python/apache/aurora/client/api/scheduler_client.py 86366240a48ebb576f7e3e5406cbc207fcd8df59
src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 21371d951f8c6e44c40f97793d6acd26d3ca5614
src/test/python/apache/aurora/client/api/test_scheduler_client.py 4c4caaf76ce9f529c834f33f786036022766044d
src/test/sh/org/apache/aurora/e2e/test_bypass_leader_redirect_end_to_end.sh PRE-CREATION
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 1171dca4af01a11e684f0b7a63a50250a8da1d22
Diff: https://reviews.apache.org/r/42964/diff/
Testing
-------
./gradlew build -Pq
Thanks,
Joshua Cohen
Re: Review Request 42964: Add header to allow bypassing the
LeaderRedirectFilter.
Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42964/
-----------------------------------------------------------
(Updated Feb. 2, 2016, 8:48 p.m.)
Review request for Aurora, Bill Farner and Zameer Manji.
Changes
-------
- Use a thrift constant for the header name to keep the value in sync across java/python
- Add an end to end test to verify the behavior of the header.
Bugs: AURORA-1601
https://issues.apache.org/jira/browse/AURORA-1601
Repository: aurora
Description
-------
Add header to allow bypassing the LeaderRedirectFilter.
Diffs (updated)
-----
api/src/main/thrift/org/apache/aurora/gen/api.thrift 12400a77db71084e91fc9082132d1e601f8088f0
examples/vagrant/clusters_direct.json PRE-CREATION
examples/vagrant/upstart/aurora-scheduler-await-registration.conf PRE-CREATION
src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java 41b99846bff65c4d10d5d74ca8534768b0ce3fd3
src/main/python/apache/aurora/admin/admin.py 750b616dc9c4855733ddb2ff89c29d5a85af29af
src/main/python/apache/aurora/admin/aurora_admin.py 470b2d2339284de9246b35daa0af1c2b832c232d
src/main/python/apache/aurora/client/api/__init__.py 1b2ce4d44f3650d7136006ed12319cdf37ae353e
src/main/python/apache/aurora/client/api/scheduler_client.py 86366240a48ebb576f7e3e5406cbc207fcd8df59
src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 21371d951f8c6e44c40f97793d6acd26d3ca5614
src/test/python/apache/aurora/client/api/test_scheduler_client.py 4c4caaf76ce9f529c834f33f786036022766044d
src/test/sh/org/apache/aurora/e2e/test_bypass_leader_redirect_end_to_end.sh PRE-CREATION
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 1171dca4af01a11e684f0b7a63a50250a8da1d22
Diff: https://reviews.apache.org/r/42964/diff/
Testing
-------
./gradlew build -Pq
Thanks,
Joshua Cohen
Re: Review Request 42964: Add header to allow bypassing the
LeaderRedirectFilter.
Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42964/
-----------------------------------------------------------
(Updated Feb. 1, 2016, 8:05 p.m.)
Review request for Aurora, Bill Farner and Zameer Manji.
Changes
-------
Add support to aurora_admin to send the header.
Bugs: AURORA-1601
https://issues.apache.org/jira/browse/AURORA-1601
Repository: aurora
Description
-------
Add header to allow bypassing the LeaderRedirectFilter.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java 41b99846bff65c4d10d5d74ca8534768b0ce3fd3
src/main/python/apache/aurora/admin/admin.py 750b616dc9c4855733ddb2ff89c29d5a85af29af
src/main/python/apache/aurora/admin/aurora_admin.py 470b2d2339284de9246b35daa0af1c2b832c232d
src/main/python/apache/aurora/client/api/__init__.py 1b2ce4d44f3650d7136006ed12319cdf37ae353e
src/main/python/apache/aurora/client/api/scheduler_client.py 86366240a48ebb576f7e3e5406cbc207fcd8df59
src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 21371d951f8c6e44c40f97793d6acd26d3ca5614
src/test/python/apache/aurora/client/api/test_scheduler_client.py 4c4caaf76ce9f529c834f33f786036022766044d
Diff: https://reviews.apache.org/r/42964/diff/
Testing
-------
./gradlew build -Pq
Thanks,
Joshua Cohen
Re: Review Request 42964: Add header to allow bypassing the
LeaderRedirectFilter.
Posted by Joshua Cohen <jc...@apache.org>.
> On Jan. 29, 2016, 9:07 p.m., Zameer Manji wrote:
> > I think you also need to add a flag/option to `aurora_admin` to let operators take advantage of this flag.
Done!
- Joshua
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42964/#review117013
-----------------------------------------------------------
On Feb. 1, 2016, 8:05 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42964/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2016, 8:05 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1601
> https://issues.apache.org/jira/browse/AURORA-1601
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add header to allow bypassing the LeaderRedirectFilter.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java 41b99846bff65c4d10d5d74ca8534768b0ce3fd3
> src/main/python/apache/aurora/admin/admin.py 750b616dc9c4855733ddb2ff89c29d5a85af29af
> src/main/python/apache/aurora/admin/aurora_admin.py 470b2d2339284de9246b35daa0af1c2b832c232d
> src/main/python/apache/aurora/client/api/__init__.py 1b2ce4d44f3650d7136006ed12319cdf37ae353e
> src/main/python/apache/aurora/client/api/scheduler_client.py 86366240a48ebb576f7e3e5406cbc207fcd8df59
> src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 21371d951f8c6e44c40f97793d6acd26d3ca5614
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 4c4caaf76ce9f529c834f33f786036022766044d
>
> Diff: https://reviews.apache.org/r/42964/diff/
>
>
> Testing
> -------
>
> ./gradlew build -Pq
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 42964: Add header to allow bypassing the
LeaderRedirectFilter.
Posted by Joshua Cohen <jc...@apache.org>.
> On Jan. 29, 2016, 9:07 p.m., Zameer Manji wrote:
> > src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java, line 45
> > <https://reviews.apache.org/r/42964/diff/2/?file=1225903#file1225903line45>
> >
> > Since this is a custom header perhaps we should prefix it with `X-`?
`X-` prefixes have been deprecated for some time: https://tools.ietf.org/html/rfc6648. I don't know that anyone's actually listening to that RFC, but we can be the change we want to see in the world, right? ;)
- Joshua
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42964/#review117013
-----------------------------------------------------------
On Jan. 29, 2016, 8:54 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42964/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2016, 8:54 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1601
> https://issues.apache.org/jira/browse/AURORA-1601
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add header to allow bypassing the LeaderRedirectFilter.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java 41b99846bff65c4d10d5d74ca8534768b0ce3fd3
> src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 21371d951f8c6e44c40f97793d6acd26d3ca5614
>
> Diff: https://reviews.apache.org/r/42964/diff/
>
>
> Testing
> -------
>
> ./gradlew build -Pq
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 42964: Add header to allow bypassing the
LeaderRedirectFilter.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42964/#review117013
-----------------------------------------------------------
I think you also need to add a flag/option to `aurora_admin` to let operators take advantage of this flag.
src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java (line 45)
<https://reviews.apache.org/r/42964/#comment178076>
Since this is a custom header perhaps we should prefix it with `X-`?
- Zameer Manji
On Jan. 29, 2016, 12:54 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42964/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2016, 12:54 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1601
> https://issues.apache.org/jira/browse/AURORA-1601
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add header to allow bypassing the LeaderRedirectFilter.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java 41b99846bff65c4d10d5d74ca8534768b0ce3fd3
> src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 21371d951f8c6e44c40f97793d6acd26d3ca5614
>
> Diff: https://reviews.apache.org/r/42964/diff/
>
>
> Testing
> -------
>
> ./gradlew build -Pq
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 42964: Add header to allow bypassing the
LeaderRedirectFilter.
Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42964/
-----------------------------------------------------------
(Updated Jan. 29, 2016, 8:54 p.m.)
Review request for Aurora, Bill Farner and Zameer Manji.
Changes
-------
Switch to a header-based, rather than a flag based, approach.
Summary (updated)
-----------------
Add header to allow bypassing the LeaderRedirectFilter.
Bugs: AURORA-1601
https://issues.apache.org/jira/browse/AURORA-1601
Repository: aurora
Description (updated)
-------
Add header to allow bypassing the LeaderRedirectFilter.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java 41b99846bff65c4d10d5d74ca8534768b0ce3fd3
src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 21371d951f8c6e44c40f97793d6acd26d3ca5614
Diff: https://reviews.apache.org/r/42964/diff/
Testing
-------
./gradlew build -Pq
Thanks,
Joshua Cohen