You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Danny Chen (Jira)" <ji...@apache.org> on 2020/06/18 06:44:00 UTC

[jira] [Comment Edited] (CALCITE-4056) Remove Digest from RelNode and RexNode

    [ https://issues.apache.org/jira/browse/CALCITE-4056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17139137#comment-17139137 ] 

Danny Chen edited comment on CALCITE-4056 at 6/18/20, 6:43 AM:
---------------------------------------------------------------

Thanks, revert in [a551d4b|https://github.com/apache/calcite/commit/a551d4bfa3b97c42e74fe4e30ca66ba493719c96] ~

I think we need to let the test data say words. Without impressive promotion, i don't see why we switch to a breaking change that touch every kind of RelNode.


was (Author: danny0405):
Revert in [a551d4b|https://github.com/apache/calcite/commit/a551d4bfa3b97c42e74fe4e30ca66ba493719c96] ~

> Remove Digest from RelNode and RexNode
> --------------------------------------
>
>                 Key: CALCITE-4056
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4056
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: Haisheng Yuan
>            Priority: Major
>             Fix For: 1.24.0
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> The digest is used everywhere (RelNode, RexNode, DataType), causing OOM easily for large queries or with complex expressions. Datatype is cached in global interner and can be reused. Unlike RelNode, RexNode is not stored in MEMO as a GROUP, causing it can't be shared. This makes Calcite can't scale for large queries, e.g. CALCITE-3784.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)