You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "beliefer (via GitHub)" <gi...@apache.org> on 2025/08/27 11:58:05 UTC

[PR] [MINOR] Simplify numaBindingInfo for GlutenConfig [incubator-gluten]

beliefer opened a new pull request, #10557:
URL: https://github.com/apache/incubator-gluten/pull/10557

   ## What changes are proposed in this pull request?
   
   This PR proposes to simplify numaBindingInfo for GlutenConfig
   
   ## How was this patch tested?
   
   GA tests.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [MINOR] Simplify numaBindingInfo for GlutenConfig [incubator-gluten]

Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer closed pull request #10557: [MINOR] Simplify numaBindingInfo for GlutenConfig
URL: https://github.com/apache/incubator-gluten/pull/10557


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [MINOR] Simplify numaBindingInfo for GlutenConfig [incubator-gluten]

Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE commented on PR #10557:
URL: https://github.com/apache/incubator-gluten/pull/10557#issuecomment-3235544952

   @zhouyuan, I'm curious if NUMA binding is still working well. It seems no tests cover this functionality, and no users are enabling it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [MINOR] Simplify numaBindingInfo for GlutenConfig [incubator-gluten]

Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #10557:
URL: https://github.com/apache/incubator-gluten/pull/10557#issuecomment-3235950004

   @FelixYBW Do you means remove the `numaBindingInfo`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [MINOR] Simplify numaBindingInfo for GlutenConfig [incubator-gluten]

Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #10557:
URL: https://github.com/apache/incubator-gluten/pull/10557#issuecomment-3231216053

   ping @zhztheplayer @FelixYBW @jinchengchenghh @zml1206 @zhouyuan 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [MINOR] Simplify numaBindingInfo for GlutenConfig [incubator-gluten]

Posted by "FelixYBW (via GitHub)" <gi...@apache.org>.
FelixYBW commented on PR #10557:
URL: https://github.com/apache/incubator-gluten/pull/10557#issuecomment-3235665402

   We can remove the function. Linux Numa balancing works pretty well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [MINOR] Simplify numaBindingInfo for GlutenConfig [incubator-gluten]

Posted by "zhouyuan (via GitHub)" <gi...@apache.org>.
zhouyuan commented on PR #10557:
URL: https://github.com/apache/incubator-gluten/pull/10557#issuecomment-3236160919

   > @zhouyuan, I'm curious if NUMA binding is still working well. It seems no tests cover this functionality, and no users are enabling it.
   
   The feature is inherited from Gazelle project. At that time we find it works well on physical servers. As far as I know there is no real deployment using this feature in production. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [MINOR] Simplify numaBindingInfo for GlutenConfig [incubator-gluten]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10557:
URL: https://github.com/apache/incubator-gluten/pull/10557#issuecomment-3227900310

   Run Gluten Clickhouse CI on x86


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [MINOR] Simplify numaBindingInfo for GlutenConfig [incubator-gluten]

Posted by "FelixYBW (via GitHub)" <gi...@apache.org>.
FelixYBW commented on PR #10557:
URL: https://github.com/apache/incubator-gluten/pull/10557#issuecomment-3235982174

   > @FelixYBW Do you means remove the `numaBindingInfo`?
   
   Yes. feel free to remove it. It doesn't do better than NUMA_BALANCING. On machines with multiple NUMA, one should enable the NUMA_BALANCING in Linux.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [MINOR] Simplify numaBindingInfo for GlutenConfig [incubator-gluten]

Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #10557:
URL: https://github.com/apache/incubator-gluten/pull/10557#issuecomment-3235984906

   OK. let me remove it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org


Re: [PR] [MINOR] Simplify numaBindingInfo for GlutenConfig [incubator-gluten]

Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #10557:
URL: https://github.com/apache/incubator-gluten/pull/10557#issuecomment-3240767955

   Because https://github.com/apache/incubator-gluten/pull/10579 has been merged. So I close this one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org