You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by jackylk <gi...@git.apache.org> on 2017/12/04 14:48:10 UTC

[GitHub] carbondata pull request #1594: [CARBONDATA-1838] Refactor SortStepRowUtil to...

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1594#discussion_r154667973
  
    --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/load/DataLoadProcessorStepOnSpark.scala ---
    @@ -138,7 +138,7 @@ object DataLoadProcessorStepOnSpark {
     
           override def next(): CarbonRow = {
             val row =
    -          new CarbonRow(SortStepRowUtil.convertRow(rows.next().getData, sortParameters))
    +          new CarbonRow(sortStepRowUtil.convertRow(rows.next().getData))
    --- End diff --
    
    Maybe `SortStepRowUtil` is not a good name anymore, it is some kind of converter


---