You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@madlib.apache.org by orhankislal <gi...@git.apache.org> on 2016/04/06 23:19:15 UTC

[GitHub] incubator-madlib pull request: Random Forest: Fix filtered feature...

GitHub user orhankislal opened a pull request:

    https://github.com/apache/incubator-madlib/pull/37

    Random Forest: Fix filtered feature related bug

    JIRA: MADLIB-928
    
    Random forest filters out a feature if it has the same value for every row. If grouping is enabled this filer is applied per group. However _get_bins_grps function did not consider a case where different groups have different features. The commit fixes this issue as well as a typo in one of the related functions.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/orhankislal/incubator-madlib bugfix/random_forest3

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-madlib/pull/37.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #37
    
----
commit afd54374fef04c1e0b643bcab903b66e5b78f66f
Author: Orhan Kislal <ok...@pivotal.io>
Date:   2016-04-06T21:07:26Z

    Random Forest: Fix filtered feature related bug
    
    JIRA: MADLIB-928
    
    Random forest filters out a feature if it has the same value for every row. If grouping is enabled this filer is applied per group. However _get_bins_grps function did not consider a case where different groups have different features. The commit fixes this issue as well as a typo in one of the related functions.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-madlib pull request: Random Forest: Fix filtered feature...

Posted by orhankislal <gi...@git.apache.org>.
Github user orhankislal closed the pull request at:

    https://github.com/apache/incubator-madlib/pull/37


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---