You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2016/12/13 01:10:06 UTC
Review Request 54687: Moved `IOSwitchboard::requiresServer()`
implementation to cpp.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54687/
-----------------------------------------------------------
Review request for mesos and Kevin Klues.
Repository: mesos
Description
-------
This is consistent with all other methods of this class.
No functional change.
Diffs
-----
src/slave/containerizer/mesos/io/switchboard.hpp 9f4ce99d09d50b681e01b5d28fb5fc79e1ea85fc
src/slave/containerizer/mesos/io/switchboard.cpp f900924dd55c42966deb14c65fca380bebc86e2f
Diff: https://reviews.apache.org/r/54687/diff/
Testing
-------
make -j20 check GTEST_FILTER="*Switchboard*" MESOS_VERBOSE=1
Thanks,
Vinod Kone
Re: Review Request 54687: Moved `IOSwitchboard::requiresServer()`
implementation to cpp.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54687/#review158945
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Klues
On Dec. 13, 2016, 1:10 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54687/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2016, 1:10 a.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is consistent with all other methods of this class.
> No functional change.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/io/switchboard.hpp 9f4ce99d09d50b681e01b5d28fb5fc79e1ea85fc
> src/slave/containerizer/mesos/io/switchboard.cpp f900924dd55c42966deb14c65fca380bebc86e2f
>
> Diff: https://reviews.apache.org/r/54687/diff/
>
>
> Testing
> -------
>
> make -j20 check GTEST_FILTER="*Switchboard*" MESOS_VERBOSE=1
>
>
> Thanks,
>
> Vinod Kone
>
>