You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by si...@apache.org on 2018/02/19 23:44:18 UTC
[bookkeeper] branch master updated: Create a forked JVM for each bc
test
This is an automated email from the ASF dual-hosted git repository.
sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git
The following commit(s) were added to refs/heads/master by this push:
new 2a51958 Create a forked JVM for each bc test
2a51958 is described below
commit 2a519586f616541182bafa0b135d4f6a04be4fba
Author: Ivan Kelly <iv...@apache.org>
AuthorDate: Mon Feb 19 15:44:12 2018 -0800
Create a forked JVM for each bc test
Until now, BC tests have been running in the maven processes because
they do funny stuff with the classloader which didn't seem to work
with later versions of the surefire plugin. However, using a version
of surefire less than or equal to 2.8.1, we can use
useSystemClassLoader to the same effect, and therefore fork a JVM for
each test. This is desirable to isolate the tests from each other.
Author: Ivan Kelly <iv...@apache.org>
Reviewers: Sijie Guo <si...@apache.org>
This closes #1175 from ivankelly/branch-per-bc-test
---
tests/integration-tests-base-groovy/pom.xml | 10 +++++++---
tests/integration-tests-utils/pom.xml | 10 ++++++----
2 files changed, 13 insertions(+), 7 deletions(-)
diff --git a/tests/integration-tests-base-groovy/pom.xml b/tests/integration-tests-base-groovy/pom.xml
index 875361c..9bf71b0 100644
--- a/tests/integration-tests-base-groovy/pom.xml
+++ b/tests/integration-tests-base-groovy/pom.xml
@@ -84,10 +84,14 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
+ <!-- DO NOT CHANGE VERSION
+ Versions newer than 2.8.1 do not respect useSystemClassLoader=false
+ https://issues.apache.org/jira/browse/SUREFIRE-1476 //-->
+ <version>2.8.1</version>
<configuration>
- <!-- forkCount=0 forces groovy tests to run in isolated classloaders
- which is required if want to test BC without test deps interfering //-->
- <forkCount>0</forkCount>
+ <argLine>-Xmx4G -Djava.net.preferIPv4Stack=true</argLine>
+ <forkCount>1</forkCount>
+ <useSystemClassLoader>false</useSystemClassLoader>
<systemPropertyVariables>
<!-- only takes effect in later simpleLogger versions (1.7+) //-->
<org.slf4j.simpleLogger.logFile>System.out</org.slf4j.simpleLogger.logFile>
diff --git a/tests/integration-tests-utils/pom.xml b/tests/integration-tests-utils/pom.xml
index fb6654a..35fb4c8 100644
--- a/tests/integration-tests-utils/pom.xml
+++ b/tests/integration-tests-utils/pom.xml
@@ -99,11 +99,13 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
+ <!-- DO NOT CHANGE VERSION
+ Versions newer than 2.8.1 do not respect useSystemClassLoader=false
+ https://issues.apache.org/jira/browse/SUREFIRE-1476 //-->
+ <version>2.8.1</version>
<configuration>
- <!-- forkCount=0 forces tests to run in isolated classloaders
- which is required if want to test maven classloader without
- test deps interfering //-->
- <forkCount>0</forkCount>
+ <forkCount>1</forkCount>
+ <useSystemClassLoader>false</useSystemClassLoader>
</configuration>
</plugin>
</plugins>
--
To stop receiving notification emails like this one, please contact
sijie@apache.org.