[jira] [Comment Edited] (CASSANDRA-16789) Add TTL support to nodetool snapshots

["Paulo Motta (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-16789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17419187#comment-17419187 ] 

Paulo Motta edited comment on CASSANDRA-16789 at 9/23/21, 1:22 PM:
-------------------------------------------------------------------

Given we needed a way to parse Durations during this work I suggested Abi to reuse the already-implemented {{Duration}} class from CASSANDRA-15234 during our discussons on the #cassandra-gsoc channel but forgot to mention this on this ticket and give proper authorship. We didn't have any intention to claim authorship on this class since that work would be eventually included in the context of CASSANDRA-15234 so its authorship was well-known in my view, but I agree it should have been given proper credit anyway. Sorry about this! Since there's no way to change a commit message after the fact I will set [~e.dimitrova] as reviewer of this ticket, but please let me know if there's a better way to remediate this.

edit: replaced notorious with well-known, since notorious in English has a negative meaning while in portuguese is equivalent to well-known. ;)


was (Author: paulo):
Given we needed a way to parse Durations during this work I suggested Abi to reuse the already-implemented {{Duration}} class from CASSANDRA-15234 during our discussons on the #cassandra-gsoc channel but forgot to mention this on this ticket and give proper authorship. We didn't have any intention to claim authorship on this class since that work would be eventually included in the context of CASSANDRA-15234 so its authorship was notorious in my view, but I agree it should have been given proper credit anyway. Sorry about this! Since there's no way to change a commit message after the fact I will set [~e.dimitrova] as reviewer of this ticket, but please let me know if there's a better way to remediate this.

> Add TTL support to nodetool snapshots
> -------------------------------------
>
>                 Key: CASSANDRA-16789
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16789
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Tool/nodetool
>            Reporter: Paulo Motta
>            Assignee: Abuli Palagashvili
>            Priority: Normal
>             Fix For: 4.1
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> Add new parameter {{--ttl}} to {{nodetool snapshot}} command. This parameter can be specified in human readable duration (ie. 30mins, 1h, 300d) and should not be lower than 1 minute.
> The expiration date should be added to the snapshot manifest in ISO format.
> A periodic thread should efficiently scan snapshots and automatically clear those past expiration date. The periodicity of the scan thread should be 1 minute by default but be overridable via a system property.
> The command {{nodetool listsnapshots}} should display the expiration date when the snapshot contains a TTL.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org