You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by acaciocenteno <gi...@git.apache.org> on 2015/04/06 21:59:20 UTC
[GitHub] trafficserver pull request: Background Fetch Plugin: Cleanup mutex
GitHub user acaciocenteno opened a pull request:
https://github.com/apache/trafficserver/pull/184
Background Fetch Plugin: Cleanup mutex
The ticket TS-1432 describes why mutex destroy should be exposed on the API. I was added on 5.2, but the plugin was not updated. Without this call the plugin leaks memory.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aziontech/trafficserver master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/184.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #184
----
commit 5c57052e8e93226a94d6055d7b7bce4223921b4b
Author: Acácio Centeno <ac...@gmail.com>
Date: 2015-04-06T19:49:32Z
Background Fetch Plugin: Cleanup mutex
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: Background Fetch Plugin: Cleanup mutex
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/184#issuecomment-97145130
Couple of things:
1) Please always file a Jira before making a github pull commit for code changes (not docs). Also include that Jira in the commit message.
2) Please use our indentation style as dictated by the clang-format setup. See mailing list for more details.
3) I still don't see how this can cause any serious memory leaks. If it does, we really have a very very fundamental problem, the only way I can imagine this leaking noticeable memory is either if we somehow duplicate the configuration object accidentally, or if you truly reload your configs every 5s or some such (which would be bad on its own).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: Background Fetch Plugin: Cleanup mutex
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/184
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---