You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2022/03/05 20:22:31 UTC
[GitHub] [thrift] tokcum opened a new pull request #2539: THRIFT-3877: add support for Unix Domain Sockets in lib/rs
tokcum opened a new pull request #2539:
URL: https://github.com/apache/thrift/pull/2539
Client: rs
The Thrift crate does not support Unix Domain Sockets (UDS). After reviewing and expressing my thoughts on THRIFT-3877, I added support for UDS.
This is not a breaking change. Inspired by how actix_web::HttpServer supports UDS, I added an additional fn to listen to UDS. I reorganized some other existing code to be able to reuse it for UDS. I also had to implement the trait TIoChannel for UnixStream. This went to transport::socket.
As UnixStream is only available on Unix, I tagged the code with #[cfg(unix)]. However, I was not able to test the build on Windows. I hope for the CI to detect any build issues on Windows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #2539: THRIFT-5283 add support for Unix Domain Sockets in lib/rs
Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #2539:
URL: https://github.com/apache/thrift/pull/2539#issuecomment-1059851561
You picked the wrong ticket number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] tokcum commented on pull request #2539: THRIFT-3877: add support for Unix Domain Sockets in lib/rs
Posted by GitBox <gi...@apache.org>.
tokcum commented on pull request #2539:
URL: https://github.com/apache/thrift/pull/2539#issuecomment-1059836481
I reviewed the CI results. The build failures are not related to this PR, I think. Meanwhile I also cross compiled lib/rs to Windows with the following cargo targets:
- i686-pc-windows-gnu
- i686-pc-windows-msvc
- x86_64-pc-windows-gnu
- x86_64-pc-windows-msvc
This releaved that I should have also tagged the use statement for Path.
```
warning: unused import: `std::path::Path`
--> src/server/threaded.rs:21:5
|
21 | use std::path::Path;
| ^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] tokcum closed pull request #2539: THRIFT-5283 add support for Unix Domain Sockets in lib/rs
Posted by GitBox <gi...@apache.org>.
tokcum closed pull request #2539:
URL: https://github.com/apache/thrift/pull/2539
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] tokcum commented on pull request #2539: THRIFT-5283 add support for Unix Domain Sockets in lib/rs
Posted by GitBox <gi...@apache.org>.
tokcum commented on pull request #2539:
URL: https://github.com/apache/thrift/pull/2539#issuecomment-1060668180
> You picked the wrong ticket number.
Sorry, not sure how this happened. I'll have to improve this PR anyway as Allen George asked me to cover this with some unit tests as well as rust & cross-harness tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org