[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #19446: [fix][broker] Expect msgs after server initiated CloseProducer

["michaeljmarshall (via GitHub)" <gi...@apache.org>]

michaeljmarshall commented on code in PR #19446:
URL: https://github.com/apache/pulsar/pull/19446#discussion_r1098258376


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java:
##########
@@ -2813,21 +2824,30 @@ public void removedConsumer(Consumer consumer) {
 
     @Override
     public void removedProducer(Producer producer) {
-        safelyRemoveProducer(producer);
+        safelyRemoveProducer(producer, false);
     }
 
-    private void safelyRemoveProducer(Producer producer) {
+    private void safelyRemoveProducer(Producer producer, boolean keepTombstoneForProducer) {

Review Comment:
   Great observation. I am going to refactor it to make it clearer and I will add comments.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org