You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@flagon.apache.org by GitBox <gi...@apache.org> on 2023/01/02 17:10:47 UTC

[GitHub] [incubator-flagon-useralejs] UncleGedd commented on pull request #331: WIP: Revisit composedPath update

UncleGedd commented on PR #331:
URL: https://github.com/apache/incubator-flagon-useralejs/pull/331#issuecomment-1369100265

   Made 2 updates thus far:
   1. Refactored the `buildPath` function how @Jyyjy orignally intended ([reference](https://github.com/apache/incubator-flagon-useralejs/pull/323#issuecomment-1365557602)) including fixing the unit test
   2. Deleted the `defaults to path if available` unit test. Someone check me on this, but I'm not sure this test is relevant anymore


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@flagon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org