You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/22 19:21:12 UTC

[GitHub] [airflow] potiuk opened a new pull request #17775: Improve discoverability of Provider packages' functionality

potiuk opened a new pull request #17775:
URL: https://github.com/apache/airflow/pull/17775


   The documentation of provider packages was rather disconnected
   from the apache-airlfow documentation. It was hard to find the
   ways how the apache airflow's core extensions are implemented by
   the community managed providers - you needed to know what you were
   looking for, and you could not find links to the summary of the
   core-functionality extended by providers when you were looking at
   the functionality (like logging/secret backends/connections/auth)
   
   This PR inroduces much more comprehensive cross-linking between
   the airflow core functionalithy and the community-managed providers
   that are providing extensions to the core functionality.
   
   Depends on #17767 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #17775: Improve discoverability of Provider packages' functionality

Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #17775:
URL: https://github.com/apache/airflow/pull/17775


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #17775: Improve discoverability of Provider packages' functionality

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17775:
URL: https://github.com/apache/airflow/pull/17775#issuecomment-904101694


   The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #17775: Improve discoverability of Provider packages' functionality

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17775:
URL: https://github.com/apache/airflow/pull/17775#issuecomment-903319314


   This PR implements what we have been discussing in the devlist thread: https://lists.apache.org/x/thread.html/rf3e3beba4dac92adcd2e2f11088f992c23baa1aa43518e9efbb625f8@%3Cdev.airflow.apache.org%3E
   
   There are a number of new pages in the "apache-providers" "Core Extensions" chapter:
   
   Providers-packages main doc:
   
   ![image](https://user-images.githubusercontent.com/595491/130367635-2af79e36-d18f-4fea-848c-b887ce91d7ec.png)
     
   "Core Extensions" provider's page:
   
   ![image](https://user-images.githubusercontent.com/595491/130367674-e44f74bb-db6c-4a60-b90c-ab0e650498ce.png)
   
   continued here:
   
   ![image](https://user-images.githubusercontent.com/595491/130367699-52819b15-93f4-4235-9169-d0b05a91df21.png)
   
   Dedicated pages for each functionality - "Writing logs" example:
   
   ![image](https://user-images.githubusercontent.com/595491/130367729-0e3833da-8d4b-44dd-93fe-e7fe06bce190.png)
   
   All those pages are inter-linked form the chapters that describe given functionality in the "apache-airflow" - for example "Writing logs" here:
   
   ![image](https://user-images.githubusercontent.com/595491/130367776-c36409bd-199f-42e2-bde6-d281eb6f8da0.png)
   
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on a change in pull request #17775: Improve discoverability of Provider packages' functionality

Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #17775:
URL: https://github.com/apache/airflow/pull/17775#discussion_r694258279



##########
File path: docs/apache-airflow-providers-elasticsearch/logging/index.rst
##########
@@ -17,7 +17,7 @@
 

Review comment:
       Ah. Found it! Good catch!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on a change in pull request #17775: Improve discoverability of Provider packages' functionality

Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #17775:
URL: https://github.com/apache/airflow/pull/17775#discussion_r694257448



##########
File path: docs/apache-airflow-providers-elasticsearch/logging/index.rst
##########
@@ -17,7 +17,7 @@
 

Review comment:
       How do I do that? Could you show me an example / maybe past PR that did this ?  Do we have it explained somewhere?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on a change in pull request #17775: Improve discoverability of Provider packages' functionality

Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #17775:
URL: https://github.com/apache/airflow/pull/17775#discussion_r693965741



##########
File path: docs/apache-airflow-providers-microsoft-azure/logging/index.rst
##########
@@ -17,7 +17,7 @@
 

Review comment:
       Missing backward compatibility for links. https://github.com/apache/airflow/pull/17775/files#r693965147




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on a change in pull request #17775: Improve discoverability of Provider packages' functionality

Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #17775:
URL: https://github.com/apache/airflow/pull/17775#discussion_r694264711



##########
File path: docs/apache-airflow-providers-elasticsearch/logging/index.rst
##########
@@ -17,7 +17,7 @@
 

Review comment:
       Here is example: 
   https://github.com/apache/airflow/blob/main/docs/apache-airflow-providers-google/redirects.txt
   https://github.com/apache/airflow/blob/main/docs/apache-airflow/redirects.txt




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on a change in pull request #17775: Improve discoverability of Provider packages' functionality

Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #17775:
URL: https://github.com/apache/airflow/pull/17775#discussion_r694269305



##########
File path: docs/apache-airflow-providers-elasticsearch/logging/index.rst
##########
@@ -17,7 +17,7 @@
 

Review comment:
       Yep. Found it. Fixed already in the latest push (I also checked that the redirection works).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on a change in pull request #17775: Improve discoverability of Provider packages' functionality

Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #17775:
URL: https://github.com/apache/airflow/pull/17775#discussion_r693965147



##########
File path: docs/apache-airflow-providers-elasticsearch/logging/index.rst
##########
@@ -17,7 +17,7 @@
 

Review comment:
       Changing the filename may break existing links. We should add redirects. I think we just need to create an `docs/apache-airflow-providers-elasticsearch/redirects.txt` file with the proper mapping.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org