You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@heron.apache.org by GitBox <gi...@apache.org> on 2020/07/10 22:07:42 UTC

[GitHub] [incubator-heron] nicknezis commented on a change in pull request #3561: WIP: Add k8s integration tests to CI

nicknezis commented on a change in pull request #3561:
URL: https://github.com/apache/incubator-heron/pull/3561#discussion_r453095317



##########
File path: heron/config/src/yaml/conf/kubernetes/statemgr.yaml
##########
@@ -19,7 +19,7 @@
 heron.class.state.manager: org.apache.heron.statemgr.zookeeper.curator.CuratorStateManager
 
 # local state manager connection string
-heron.statemgr.connection.string:  <zookeeper_host:zookeeper_port>
+heron.statemgr.connection.string:  127.0.0.1:2181

Review comment:
       Why is this set to 127.0.0.1 instead of a Kubernetes service name like `zookeeper:2181`? 
   
   If it's set like this only for testing reasons, would it be better to keep it with the placeholder and change to 127.0.0.1:2181 in the kubernetes portion of the test script?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org