You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Peter Rozsa (Code Review)" <ge...@cloudera.org> on 2024/09/20 09:31:07 UTC
[Impala-ASF-CR] IMPALA-13220: Docs for Iceberg DROP PARTITION
Peter Rozsa has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21833
Change subject: IMPALA-13220: Docs for Iceberg DROP PARTITION
......................................................................
IMPALA-13220: Docs for Iceberg DROP PARTITION
This patch adds a new section to the Iceberg topic about DROP PARTITION.
Change-Id: I45ea95d94ff9785309911c71b5dcf7c13c05b3c4
---
M docs/topics/impala_iceberg.xml
1 file changed, 24 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/21833/2
--
To view, visit http://gerrit.cloudera.org:8080/21833
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I45ea95d94ff9785309911c71b5dcf7c13c05b3c4
Gerrit-Change-Number: 21833
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
[Impala-ASF-CR] IMPALA-13220: Docs for Iceberg DROP PARTITION
Posted by "Noemi Pap-Takacs (Code Review)" <ge...@cloudera.org>.
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/21833 )
Change subject: IMPALA-13220: Docs for Iceberg DROP PARTITION
......................................................................
Patch Set 2:
(2 comments)
Thanks, Peter!
http://gerrit.cloudera.org:8080/#/c/21833/2/docs/topics/impala_iceberg.xml
File docs/topics/impala_iceberg.xml:
http://gerrit.cloudera.org:8080/#/c/21833/2/docs/topics/impala_iceberg.xml@507
PS2, Line 507: This is a metadata-only operation.
Maybe you can explain shortly what this means.
http://gerrit.cloudera.org:8080/#/c/21833/2/docs/topics/impala_iceberg.xml@508
PS2, Line 508: </p>
: <p>
It would be nice to have a paragraph about tables with partition evolution. What partitions can be dropped in that case and how? Mention if there is a limitation and a workaround.
--
To view, visit http://gerrit.cloudera.org:8080/21833
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I45ea95d94ff9785309911c71b5dcf7c13c05b3c4
Gerrit-Change-Number: 21833
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Oct 2024 07:44:10 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13220: Docs for Iceberg DROP PARTITION
Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/21833 )
Change subject: IMPALA-13220: Docs for Iceberg DROP PARTITION
......................................................................
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/21833/2/docs/topics/impala_iceberg.xml
File docs/topics/impala_iceberg.xml:
http://gerrit.cloudera.org:8080/#/c/21833/2/docs/topics/impala_iceberg.xml@499
PS2, Line 499: ALTER TABLE ice_t DROP PARTITION (i = 3);
> Can we drop ranges, as described in https://impala.apache.org/docs/build/ht
Limitations paragraph added.
http://gerrit.cloudera.org:8080/#/c/21833/2/docs/topics/impala_iceberg.xml@507
PS2, Line 507: This is a metadata-only operation,
> Maybe you can explain shortly what this means.
Done
http://gerrit.cloudera.org:8080/#/c/21833/2/docs/topics/impala_iceberg.xml@508
PS2, Line 508: only a new snapshot is getting created with the remaining partitions.
: </p
> It would be nice to have a paragraph about tables with partition evolution.
It's described in the newly added Limitations paragraph.
--
To view, visit http://gerrit.cloudera.org:8080/21833
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I45ea95d94ff9785309911c71b5dcf7c13c05b3c4
Gerrit-Change-Number: 21833
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Oct 2024 14:54:05 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13220: Docs for Iceberg DROP PARTITION
Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21833 )
Change subject: IMPALA-13220: Docs for Iceberg DROP PARTITION
......................................................................
IMPALA-13220: Docs for Iceberg DROP PARTITION
This patch adds a new section to the Iceberg topic about DROP PARTITION.
Change-Id: I45ea95d94ff9785309911c71b5dcf7c13c05b3c4
Reviewed-on: http://gerrit.cloudera.org:8080/21833
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Noemi Pap-Takacs <np...@cloudera.com>
Reviewed-by: Daniel Becker <da...@cloudera.com>
---
M docs/topics/impala_iceberg.xml
1 file changed, 33 insertions(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Verified
Noemi Pap-Takacs: Looks good to me, but someone else must approve
Daniel Becker: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/21833
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I45ea95d94ff9785309911c71b5dcf7c13c05b3c4
Gerrit-Change-Number: 21833
Gerrit-PatchSet: 4
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
[Impala-ASF-CR] IMPALA-13220: Docs for Iceberg DROP PARTITION
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21833 )
Change subject: IMPALA-13220: Docs for Iceberg DROP PARTITION
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/21833
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I45ea95d94ff9785309911c71b5dcf7c13c05b3c4
Gerrit-Change-Number: 21833
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Oct 2024 15:07:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13220: Docs for Iceberg DROP PARTITION
Posted by "Noemi Pap-Takacs (Code Review)" <ge...@cloudera.org>.
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/21833 )
Change subject: IMPALA-13220: Docs for Iceberg DROP PARTITION
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/21833
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I45ea95d94ff9785309911c71b5dcf7c13c05b3c4
Gerrit-Change-Number: 21833
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Oct 2024 09:02:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13220: Docs for Iceberg DROP PARTITION
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21833 )
Change subject: IMPALA-13220: Docs for Iceberg DROP PARTITION
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21833
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I45ea95d94ff9785309911c71b5dcf7c13c05b3c4
Gerrit-Change-Number: 21833
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Oct 2024 09:23:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13220: Docs for Iceberg DROP PARTITION
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21833 )
Change subject: IMPALA-13220: Docs for Iceberg DROP PARTITION
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21833/2/docs/topics/impala_iceberg.xml
File docs/topics/impala_iceberg.xml:
http://gerrit.cloudera.org:8080/#/c/21833/2/docs/topics/impala_iceberg.xml@499
PS2, Line 499: ALTER TABLE ice_t DROP PARTITION (i = 3);
Can we drop ranges, as described in https://impala.apache.org/docs/build/html/topics/impala_alter_table.html, like this:
alter table historical_data drop partition (year < 1995);
?
In general, are there limitations to dropping partitions of Iceberg tables in comparison to Hive tables?
--
To view, visit http://gerrit.cloudera.org:8080/21833
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I45ea95d94ff9785309911c71b5dcf7c13c05b3c4
Gerrit-Change-Number: 21833
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Oct 2024 10:15:09 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13220: Docs for Iceberg DROP PARTITION
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21833 )
Change subject: IMPALA-13220: Docs for Iceberg DROP PARTITION
......................................................................
Patch Set 3: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/806/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/21833
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I45ea95d94ff9785309911c71b5dcf7c13c05b3c4
Gerrit-Change-Number: 21833
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Oct 2024 15:01:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13220: Docs for Iceberg DROP PARTITION
Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/21833 )
Change subject: IMPALA-13220: Docs for Iceberg DROP PARTITION
......................................................................
IMPALA-13220: Docs for Iceberg DROP PARTITION
This patch adds a new section to the Iceberg topic about DROP PARTITION.
Change-Id: I45ea95d94ff9785309911c71b5dcf7c13c05b3c4
---
M docs/topics/impala_iceberg.xml
1 file changed, 33 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/21833/3
--
To view, visit http://gerrit.cloudera.org:8080/21833
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I45ea95d94ff9785309911c71b5dcf7c13c05b3c4
Gerrit-Change-Number: 21833
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
[Impala-ASF-CR] IMPALA-13220: Docs for Iceberg DROP PARTITION
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21833 )
Change subject: IMPALA-13220: Docs for Iceberg DROP PARTITION
......................................................................
Patch Set 2:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/797/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/21833
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I45ea95d94ff9785309911c71b5dcf7c13c05b3c4
Gerrit-Change-Number: 21833
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 20 Sep 2024 09:31:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13220: Docs for Iceberg DROP PARTITION
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21833 )
Change subject: IMPALA-13220: Docs for Iceberg DROP PARTITION
......................................................................
Patch Set 2: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/797/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/21833
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I45ea95d94ff9785309911c71b5dcf7c13c05b3c4
Gerrit-Change-Number: 21833
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 20 Sep 2024 09:38:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13220: Docs for Iceberg DROP PARTITION
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21833 )
Change subject: IMPALA-13220: Docs for Iceberg DROP PARTITION
......................................................................
Patch Set 3:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/806/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/21833
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I45ea95d94ff9785309911c71b5dcf7c13c05b3c4
Gerrit-Change-Number: 21833
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Oct 2024 14:54:10 +0000
Gerrit-HasComments: No