You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/17 16:41:10 UTC
[GitHub] [incubator-superset] codecov-io commented on issue #9530: [charts]
adds new filters ui
codecov-io commented on issue #9530: [charts] adds new filters ui
URL: https://github.com/apache/incubator-superset/pull/9530#issuecomment-615348115
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=h1) Report
> Merging [#9530](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ecf1abae7820993f854ec35b8729f269a2092b3c&el=desc) will **decrease** coverage by `0.19%`.
> The diff coverage is `93.10%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9530 +/- ##
==========================================
- Coverage 70.42% 70.23% -0.20%
==========================================
Files 571 182 -389
Lines 30018 17674 -12344
Branches 3042 0 -3042
==========================================
- Hits 21140 12413 -8727
+ Misses 8767 5261 -3506
+ Partials 111 0 -111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `70.23% <93.10%> (-0.22%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `98.09% <ø> (ø)` | |
| [superset/charts/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2Rhby5weQ==) | `86.84% <91.66%> (+1.65%)` | :arrow_up: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `81.76% <94.11%> (+1.28%)` | :arrow_up: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `45.83% <0.00%> (-20.84%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `80.00% <0.00%> (-15.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `83.90% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `84.47% <0.00%> (-2.39%)` | :arrow_down: |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `88.77% <0.00%> (-0.35%)` | :arrow_down: |
| ... and [388 more](https://codecov.io/gh/apache/incubator-superset/pull/9530/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=footer). Last update [ecf1aba...f28c863](https://codecov.io/gh/apache/incubator-superset/pull/9530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org