You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by iyovcheva <gi...@git.apache.org> on 2015/08/21 11:49:15 UTC
[GitHub] incubator-brooklyn pull request: Fixed some language mistakes in '...
GitHub user iyovcheva opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/862
Fixed some language mistakes in 'About the code' doc page
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/iyovcheva/incubator-brooklyn small-doc-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/862.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #862
----
commit d68cfcb0d9fa3d4b52434a67c41ddfff6126962f
Author: Ivana Yovcheva <iv...@gmail.com>
Date: 2015-08-20T11:59:54Z
Fixed some language mistakes in 'About the code' doc page
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fixed some language mistakes in '...
Posted by bostko <gi...@git.apache.org>.
Github user bostko commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/862#issuecomment-133361608
I think all fixes are correct.
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fixed some language mistakes in '...
Posted by hzbarcea <gi...@git.apache.org>.
Github user hzbarcea commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/862#discussion_r37714444
--- Diff: docs/guide/dev/code/index.md ---
@@ -39,11 +39,11 @@ This document is intended to help people become familiar with the codebase.
Brooklyn is split into the following projects and sub-projects:
-* **``camp``**: the components for a server which speaks the CAMP REST API and which understands the CAMP YAML plan language
+* **``camp``**: the components for a server which speaks with the CAMP REST API and understands the CAMP YAML plan language
--- End diff --
Or even "speaks the CAMP REST API"
For ``utils`` I would also just say 'lower level utilities' (drop the first 2 words).
My $0.02...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fixed some language mistakes in '...
Posted by mikezaccardo <gi...@git.apache.org>.
Github user mikezaccardo commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/862#discussion_r37689412
--- Diff: docs/guide/dev/code/index.md ---
@@ -39,11 +39,11 @@ This document is intended to help people become familiar with the codebase.
Brooklyn is split into the following projects and sub-projects:
-* **``camp``**: the components for a server which speaks the CAMP REST API and which understands the CAMP YAML plan language
+* **``camp``**: the components for a server which speaks with the CAMP REST API and understands the CAMP YAML plan language
--- End diff --
"... which speaks *to* the CAMP REST API"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fixed some language mistakes in '...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/862
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fixed some language mistakes in '...
Posted by andreaturli <gi...@git.apache.org>.
Github user andreaturli commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/862#discussion_r37622089
--- Diff: docs/guide/dev/code/index.md ---
@@ -39,11 +39,11 @@ This document is intended to help people become familiar with the codebase.
Brooklyn is split into the following projects and sub-projects:
-* **``camp``**: the components for a server which speaks the CAMP REST API and which understands the CAMP YAML plan language
+* **``camp``**: the components for a server which speaks with the CAMP REST API and understands the CAMP YAML plan language
--- End diff --
I think `the` was more appropriate then `with`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fixed some language mistakes in '...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/862#issuecomment-136755362
This fixes some useful things, merging. The minor semantic changes can be done separately.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---