You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Joaquin Casares (Created) (JIRA)" <ji...@apache.org> on 2012/01/04 20:37:39 UTC
[jira] [Created] (CASSANDRA-3697) 'nodetool -h localhost repair'
fails when there is an empty ks
'nodetool -h localhost repair' fails when there is an empty ks
--------------------------------------------------------------
Key: CASSANDRA-3697
URL: https://issues.apache.org/jira/browse/CASSANDRA-3697
Project: Cassandra
Issue Type: Bug
Reporter: Joaquin Casares
Attachments: 3697.diff
If there is an empty KS, the assertion error thrown kills the entire repair, when a keyspace is not specified.
To replicate:
Start a new cluster
nodetool -h localhost repair
Create a new keyspace with no column families
nodetool -h localhost repair
Assertion error is thrown to the prompt
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3697) 'nodetool -h localhost repair'
fails when there is an empty ks
Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179897#comment-13179897 ]
Jonathan Ellis commented on CASSANDRA-3697:
-------------------------------------------
This changes the semantics throw when there *are* CFs existing.
But that aside, I'm not sure why switching from AssertionError to RuntimeException improves things?
> 'nodetool -h localhost repair' fails when there is an empty ks
> --------------------------------------------------------------
>
> Key: CASSANDRA-3697
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3697
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 1.0.6
> Reporter: Joaquin Casares
> Priority: Minor
> Attachments: 3697.diff
>
>
> If there is an empty KS, the assertion error thrown kills the entire repair, when a keyspace is not specified.
> To replicate:
> Start a new cluster
> nodetool -h localhost repair
> Create a new keyspace with no column families
> nodetool -h localhost repair
> Assertion error is thrown to the prompt
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3697) 'nodetool -h localhost repair'
fails when there is an empty ks
Posted by "Joaquin Casares (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joaquin Casares updated CASSANDRA-3697:
---------------------------------------
Priority: Minor (was: Major)
Affects Version/s: 1.0.6
> 'nodetool -h localhost repair' fails when there is an empty ks
> --------------------------------------------------------------
>
> Key: CASSANDRA-3697
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3697
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 1.0.6
> Reporter: Joaquin Casares
> Priority: Minor
> Attachments: 3697.diff
>
>
> If there is an empty KS, the assertion error thrown kills the entire repair, when a keyspace is not specified.
> To replicate:
> Start a new cluster
> nodetool -h localhost repair
> Create a new keyspace with no column families
> nodetool -h localhost repair
> Assertion error is thrown to the prompt
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3697) 'nodetool -h localhost repair'
fails when there is an empty ks
Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179899#comment-13179899 ]
Jonathan Ellis commented on CASSANDRA-3697:
-------------------------------------------
It would make more sense to me to check for this higher up the call stack and skip creating the RepairSession entirely.
> 'nodetool -h localhost repair' fails when there is an empty ks
> --------------------------------------------------------------
>
> Key: CASSANDRA-3697
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3697
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 1.0.6
> Reporter: Joaquin Casares
> Priority: Minor
> Attachments: 3697.diff
>
>
> If there is an empty KS, the assertion error thrown kills the entire repair, when a keyspace is not specified.
> To replicate:
> Start a new cluster
> nodetool -h localhost repair
> Create a new keyspace with no column families
> nodetool -h localhost repair
> Assertion error is thrown to the prompt
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3697) 'nodetool -h localhost repair'
fails when there is an empty ks
Posted by "Joaquin Casares (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179801#comment-13179801 ]
Joaquin Casares commented on CASSANDRA-3697:
--------------------------------------------
Patch 3697.diff built on top of cassandra-1.0 branch.
> 'nodetool -h localhost repair' fails when there is an empty ks
> --------------------------------------------------------------
>
> Key: CASSANDRA-3697
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3697
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 1.0.6
> Reporter: Joaquin Casares
> Priority: Minor
> Attachments: 3697.diff
>
>
> If there is an empty KS, the assertion error thrown kills the entire repair, when a keyspace is not specified.
> To replicate:
> Start a new cluster
> nodetool -h localhost repair
> Create a new keyspace with no column families
> nodetool -h localhost repair
> Assertion error is thrown to the prompt
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (CASSANDRA-3697) 'nodetool -h
localhost repair' fails when there is an empty ks
Posted by "Jonathan Ellis (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179897#comment-13179897 ]
Jonathan Ellis edited comment on CASSANDRA-3697 at 1/4/12 9:27 PM:
-------------------------------------------------------------------
This changes the semantics to throw when there *are* CFs existing.
But that aside, I'm not sure why switching from AssertionError to RuntimeException improves things?
was (Author: jbellis):
This changes the semantics throw when there *are* CFs existing.
But that aside, I'm not sure why switching from AssertionError to RuntimeException improves things?
> 'nodetool -h localhost repair' fails when there is an empty ks
> --------------------------------------------------------------
>
> Key: CASSANDRA-3697
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3697
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 1.0.6
> Reporter: Joaquin Casares
> Priority: Minor
> Attachments: 3697.diff
>
>
> If there is an empty KS, the assertion error thrown kills the entire repair, when a keyspace is not specified.
> To replicate:
> Start a new cluster
> nodetool -h localhost repair
> Create a new keyspace with no column families
> nodetool -h localhost repair
> Assertion error is thrown to the prompt
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3697) 'nodetool -h localhost repair'
fails when there is an empty ks
Posted by "Joaquin Casares (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179908#comment-13179908 ]
Joaquin Casares commented on CASSANDRA-3697:
--------------------------------------------
I figured it work here since Exceptions are caught here:
https://github.com/apache/cassandra/blob/cassandra-1.0/src/java/org/apache/cassandra/service/StorageService.java#L1794
and reported after the loop. Figured we should allow all repairs that can happen to happen.
Sorry for that slip up: if (cfnames.length == 0) != if (cfnames.length > 0)
> 'nodetool -h localhost repair' fails when there is an empty ks
> --------------------------------------------------------------
>
> Key: CASSANDRA-3697
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3697
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 1.0.6
> Reporter: Joaquin Casares
> Priority: Minor
> Attachments: 3697.diff
>
>
> If there is an empty KS, the assertion error thrown kills the entire repair, when a keyspace is not specified.
> To replicate:
> Start a new cluster
> nodetool -h localhost repair
> Create a new keyspace with no column families
> nodetool -h localhost repair
> Assertion error is thrown to the prompt
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3697) 'nodetool -h localhost repair'
fails when there is an empty ks
Posted by "Joaquin Casares (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joaquin Casares updated CASSANDRA-3697:
---------------------------------------
Attachment: 3697.diff
> 'nodetool -h localhost repair' fails when there is an empty ks
> --------------------------------------------------------------
>
> Key: CASSANDRA-3697
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3697
> Project: Cassandra
> Issue Type: Bug
> Reporter: Joaquin Casares
> Attachments: 3697.diff
>
>
> If there is an empty KS, the assertion error thrown kills the entire repair, when a keyspace is not specified.
> To replicate:
> Start a new cluster
> nodetool -h localhost repair
> Create a new keyspace with no column families
> nodetool -h localhost repair
> Assertion error is thrown to the prompt
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira