[jira] [Commented] (CB-11979) add deprecation notice for using subdirectory syntax when fetching plugins

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-11979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15755750#comment-15755750 ] 

ASF GitHub Bot commented on CB-11979:
-------------------------------------

Github user yyfearth commented on the issue:

    https://github.com/apache/cordova-lib/pull/504
  
    This fix has issue now since 
    ```
    options.subdir = options.subdir || '.';
    ...
    if (result[2]) options.subdir = result[2]; // not work if it is empty
    ...
    if(options.subdir) { // it become always true, since subdir will be "."
    ```



> add deprecation notice for using subdirectory syntax when fetching plugins
> --------------------------------------------------------------------------
>
>                 Key: CB-11979
>                 URL: https://issues.apache.org/jira/browse/CB-11979
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>    Affects Versions: 6.3.1
>            Reporter: Steve Gill
>            Assignee: sterling gerritz
>              Labels: cordova-7.0.0
>             Fix For: cordova-cli@6.4.0
>
>
> We plan to remove subdirectory syntax in cordova@7 since `--fetch` can't support it. 
> Need to add a deprecation to the next cordova@6.x release to start warning folks it is going away.
> You can see the subdirectory syntax at http://cordova.apache.org/docs/en/latest/reference/cordova-cli/index.html#plugin-spec.
> I think it is plugin specific, but need to double check it is not supported for fetching platforms too. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org