Is the mutex used in AsyncAppender::close() wrong?

[Frank Sun <fs...@yahoo.com>]

In following code,

synchronized sync(mutex);
aai->removeAllAppenders();

mutex is for append and dispatch threads to access rotate buffer.

And the mutex to protect adding and removing appenders from asyncappender is
aai->getMutex()

I removed above two lines and simple call removeAllAppenders(), which will call

synchronized sync(aai->getMutex());
aai->removeAllAppenders();

then resolve one dead lock problem. 

Is my approch correct?

Arnold, please declare the member functions virtual if possible, such as in
loggingevent class. why do you declare synchronize as not exportable? 

Thanks,

Frank