[GitHub] [incubator-doris] caiconghui commented on a change in pull request #7487: [optimize](show) Support show statement info when execute show proc '/current_queries' statement

[GitBox <gi...@apache.org>]

caiconghui commented on a change in pull request #7487:
URL: https://github.com/apache/incubator-doris/pull/7487#discussion_r775227738



##########
File path: fe/fe-core/src/main/java/org/apache/doris/analysis/ShowProcStmt.java
##########
@@ -46,14 +46,9 @@ public ProcNodeInterface getNode() {
     @Override
     public void analyze(Analyzer analyzer) throws AnalysisException {
         if (!Catalog.getCurrentCatalog().getAuth().checkGlobalPriv(ConnectContext.get(), PrivPredicate.ADMIN)) {
-            ErrorReport.reportAnalysisException(ErrorCode.ERR_SPECIFIC_ACCESS_DENIED_ERROR,
-                                                "ADMIN");
+            ErrorReport.reportAnalysisException(ErrorCode.ERR_SPECIFIC_ACCESS_DENIED_ERROR, "ADMIN");
         }
-
         node = ProcService.getInstance().open(path);
-        if (node == null) {
-            ErrorReport.reportAnalysisException(ErrorCode.ERR_WRONG_PROC_PATH, path);
-        }
     }
 
     @Override

Review comment:
       @jackwener hi, I think both ways of coding can be ok. There is no clear specification when to use ‘+’ and when to use StringBuilder explicitly.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org