You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "byronellis (via GitHub)" <gi...@apache.org> on 2023/08/09 15:02:55 UTC
[GitHub] [beam] byronellis opened a new pull request, #27930: Python groupby error messaging improvements
byronellis opened a new pull request, #27930:
URL: https://github.com/apache/beam/pull/27930
Improves the incorrect/misleading error message reported in #27929
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Python groupby error messaging improvements [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #27930: Python groupby error messaging improvements
URL: https://github.com/apache/beam/pull/27930
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #27930: Python groupby error messaging improvements
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #27930:
URL: https://github.com/apache/beam/pull/27930#discussion_r1288764130
##########
sdks/python/apache_beam/runners/common.py:
##########
@@ -1906,15 +1906,14 @@ def validate_transform(transform_id):
raise ValueError(
"Bad coder for output of %s: %s" % (transform_id, output_coder))
output_values_coder = pipeline_proto.components.coders[
- output_coder.component_coder_ids[1]]
- if (input_coder.component_coder_ids[0] !=
- output_coder.component_coder_ids[0] or
- output_values_coder.spec.urn != common_urns.coders.ITERABLE.urn or
- output_values_coder.component_coder_ids[0] !=
- input_coder.component_coder_ids[1]):
- raise ValueError(
- "Incompatible input coder %s and output coder %s for transform %s" %
- (transform_id, input_coder, output_coder))
+ output_coder.component_coder_ids[1]]
+ if (input_coder.component_coder_ids[0] != output_coder.component_coder_ids[0]):
+ raise ValueError("Input coder key does not match output coder key for transform %s" %
Review Comment:
Can we include the coder keys in this error (and similarly include the bad pieces in the other errors)
##########
sdks/python/apache_beam/runners/common.py:
##########
@@ -1906,15 +1906,14 @@ def validate_transform(transform_id):
raise ValueError(
"Bad coder for output of %s: %s" % (transform_id, output_coder))
output_values_coder = pipeline_proto.components.coders[
- output_coder.component_coder_ids[1]]
- if (input_coder.component_coder_ids[0] !=
- output_coder.component_coder_ids[0] or
- output_values_coder.spec.urn != common_urns.coders.ITERABLE.urn or
- output_values_coder.component_coder_ids[0] !=
- input_coder.component_coder_ids[1]):
- raise ValueError(
- "Incompatible input coder %s and output coder %s for transform %s" %
- (transform_id, input_coder, output_coder))
+ output_coder.component_coder_ids[1]]
+ if (input_coder.component_coder_ids[0] != output_coder.component_coder_ids[0]):
+ raise ValueError("Input coder key does not match output coder key for transform %s" %
+ (transform_id))
+ if(output_values_coder.spec.urn != common_urns.coder.ITERABLE.urn):
Review Comment:
```suggestion
if(output_values_coder.spec.urn != common_urns.coders.ITERABLE.urn):
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #27930: Python groupby error messaging improvements
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27930:
URL: https://github.com/apache/beam/pull/27930#issuecomment-1671722645
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Python groupby error messaging improvements [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27930:
URL: https://github.com/apache/beam/pull/27930#issuecomment-1766361578
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Python groupby error messaging improvements [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27930:
URL: https://github.com/apache/beam/pull/27930#issuecomment-1752940013
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org