[GitHub] [rocketmq] liony edited a comment on issue #1482: fix communicationMode

[GitBox <gi...@apache.org>]

liony edited a comment on issue #1482: fix communicationMode
URL: https://github.com/apache/rocketmq/issues/1482#issuecomment-535302845
 
 
   @duhenglucky :
   maybe I drop into a pit intellectually: 
       I want to express that we could not consider whether is sync or not, if user has set retryTimesWhenSendFaied variable a value, then we should help one to retry before the timeout. 
   based on that thinking about above, so I give the suggection for repairing maybe like this:
   ```
   boolean retryFlag = this.defaultMQProducer.getRetryTimesWhenSendFailed() > 0;
   int timesTotal = retryFlag ? this.defaultMQProducer.getRetryTimesWhenSendFailed() : 1;
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services