[GitHub] [hbase] wchevreuil commented on a change in pull request #2923: HBASE-25548 Optionally allow snapshots to preserve cluster's max file…

[GitBox <gi...@apache.org>]

wchevreuil commented on a change in pull request #2923:
URL: https://github.com/apache/hbase/pull/2923#discussion_r578365240



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/TakeSnapshotHandler.java
##########
@@ -139,12 +140,17 @@ public TakeSnapshotHandler(SnapshotDescription snapshot, final MasterServices ma
   }
 
   private TableDescriptor loadTableDescriptor()
-      throws FileNotFoundException, IOException {
+      throws IOException {
     TableDescriptor htd =
       this.master.getTableDescriptors().get(snapshotTable);
     if (htd == null) {
       throw new IOException("TableDescriptor missing for " + snapshotTable);
     }
+    if(htd.getMaxFileSize()==-1 &&

Review comment:
       Thanks for the reviews and suggestions @anoopsjohn @petersomogyi . I'm falling behind a bit, but will be putting it in an upcoming commit on the following days.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org