[GitHub] [incubator-superset] suddjian commented on a change in pull request #8556: [WIP] [SIP] Proposal for Improvement on CSV Upload

[GitBox <gi...@apache.org>]

suddjian commented on a change in pull request #8556: [WIP] [SIP] Proposal for Improvement on CSV Upload
URL: https://github.com/apache/incubator-superset/pull/8556#discussion_r346025893
 
 

 ##########
 File path: superset/assets/src/CsvToDatabase/App.jsx
 ##########
 @@ -0,0 +1,51 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import thunk from 'redux-thunk';
+import { createStore, applyMiddleware, compose } from 'redux';
+import { Provider } from 'react-redux';
+import { hot } from 'react-hot-loader';
+import { initEnhancer } from '../reduxUtils';
+import logger from '../middleware/loggerMiddleware';
+import setupApp from '../setup/setupApp';
+import rootReducer from './reducers/index';
+import CsvToDatabase from './CsvToDatabase';
+
+setupApp();
+
+const appContainer = document.getElementById('app');
+const bootstrapData = JSON.parse(appContainer.getAttribute('data-bootstrap'));
+const databases = bootstrapData.databases;
+
+const store = createStore(
+  rootReducer,
+  {},
+  compose(
+    applyMiddleware(thunk, logger),
+    initEnhancer(false),
+  ),
+);
+
+const App = () => (
 
 Review comment:
   This might require a broader discussion outside the scope of this PR, but have we considered building this page into one of Superset's existing react apps? We are going to see more pages converted to react in the future, and it would be nice to not have to wrangle lots of separate apps.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org