You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by kirklund <gi...@git.apache.org> on 2017/08/21 22:41:11 UTC
[GitHub] geode pull request #729: GEODE-3461: increase test timeouts
GitHub user kirklund opened a pull request:
https://github.com/apache/geode/pull/729
GEODE-3461: increase test timeouts
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kirklund/geode GEODE-3461-increase-timeouts
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/729.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #729
----
commit 88e7ca09e342276efa0af596cbd7de3bc96a4c1a
Author: Kirk Lund <kl...@apache.org>
Date: 2017-08-21T22:38:45Z
GEODE-3461: increase test timeouts
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #729: GEODE-3461: increase test timeouts
Posted by jaredjstewart <gi...@git.apache.org>.
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/729#discussion_r134348604
--- Diff: geode-core/src/test/java/org/apache/geode/internal/process/AbstractProcessStreamReaderIntegrationTest.java ---
@@ -149,7 +147,7 @@ protected void givenStartedProcessWithStreamListeners(final Class<?> mainClass)
}
protected ConditionFactory await() {
- return Awaitility.await().atMost(WAIT_FOR_READER_IS_RUNNING_TIMEOUT_MILLIS, MILLISECONDS);
+ return Awaitility.await().atMost(2, MINUTES);
--- End diff --
Did you mean to specify READER_JOIN_TIMEOUT_MILLIS instead of 2? Otherwise it looks like that variable is only read by tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #729: GEODE-3461: increase test timeouts
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/geode/pull/729
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode issue #729: GEODE-3461: increase test timeouts
Posted by kirklund <gi...@git.apache.org>.
Github user kirklund commented on the issue:
https://github.com/apache/geode/pull/729
This PR should also fix GEODE-3505.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #729: GEODE-3461: increase test timeouts
Posted by kirklund <gi...@git.apache.org>.
Github user kirklund commented on a diff in the pull request:
https://github.com/apache/geode/pull/729#discussion_r134352194
--- Diff: geode-core/src/test/java/org/apache/geode/internal/process/AbstractProcessStreamReaderIntegrationTest.java ---
@@ -149,7 +147,7 @@ protected void givenStartedProcessWithStreamListeners(final Class<?> mainClass)
}
protected ConditionFactory await() {
- return Awaitility.await().atMost(WAIT_FOR_READER_IS_RUNNING_TIMEOUT_MILLIS, MILLISECONDS);
+ return Awaitility.await().atMost(2, MINUTES);
--- End diff --
WAIT_FOR_READER_IS_RUNNING_TIMEOUT_MILLIS was poorly named and is now deleted --
replaced by (2, MINUTES) hardcoded into the await() method that various tests use.
READER_JOIN_TIMEOUT_MILLIS still exists and is used only by the two tests that perform Thread.join style calls on the Readers.
Both timeouts are now 2 minutes which should be more than enough even if the test hits a GC pause.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---