You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2023/01/03 18:26:59 UTC

[GitHub] [arrow-nanoarrow] paleolimbot opened a new pull request, #86: Revisit some poorly chosen names

paleolimbot opened a new pull request, #86:
URL: https://github.com/apache/arrow-nanoarrow/pull/86

   This PR does a few renames for names that have bugged me over the course of writing stuff based on nanoarrow. Now seems like a good time to get those out of the way. They were:
   
   - `schema_view.data_type` to `schema_view.type`: the term `data_type` never comes up in any other context in nanoarrow and `type` fits much better with the `NANOARROW_TYPE_**` set of enums.
   - `string_view.n_bytes` -> `string_view.size_bytes`: everywhere else we refer to sizes as `size_units` (i.e., `size_bytes`, `element_size_bits`, `size_elements`, etc.). The string and buffer views were the odd ones out.
   
   While I was in the `SchemaView` I noticed that the `timezone` member was an `ArrowStringView` and not a `const char*`. When sourced from a format string, the timezone is always null-terminated and it's ever so slightly easier to work with that way (e.g., it's safe to use `strcmp()` instead of mucking around with `strncmp()`).
   
   Since this was a wide-ranging change, I also ran `clang-format` on everything.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-nanoarrow] paleolimbot merged pull request #86: Revisit some poorly chosen names

Posted by GitBox <gi...@apache.org>.
paleolimbot merged PR #86:
URL: https://github.com/apache/arrow-nanoarrow/pull/86


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org