You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/21 17:41:38 UTC
[GitHub] [airflow] MichailParaskevopoulos opened a new pull request #21718: Fix BigQueryCreateEmptyDatasetOperator to use the provided project_id
MichailParaskevopoulos opened a new pull request #21718:
URL: https://github.com/apache/airflow/pull/21718
This PR fixes the issue that occurs in the `BigQueryCreateEmptyDatasetOperator` when the BigQuery client can't infer the Google Cloud project_id from the environment or the credentials, in which case the user provides the project_id as an argument to the operator.
It is fixed by adding the project_id as an argument to the BigQuery client when it's called from `airflow.providers.google.cloud.hooks.bigquery.BigQueryHook.create_empty_dataset`. This is on par with how the rest of the BigQuery hook's methods call the client, but for some reason it was originally omitted from the `create_empty_dataset` method.
<!--
closes: #21600
related: #21600
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on a change in pull request #21718: Fix BigQueryCreateEmptyDatasetOperator to use the provided project_id
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on a change in pull request #21718:
URL: https://github.com/apache/airflow/pull/21718#discussion_r811641589
##########
File path: airflow/providers/google/cloud/hooks/bigquery.py
##########
@@ -470,7 +470,7 @@ def create_empty_dataset(
dataset: Dataset = Dataset.from_api_repr(dataset_reference)
self.log.info('Creating dataset: %s in project: %s ', dataset.dataset_id, dataset.project)
- self.get_client(location=location).create_dataset(dataset=dataset, exists_ok=exists_ok)
+ self.get_client(project_id=project_id, location=location).create_dataset(dataset=dataset, exists_ok=exists_ok)
Review comment:
We should add a test to ensure that this is not removed in another PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #21718: Fix BigQueryCreateEmptyDatasetOperator to use the provided project_id
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #21718:
URL: https://github.com/apache/airflow/pull/21718#discussion_r815364508
##########
File path: airflow/providers/google/cloud/hooks/bigquery.py
##########
@@ -470,7 +470,7 @@ def create_empty_dataset(
dataset: Dataset = Dataset.from_api_repr(dataset_reference)
self.log.info('Creating dataset: %s in project: %s ', dataset.dataset_id, dataset.project)
- self.get_client(location=location).create_dataset(dataset=dataset, exists_ok=exists_ok)
+ self.get_client(project_id=project_id, location=location).create_dataset(dataset=dataset, exists_ok=exists_ok)
Review comment:
Agree!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #21718: Fix BigQueryCreateEmptyDatasetOperator to use the provided project_id
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #21718:
URL: https://github.com/apache/airflow/pull/21718#issuecomment-1047108781
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #21718: Fix BigQueryCreateEmptyDatasetOperator to use the provided project_id
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #21718:
URL: https://github.com/apache/airflow/pull/21718#issuecomment-1047476355
Please fix the static check failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org