You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "hareshkh (via GitHub)" <gi...@apache.org> on 2025/08/11 17:28:30 UTC
[PR] Pass the input schema to stats_projection for ProjectionExpr [datafusion]
hareshkh opened a new pull request, #17123:
URL: https://github.com/apache/datafusion/pull/17123
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
- Closes #17122
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
`bounds_check()` require input schema, while `schema` contains the output schema
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Pass the input schema to stats_projection for ProjectionExpr [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #17123:
URL: https://github.com/apache/datafusion/pull/17123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Pass the input schema to stats_projection for ProjectionExpr [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #17123:
URL: https://github.com/apache/datafusion/pull/17123#issuecomment-3176566281
Thank you for this fix @hareshkh 🙏
can you please add a test so we don't accidentally break this again in the future?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Pass the input schema to stats_projection for ProjectionExpr [datafusion]
Posted by "hareshkh (via GitHub)" <gi...@apache.org>.
hareshkh commented on PR #17123:
URL: https://github.com/apache/datafusion/pull/17123#issuecomment-3178517788
@alamb - Added a test, checked that it fails if the wrong schema is supplied. Can you please take a pass again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Pass the input schema to stats_projection for ProjectionExpr [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #17123:
URL: https://github.com/apache/datafusion/pull/17123#discussion_r2270601725
##########
datafusion/physical-plan/src/projection.rs:
##########
@@ -1230,4 +1232,83 @@ mod tests {
assert_eq!(result, expected);
}
+
+
+ #[test]
+ fn test_projection_statistics_uses_input_schema() {
+ let input_schema = Schema::new(vec![
+ Field::new("a", DataType::Int32, false),
+ Field::new("b", DataType::Int32, false),
+ Field::new("c", DataType::Int32, false),
+ Field::new("d", DataType::Int32, false),
+ Field::new("e", DataType::Int32, false),
+ Field::new("f", DataType::Int32, false),
+ ]);
+
+ let input_statistics = Statistics {
+ num_rows: Precision::Exact(10),
+ column_statistics: vec![
+ ColumnStatistics {
+ min_value: Precision::Exact(ScalarValue::Int32(Some(1))),
+ max_value: Precision::Exact(ScalarValue::Int32(Some(100))),
+ ..Default::default()
+ },
+ ColumnStatistics {
+ min_value: Precision::Exact(ScalarValue::Int32(Some(5))),
+ max_value: Precision::Exact(ScalarValue::Int32(Some(50))),
+ ..Default::default()
+ },
+ ColumnStatistics {
+ min_value: Precision::Exact(ScalarValue::Int32(Some(10))),
+ max_value: Precision::Exact(ScalarValue::Int32(Some(40))),
+ ..Default::default()
+ },
+ ColumnStatistics {
+ min_value: Precision::Exact(ScalarValue::Int32(Some(20))),
+ max_value: Precision::Exact(ScalarValue::Int32(Some(30))),
+ ..Default::default()
+ },
+ ColumnStatistics {
+ min_value: Precision::Exact(ScalarValue::Int32(Some(21))),
+ max_value: Precision::Exact(ScalarValue::Int32(Some(29))),
+ ..Default::default()
+ },
+ ColumnStatistics {
+ min_value: Precision::Exact(ScalarValue::Int32(Some(24))),
+ max_value: Precision::Exact(ScalarValue::Int32(Some(26))),
+ ..Default::default()
+ },
+ ],
+ ..Default::default()
+ };
+
+ let input = Arc::new(StatisticsExec::new(input_statistics, input_schema));
+
+ // Create projection expressions that reference columns from the input schema and the length
+ // of output schema columns < input schema columns and hence if we use the last few columns
+ // from the input schema in the expressions here, bounds_check would fail on them if output
+ // schema is supplied to the partitions_statistics method.
+ let exprs: Vec<(Arc<dyn PhysicalExpr>, String)> = vec![
+ (
+ Arc::new(Column::new("c", 2)) as Arc<dyn PhysicalExpr>,
+ "c_renamed".to_string(),
+ ),
+ (
+ Arc::new(BinaryExpr::new(
+ Arc::new(Column::new("e", 4)),
+ Operator::Plus,
+ Arc::new(Column::new("f", 5)),
+ )) as Arc<dyn PhysicalExpr>,
+ "e_plus_f".to_string(),
+ ),
+ ];
+
+ let projection = ProjectionExec::try_new(exprs, input).unwrap();
+
+ let stats = projection.partition_statistics(None).unwrap();
+
+ assert_eq!(stats.num_rows, Precision::Exact(10));
+ assert_eq!(stats.column_statistics.len(), 2, "Expected 2 columns in projection statistics");
+ assert_eq!(stats.total_byte_size.is_exact().unwrap_or(false), true);
Review Comment:
I verified this test covers the change by running the test without the code change and it fails like this
```
assertion `left == right` failed
left: false
right: true
Left: false
Right: true
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Pass the input schema to stats_projection for ProjectionExpr [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #17123:
URL: https://github.com/apache/datafusion/pull/17123#issuecomment-3183776007
> @alamb : Yes, once this PR merges, I can create a PR to the `branch-49`
Merged! Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Pass the input schema to stats_projection for ProjectionExpr [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #17123:
URL: https://github.com/apache/datafusion/pull/17123#issuecomment-3180278655
> @alamb - Added a test, checked that it fails if the wrong schema is supplied. Can you please take a pass again?
>
> Also, when this fix merges, is it possible to cherry-pick it on top of 48.0.1 - to release maybe a 48.0.2?
We can consider doing a 48.0.2 release -
If you want to do so can you please file a new ticket to discuss the possibility here
- https://github.com/apache/datafusion/issues/16486
It seems like this might be something we want to include in the upcoming `49.0.1` release at least
- #17036
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Pass the input schema to stats_projection for ProjectionExpr [datafusion]
Posted by "hareshkh (via GitHub)" <gi...@apache.org>.
hareshkh commented on PR #17123:
URL: https://github.com/apache/datafusion/pull/17123#issuecomment-3181171024
@alamb : Yes, once this PR merges, I can create a PR to the `branch-49`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Pass the input schema to stats_projection for ProjectionExpr [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #17123:
URL: https://github.com/apache/datafusion/pull/17123#issuecomment-3184443208
Made a backport PR:
- https://github.com/apache/datafusion/pull/17174
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org