You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by "weih-kahoot (via GitHub)" <gi...@apache.org> on 2023/04/27 15:47:46 UTC
[GitHub] [groovy] weih-kahoot opened a new pull request, #1885: fix for NPE
weih-kahoot opened a new pull request, #1885:
URL: https://github.com/apache/groovy/pull/1885
java.lang.NullPointerException
at org.codehaus.groovy.util.ListHashMap.get(ListHashMap.java:120)
at org.codehaus.groovy.ast.NodeMetaDataHandler.getNodeMetaData(NodeMetaDataHandler.java:44)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] asfgit closed pull request #1885: fix for NPE
Posted by "asfgit (via GitHub)" <gi...@apache.org>.
asfgit closed pull request #1885: fix for NPE
URL: https://github.com/apache/groovy/pull/1885
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] eric-milles commented on pull request #1885: fix for NPE
Posted by "eric-milles (via GitHub)" <gi...@apache.org>.
eric-milles commented on PR #1885:
URL: https://github.com/apache/groovy/pull/1885#issuecomment-1549918940
Is the request just to cherry-pick a commint from `master`? If so, can you create a JIRA ticket with a quick description so there is tracking for the next Groovy 4 release? Then I can handle the git ops.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] weih-kahoot commented on pull request #1885: fix for NPE
Posted by "weih-kahoot (via GitHub)" <gi...@apache.org>.
weih-kahoot commented on PR #1885:
URL: https://github.com/apache/groovy/pull/1885#issuecomment-1551724193
@eric-milles sure, I've created ticket https://issues.apache.org/jira/browse/GROOVY-11063
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] weih-kahoot commented on pull request #1885: fix for NPE
Posted by "weih-kahoot (via GitHub)" <gi...@apache.org>.
weih-kahoot commented on PR #1885:
URL: https://github.com/apache/groovy/pull/1885#issuecomment-1525936313
I've seen this NPE occurred for quite a few times, and it's weird the fix it's backported to 4.0.x release branch.
Kindly let me know if the PR can be accepted, :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] paulk-asert commented on pull request #1885: fix for NPE
Posted by "paulk-asert (via GitHub)" <gi...@apache.org>.
paulk-asert commented on PR #1885:
URL: https://github.com/apache/groovy/pull/1885#issuecomment-1550427924
After the proposed change, the code will still be prone to a NPE if called with a null 'key'.
What about using the following as the replacement for the condition in question:
{code}
Objects.equals(key, listKeys[i])
{code}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org