You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/09/05 02:57:21 UTC

[GitHub] codecov-io edited a comment on issue #490: WIP: Fixes build & run related bugs from builder refactor

codecov-io edited a comment on issue #490: WIP: Fixes build & run related bugs from builder refactor
URL: https://github.com/apache/cordova-android/pull/490#issuecomment-418583568
 
 
   # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/490?src=pr&el=h1) Report
   > Merging [#490](https://codecov.io/gh/apache/cordova-android/pull/490?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/7ab0cf123d1955ed2b41c6cf9ffbde17d6effbdd?src=pr&el=desc) will **increase** coverage by `1.73%`.
   > The diff coverage is `78.04%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-android/pull/490/graphs/tree.svg?width=650&token=q14nMf6C5a&height=150&src=pr)](https://codecov.io/gh/apache/cordova-android/pull/490?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #490      +/-   ##
   ==========================================
   + Coverage    59.9%   61.64%   +1.73%     
   ==========================================
     Files          16       16              
     Lines        1973     1945      -28     
     Branches      380      363      -17     
   ==========================================
   + Hits         1182     1199      +17     
   + Misses        791      746      -45
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/490?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...n/templates/cordova/lib/builders/ProjectBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/490/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9Qcm9qZWN0QnVpbGRlci5qcw==) | `45.12% <100%> (+5.33%)` | :arrow_up: |
   | [bin/templates/cordova/lib/run.js](https://codecov.io/gh/apache/cordova-android/pull/490/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9ydW4uanM=) | `100% <100%> (ø)` | :arrow_up: |
   | [bin/templates/cordova/lib/pluginHandlers.js](https://codecov.io/gh/apache/cordova-android/pull/490/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wbHVnaW5IYW5kbGVycy5qcw==) | `85.71% <100%> (-1%)` | :arrow_down: |
   | [bin/templates/cordova/lib/builders/builders.js](https://codecov.io/gh/apache/cordova-android/pull/490/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9idWlsZGVycy5qcw==) | `100% <100%> (ø)` | :arrow_up: |
   | [bin/templates/cordova/lib/emulator.js](https://codecov.io/gh/apache/cordova-android/pull/490/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9lbXVsYXRvci5qcw==) | `89.92% <100%> (+0.3%)` | :arrow_up: |
   | [bin/templates/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-android/pull/490/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZC5qcw==) | `28.46% <20%> (+15.41%)` | :arrow_up: |
   | [bin/templates/cordova/Api.js](https://codecov.io/gh/apache/cordova-android/pull/490/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL0FwaS5qcw==) | `43.61% <42.85%> (+2.03%)` | :arrow_up: |
   | [bin/lib/create.js](https://codecov.io/gh/apache/cordova-android/pull/490/diff?src=pr&el=tree#diff-YmluL2xpYi9jcmVhdGUuanM=) | `54.69% <66.66%> (ø)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/490?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/490?src=pr&el=footer). Last update [7ab0cf1...4d06957](https://codecov.io/gh/apache/cordova-android/pull/490?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org