You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org> on 2026/06/29 18:16:33 UTC

[Impala-ASF-CR] POC/slop: decrease mem overhead of IcebergContentFileStore

Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24523


Change subject: POC/slop: decrease mem overhead of IcebergContentFileStore
......................................................................

POC/slop: decrease mem overhead of IcebergContentFileStore

Tested with Iceberg table with ~1M files, 25K partititons.
mem need on coordinntor decreased around 10%:
389MB->350MB

Main changes with estimated saved bytes:
- IcebergContentFileStore:
  - removed EncodedFileDescriptor and store desc +
    metadata as a single array (~48 byte)

Change-Id: Ic44ffa6011b0c7eaeac23a64bd763266a3cfdb30
Assisted-by: Claude Sonnet 4.6
---
M fe/src/main/java/org/apache/impala/catalog/FileDescriptor.java
M fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java
M fe/src/main/java/org/apache/impala/catalog/IcebergFileDescriptor.java
3 files changed, 56 insertions(+), 45 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/24523/3
-- 
To view, visit http://gerrit.cloudera.org:8080/24523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic44ffa6011b0c7eaeac23a64bd763266a3cfdb30
Gerrit-Change-Number: 24523
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>

[Impala-ASF-CR] POC/slop: decrease mem overhead of IcebergContentFileStore

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24523 )

Change subject: POC/slop: decrease mem overhead of IcebergContentFileStore
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13673/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/24523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic44ffa6011b0c7eaeac23a64bd763266a3cfdb30
Gerrit-Change-Number: 24523
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Jun 2026 18:23:10 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] xPOC/slop: decrease mem overhead of IcebergContentFileStore

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24523 )

Change subject: xPOC/slop: decrease mem overhead of IcebergContentFileStore
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/23054/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/24523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic44ffa6011b0c7eaeac23a64bd763266a3cfdb30
Gerrit-Change-Number: 24523
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 30 Jun 2026 10:27:35 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] POC/slop: decrease mem overhead of IcebergContentFileStore

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24523 )

Change subject: POC/slop: decrease mem overhead of IcebergContentFileStore
......................................................................


Patch Set 3: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/13673/


-- 
To view, visit http://gerrit.cloudera.org:8080/24523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic44ffa6011b0c7eaeac23a64bd763266a3cfdb30
Gerrit-Change-Number: 24523
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Jun 2026 22:48:35 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] POC/slop: decrease mem overhead of IcebergContentFileStore

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24523 )

Change subject: POC/slop: decrease mem overhead of IcebergContentFileStore
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/23052/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/24523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic44ffa6011b0c7eaeac23a64bd763266a3cfdb30
Gerrit-Change-Number: 24523
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Jun 2026 18:39:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] xPOC/slop: decrease mem overhead of IcebergContentFileStore

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24523

to look at the new patch set (#4).

Change subject: xPOC/slop: decrease mem overhead of IcebergContentFileStore
......................................................................

xPOC/slop: decrease mem overhead of IcebergContentFileStore

Tested with Iceberg table with ~1M files, 25K partititons.
mem need on coordinntor decreased around 10%:
389MB->350MB

Main changes with estimated saved bytes:
- IcebergContentFileStore:
  - removed EncodedFileDescriptor and store desc +
    metadata as a single array (~48 byte)

Change-Id: Ic44ffa6011b0c7eaeac23a64bd763266a3cfdb30
Assisted-by: Claude Sonnet 4.6
---
M fe/src/main/java/org/apache/impala/catalog/FileDescriptor.java
M fe/src/main/java/org/apache/impala/catalog/IcebergContentFileStore.java
M fe/src/main/java/org/apache/impala/catalog/IcebergFileDescriptor.java
3 files changed, 64 insertions(+), 49 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/24523/4
-- 
To view, visit http://gerrit.cloudera.org:8080/24523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic44ffa6011b0c7eaeac23a64bd763266a3cfdb30
Gerrit-Change-Number: 24523
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>