You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by kg...@apache.org on 2022/02/23 14:07:03 UTC
[superset] branch master updated: feat(native-filters): Don't scroll main window when scrolling filter bar (#18876)
This is an automated email from the ASF dual-hosted git repository.
kgabryje pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new e5c7478 feat(native-filters): Don't scroll main window when scrolling filter bar (#18876)
e5c7478 is described below
commit e5c74780268c78355e21bc0f7af0069a59bed41e
Author: Kamil Gabryjelski <ka...@gmail.com>
AuthorDate: Wed Feb 23 15:04:27 2022 +0100
feat(native-filters): Don't scroll main window when scrolling filter bar (#18876)
---
.../src/dashboard/components/nativeFilters/FilterBar/index.tsx | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx
index e035ee0..3ae3650 100644
--- a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx
+++ b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx
@@ -327,7 +327,10 @@ const FilterBar: React.FC<FiltersBarProps> = ({
filterValues,
);
const isInitialized = useInitialization();
- const tabPaneStyle = useMemo(() => ({ overflow: 'auto', height }), [height]);
+ const tabPaneStyle = useMemo(
+ () => ({ overflow: 'auto', height, overscrollBehavior: 'contain' }),
+ [height],
+ );
const numberOfFilters = filterValues.filter(
filterValue => filterValue.type === NativeFilterType.NATIVE_FILTER,