You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Bryan Keller (JIRA)" <ji...@apache.org> on 2011/03/11 19:33:59 UTC
[jira] Created: (CAMEL-3781) Add option to disable expiration on
JMS component
Add option to disable expiration on JMS component
-------------------------------------------------
Key: CAMEL-3781
URL: https://issues.apache.org/jira/browse/CAMEL-3781
Project: Camel
Issue Type: New Feature
Components: camel-jms
Affects Versions: 2.6.0
Environment: Java 1.6.0_24, Mac OS X 10.6.6
Reporter: Bryan Keller
Priority: Minor
It would be nice to add an option to the JMS component to disable the use of message expirations for InOut exchanges. If a client and server have clocks that are out-of-sync, using message expiration can cause problems. More details can be found here:
http://camel.465427.n5.nabble.com/InOut-exchanges-require-synchronized-clocks-td3411881.html
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CAMEL-3781) Add option to disable expiration on
JMS component
Posted by "Heath Kesler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-3781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Heath Kesler updated CAMEL-3781:
--------------------------------
Attachment: patch-3781.diff
I might have forgot to last time, re attaching with grant ;-)
> Add option to disable expiration on JMS component
> -------------------------------------------------
>
> Key: CAMEL-3781
> URL: https://issues.apache.org/jira/browse/CAMEL-3781
> Project: Camel
> Issue Type: New Feature
> Components: camel-jms
> Affects Versions: 2.6.0
> Environment: Java 1.6.0_24, Mac OS X 10.6.6
> Reporter: Bryan Keller
> Assignee: Hadrian Zbarcea
> Priority: Minor
> Fix For: 2.8.0
>
> Attachments: patch-3781.diff, patch-3781.diff
>
>
> It would be nice to add an option to the JMS component to disable the use of message expirations for InOut exchanges. If a client and server have clocks that are out-of-sync, using message expiration can cause problems. More details can be found here:
> http://camel.465427.n5.nabble.com/InOut-exchanges-require-synchronized-clocks-td3411881.html
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-3781) Add option to disable expiration on
JMS component
Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-3781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13015704#comment-13015704 ]
Hadrian Zbarcea commented on CAMEL-3781:
----------------------------------------
Heath, what about using the requestTimeout instead of introducing another option?
requestTimeout=0 would have the same effect.
{code}
- if (answer instanceof JmsTemplate && requestTimeout > 0) {
+ if (answer instanceof JmsTemplate && requestTimeout >= 0) {
JmsTemplate jmsTemplate = (JmsTemplate) answer;
jmsTemplate.setExplicitQosEnabled(true);
- if (timeToLive < 0) {
+ if (timeToLive < 0 && requestTimeout > 0) {
// If TTL not specified, then default to
jmsTemplate.setTimeToLive(requestTimeout);
}
{code}
> Add option to disable expiration on JMS component
> -------------------------------------------------
>
> Key: CAMEL-3781
> URL: https://issues.apache.org/jira/browse/CAMEL-3781
> Project: Camel
> Issue Type: New Feature
> Components: camel-jms
> Affects Versions: 2.6.0
> Environment: Java 1.6.0_24, Mac OS X 10.6.6
> Reporter: Bryan Keller
> Priority: Minor
> Fix For: 2.8.0
>
> Attachments: patch-3781.diff
>
>
> It would be nice to add an option to the JMS component to disable the use of message expirations for InOut exchanges. If a client and server have clocks that are out-of-sync, using message expiration can cause problems. More details can be found here:
> http://camel.465427.n5.nabble.com/InOut-exchanges-require-synchronized-clocks-td3411881.html
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-3781) Add option to disable expiration on
JMS component
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-3781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040783#comment-13040783 ]
Claus Ibsen commented on CAMEL-3781:
------------------------------------
The option is going to be named {{disableTimeToLive}} as it indicate TTL is being disabled. I have improved the patch to also be applicable for InOnly messaging.
> Add option to disable expiration on JMS component
> -------------------------------------------------
>
> Key: CAMEL-3781
> URL: https://issues.apache.org/jira/browse/CAMEL-3781
> Project: Camel
> Issue Type: New Feature
> Components: camel-jms
> Affects Versions: 2.6.0
> Environment: Java 1.6.0_24, Mac OS X 10.6.6
> Reporter: Bryan Keller
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 2.8.0
>
> Attachments: patch-3781.diff, patch-3781.diff
>
>
> It would be nice to add an option to the JMS component to disable the use of message expirations for InOut exchanges. If a client and server have clocks that are out-of-sync, using message expiration can cause problems. More details can be found here:
> http://camel.465427.n5.nabble.com/InOut-exchanges-require-synchronized-clocks-td3411881.html
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CAMEL-3781) Add option to disable expiration on
JMS component
Posted by "Heath Kesler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-3781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Heath Kesler updated CAMEL-3781:
--------------------------------
Attachment: patch-3781.diff
attaching with ASF
> Add option to disable expiration on JMS component
> -------------------------------------------------
>
> Key: CAMEL-3781
> URL: https://issues.apache.org/jira/browse/CAMEL-3781
> Project: Camel
> Issue Type: New Feature
> Components: camel-jms
> Affects Versions: 2.6.0
> Environment: Java 1.6.0_24, Mac OS X 10.6.6
> Reporter: Bryan Keller
> Priority: Minor
> Fix For: 2.8.0
>
> Attachments: patch-3781.diff
>
>
> It would be nice to add an option to the JMS component to disable the use of message expirations for InOut exchanges. If a client and server have clocks that are out-of-sync, using message expiration can cause problems. More details can be found here:
> http://camel.465427.n5.nabble.com/InOut-exchanges-require-synchronized-clocks-td3411881.html
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CAMEL-3781) Add option to disable expiration on
JMS component
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-3781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen resolved CAMEL-3781.
--------------------------------
Resolution: Fixed
Updated documentation as well.
Keith thanks for the patch. I polished it a bit and renamed the option etc.
> Add option to disable expiration on JMS component
> -------------------------------------------------
>
> Key: CAMEL-3781
> URL: https://issues.apache.org/jira/browse/CAMEL-3781
> Project: Camel
> Issue Type: New Feature
> Components: camel-jms
> Affects Versions: 2.6.0
> Environment: Java 1.6.0_24, Mac OS X 10.6.6
> Reporter: Bryan Keller
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 2.8.0
>
> Attachments: patch-3781.diff, patch-3781.diff
>
>
> It would be nice to add an option to the JMS component to disable the use of message expirations for InOut exchanges. If a client and server have clocks that are out-of-sync, using message expiration can cause problems. More details can be found here:
> http://camel.465427.n5.nabble.com/InOut-exchanges-require-synchronized-clocks-td3411881.html
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-3781) Add option to disable expiration on
JMS component
Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-3781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13015738#comment-13015738 ]
Hadrian Zbarcea commented on CAMEL-3781:
----------------------------------------
Heath, I am not disagreeing with you. I was just pointing out that there is another 2 line change that has exactly the same same effect.
>From your example, if the requestTimeout=2000 and disableExpiration=true, then the value of requestTimeout is ignored, so one might as well set it to 0, it won't do any good to "want a timeout of some value". In other words a requestTimeout=0 would have the same semantics as disableExpiration=true, i.e. TTL not be set (unless I am missing something).
Do you agree with the assessment above? Introducing new options complicates urls, documentation, etc. and I prefer avoiding that when possible. Other than that the patch is good, thanks for the patch by the way. I would only recommend implementing it by using the value '0' of the requestTimeout (unused now) instead of introducing a new option.
> Add option to disable expiration on JMS component
> -------------------------------------------------
>
> Key: CAMEL-3781
> URL: https://issues.apache.org/jira/browse/CAMEL-3781
> Project: Camel
> Issue Type: New Feature
> Components: camel-jms
> Affects Versions: 2.6.0
> Environment: Java 1.6.0_24, Mac OS X 10.6.6
> Reporter: Bryan Keller
> Priority: Minor
> Fix For: 2.8.0
>
> Attachments: patch-3781.diff
>
>
> It would be nice to add an option to the JMS component to disable the use of message expirations for InOut exchanges. If a client and server have clocks that are out-of-sync, using message expiration can cause problems. More details can be found here:
> http://camel.465427.n5.nabble.com/InOut-exchanges-require-synchronized-clocks-td3411881.html
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (CAMEL-3781) Add option to disable expiration on
JMS component
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-3781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen reassigned CAMEL-3781:
----------------------------------
Assignee: Claus Ibsen (was: Hadrian Zbarcea)
> Add option to disable expiration on JMS component
> -------------------------------------------------
>
> Key: CAMEL-3781
> URL: https://issues.apache.org/jira/browse/CAMEL-3781
> Project: Camel
> Issue Type: New Feature
> Components: camel-jms
> Affects Versions: 2.6.0
> Environment: Java 1.6.0_24, Mac OS X 10.6.6
> Reporter: Bryan Keller
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 2.8.0
>
> Attachments: patch-3781.diff, patch-3781.diff
>
>
> It would be nice to add an option to the JMS component to disable the use of message expirations for InOut exchanges. If a client and server have clocks that are out-of-sync, using message expiration can cause problems. More details can be found here:
> http://camel.465427.n5.nabble.com/InOut-exchanges-require-synchronized-clocks-td3411881.html
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-3781) Add option to disable expiration on
JMS component
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-3781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040793#comment-13040793 ]
Claus Ibsen commented on CAMEL-3781:
------------------------------------
btw we are a bit reluctant to add new options to JMS as it already have a lot. But this problem about not synced clocks between systems when doing JMS is often seen. And not all message brokers etc. offer a plugin to cater for that etc. So its a good idea to have this {{disableTimeToLive}} option in Camel to remedy this.
> Add option to disable expiration on JMS component
> -------------------------------------------------
>
> Key: CAMEL-3781
> URL: https://issues.apache.org/jira/browse/CAMEL-3781
> Project: Camel
> Issue Type: New Feature
> Components: camel-jms
> Affects Versions: 2.6.0
> Environment: Java 1.6.0_24, Mac OS X 10.6.6
> Reporter: Bryan Keller
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 2.8.0
>
> Attachments: patch-3781.diff, patch-3781.diff
>
>
> It would be nice to add an option to the JMS component to disable the use of message expirations for InOut exchanges. If a client and server have clocks that are out-of-sync, using message expiration can cause problems. More details can be found here:
> http://camel.465427.n5.nabble.com/InOut-exchanges-require-synchronized-clocks-td3411881.html
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-3781) Add option to disable expiration on
JMS component
Posted by "Heath Kesler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-3781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13016052#comment-13016052 ]
Heath Kesler commented on CAMEL-3781:
-------------------------------------
Hadrian,
Thanks for the feedback. If there is something I can do to improve it let me know.
> Add option to disable expiration on JMS component
> -------------------------------------------------
>
> Key: CAMEL-3781
> URL: https://issues.apache.org/jira/browse/CAMEL-3781
> Project: Camel
> Issue Type: New Feature
> Components: camel-jms
> Affects Versions: 2.6.0
> Environment: Java 1.6.0_24, Mac OS X 10.6.6
> Reporter: Bryan Keller
> Assignee: Hadrian Zbarcea
> Priority: Minor
> Fix For: 2.8.0
>
> Attachments: patch-3781.diff
>
>
> It would be nice to add an option to the JMS component to disable the use of message expirations for InOut exchanges. If a client and server have clocks that are out-of-sync, using message expiration can cause problems. More details can be found here:
> http://camel.465427.n5.nabble.com/InOut-exchanges-require-synchronized-clocks-td3411881.html
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CAMEL-3781) Add option to disable expiration on
JMS component
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-3781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen updated CAMEL-3781:
-------------------------------
Fix Version/s: 2.8.0
> Add option to disable expiration on JMS component
> -------------------------------------------------
>
> Key: CAMEL-3781
> URL: https://issues.apache.org/jira/browse/CAMEL-3781
> Project: Camel
> Issue Type: New Feature
> Components: camel-jms
> Affects Versions: 2.6.0
> Environment: Java 1.6.0_24, Mac OS X 10.6.6
> Reporter: Bryan Keller
> Priority: Minor
> Fix For: 2.8.0
>
>
> It would be nice to add an option to the JMS component to disable the use of message expirations for InOut exchanges. If a client and server have clocks that are out-of-sync, using message expiration can cause problems. More details can be found here:
> http://camel.465427.n5.nabble.com/InOut-exchanges-require-synchronized-clocks-td3411881.html
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-3781) Add option to disable expiration on
JMS component
Posted by "Heath Kesler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-3781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13015923#comment-13015923 ]
Heath Kesler commented on CAMEL-3781:
-------------------------------------
@Hadrian - Does Bryan's response make sense? I do agree with you, that new options complicate URIs, documentation, etc. and I would prefer to avoid that when possible also. I do not see a way of implementing Bryan's suggested improvement without one, but I am open to suggestions. I did make the default function the way Claus suggested in the link, so current implementations would not see a change.
@Bryan - did you look at the patch? Does it solve your request the way you have defined it? Checkout the test, that should layout the functionality pretty well and give you an idea of what was implemented.
> Add option to disable expiration on JMS component
> -------------------------------------------------
>
> Key: CAMEL-3781
> URL: https://issues.apache.org/jira/browse/CAMEL-3781
> Project: Camel
> Issue Type: New Feature
> Components: camel-jms
> Affects Versions: 2.6.0
> Environment: Java 1.6.0_24, Mac OS X 10.6.6
> Reporter: Bryan Keller
> Priority: Minor
> Fix For: 2.8.0
>
> Attachments: patch-3781.diff
>
>
> It would be nice to add an option to the JMS component to disable the use of message expirations for InOut exchanges. If a client and server have clocks that are out-of-sync, using message expiration can cause problems. More details can be found here:
> http://camel.465427.n5.nabble.com/InOut-exchanges-require-synchronized-clocks-td3411881.html
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-3781) Add option to disable expiration on
JMS component
Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-3781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13016045#comment-13016045 ]
Hadrian Zbarcea commented on CAMEL-3781:
----------------------------------------
@Heath: yes, @Bryan's response does make sense. The patch is also good (said that already). I'll take another look today at the use of requestTimeout and apply the patch.
> Add option to disable expiration on JMS component
> -------------------------------------------------
>
> Key: CAMEL-3781
> URL: https://issues.apache.org/jira/browse/CAMEL-3781
> Project: Camel
> Issue Type: New Feature
> Components: camel-jms
> Affects Versions: 2.6.0
> Environment: Java 1.6.0_24, Mac OS X 10.6.6
> Reporter: Bryan Keller
> Assignee: Hadrian Zbarcea
> Priority: Minor
> Fix For: 2.8.0
>
> Attachments: patch-3781.diff
>
>
> It would be nice to add an option to the JMS component to disable the use of message expirations for InOut exchanges. If a client and server have clocks that are out-of-sync, using message expiration can cause problems. More details can be found here:
> http://camel.465427.n5.nabble.com/InOut-exchanges-require-synchronized-clocks-td3411881.html
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CAMEL-3781) Add option to disable expiration on
JMS component
Posted by "Heath Kesler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-3781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Heath Kesler updated CAMEL-3781:
--------------------------------
Attachment: (was: patch-3781.diff)
> Add option to disable expiration on JMS component
> -------------------------------------------------
>
> Key: CAMEL-3781
> URL: https://issues.apache.org/jira/browse/CAMEL-3781
> Project: Camel
> Issue Type: New Feature
> Components: camel-jms
> Affects Versions: 2.6.0
> Environment: Java 1.6.0_24, Mac OS X 10.6.6
> Reporter: Bryan Keller
> Priority: Minor
> Fix For: 2.8.0
>
> Attachments: patch-3781.diff
>
>
> It would be nice to add an option to the JMS component to disable the use of message expirations for InOut exchanges. If a client and server have clocks that are out-of-sync, using message expiration can cause problems. More details can be found here:
> http://camel.465427.n5.nabble.com/InOut-exchanges-require-synchronized-clocks-td3411881.html
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-3781) Add option to disable expiration on
JMS component
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-3781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13024656#comment-13024656 ]
Claus Ibsen commented on CAMEL-3781:
------------------------------------
The patch must be attached with granted license to Apache. So can you re-attach the patch and make sure to [x] in the grant license to Apache checkbox.
> Add option to disable expiration on JMS component
> -------------------------------------------------
>
> Key: CAMEL-3781
> URL: https://issues.apache.org/jira/browse/CAMEL-3781
> Project: Camel
> Issue Type: New Feature
> Components: camel-jms
> Affects Versions: 2.6.0
> Environment: Java 1.6.0_24, Mac OS X 10.6.6
> Reporter: Bryan Keller
> Assignee: Hadrian Zbarcea
> Priority: Minor
> Fix For: 2.8.0
>
> Attachments: patch-3781.diff
>
>
> It would be nice to add an option to the JMS component to disable the use of message expirations for InOut exchanges. If a client and server have clocks that are out-of-sync, using message expiration can cause problems. More details can be found here:
> http://camel.465427.n5.nabble.com/InOut-exchanges-require-synchronized-clocks-td3411881.html
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (CAMEL-3781) Add option to disable expiration on
JMS component
Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-3781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hadrian Zbarcea reassigned CAMEL-3781:
--------------------------------------
Assignee: Hadrian Zbarcea
> Add option to disable expiration on JMS component
> -------------------------------------------------
>
> Key: CAMEL-3781
> URL: https://issues.apache.org/jira/browse/CAMEL-3781
> Project: Camel
> Issue Type: New Feature
> Components: camel-jms
> Affects Versions: 2.6.0
> Environment: Java 1.6.0_24, Mac OS X 10.6.6
> Reporter: Bryan Keller
> Assignee: Hadrian Zbarcea
> Priority: Minor
> Fix For: 2.8.0
>
> Attachments: patch-3781.diff
>
>
> It would be nice to add an option to the JMS component to disable the use of message expirations for InOut exchanges. If a client and server have clocks that are out-of-sync, using message expiration can cause problems. More details can be found here:
> http://camel.465427.n5.nabble.com/InOut-exchanges-require-synchronized-clocks-td3411881.html
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-3781) Add option to disable expiration on
JMS component
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-3781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027618#comment-13027618 ]
Claus Ibsen commented on CAMEL-3781:
------------------------------------
Bryan thanks. I have send Heath and email about this.
> Add option to disable expiration on JMS component
> -------------------------------------------------
>
> Key: CAMEL-3781
> URL: https://issues.apache.org/jira/browse/CAMEL-3781
> Project: Camel
> Issue Type: New Feature
> Components: camel-jms
> Affects Versions: 2.6.0
> Environment: Java 1.6.0_24, Mac OS X 10.6.6
> Reporter: Bryan Keller
> Assignee: Hadrian Zbarcea
> Priority: Minor
> Fix For: 2.8.0
>
> Attachments: patch-3781.diff
>
>
> It would be nice to add an option to the JMS component to disable the use of message expirations for InOut exchanges. If a client and server have clocks that are out-of-sync, using message expiration can cause problems. More details can be found here:
> http://camel.465427.n5.nabble.com/InOut-exchanges-require-synchronized-clocks-td3411881.html
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-3781) Add option to disable expiration on
JMS component
Posted by "Bryan Keller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-3781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027416#comment-13027416 ]
Bryan Keller commented on CAMEL-3781:
-------------------------------------
That was Heath's patch I believe.
> Add option to disable expiration on JMS component
> -------------------------------------------------
>
> Key: CAMEL-3781
> URL: https://issues.apache.org/jira/browse/CAMEL-3781
> Project: Camel
> Issue Type: New Feature
> Components: camel-jms
> Affects Versions: 2.6.0
> Environment: Java 1.6.0_24, Mac OS X 10.6.6
> Reporter: Bryan Keller
> Assignee: Hadrian Zbarcea
> Priority: Minor
> Fix For: 2.8.0
>
> Attachments: patch-3781.diff
>
>
> It would be nice to add an option to the JMS component to disable the use of message expirations for InOut exchanges. If a client and server have clocks that are out-of-sync, using message expiration can cause problems. More details can be found here:
> http://camel.465427.n5.nabble.com/InOut-exchanges-require-synchronized-clocks-td3411881.html
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-3781) Add option to disable expiration on
JMS component
Posted by "Heath Kesler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-3781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13015709#comment-13015709 ]
Heath Kesler commented on CAMEL-3781:
-------------------------------------
Hadrian,
Thanks for looking at it and for your suggestions. The only issue I would see with that is if a user wants a timeout of some value... lets say 2 secs, but still wants the to disable expiration anyway. That was what the forum thread appeared to request. If that is not the case then I have no problem changing it.
> Add option to disable expiration on JMS component
> -------------------------------------------------
>
> Key: CAMEL-3781
> URL: https://issues.apache.org/jira/browse/CAMEL-3781
> Project: Camel
> Issue Type: New Feature
> Components: camel-jms
> Affects Versions: 2.6.0
> Environment: Java 1.6.0_24, Mac OS X 10.6.6
> Reporter: Bryan Keller
> Priority: Minor
> Fix For: 2.8.0
>
> Attachments: patch-3781.diff
>
>
> It would be nice to add an option to the JMS component to disable the use of message expirations for InOut exchanges. If a client and server have clocks that are out-of-sync, using message expiration can cause problems. More details can be found here:
> http://camel.465427.n5.nabble.com/InOut-exchanges-require-synchronized-clocks-td3411881.html
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CAMEL-3781) Add option to disable expiration on
JMS component
Posted by "Heath Kesler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-3781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Heath Kesler updated CAMEL-3781:
--------------------------------
Attachment: patch-3781.diff
added a new option for disableExpiration per the suggestion in the link. Added new test to prove out the code. Any suggestions are welcome on ways to improve it.
> Add option to disable expiration on JMS component
> -------------------------------------------------
>
> Key: CAMEL-3781
> URL: https://issues.apache.org/jira/browse/CAMEL-3781
> Project: Camel
> Issue Type: New Feature
> Components: camel-jms
> Affects Versions: 2.6.0
> Environment: Java 1.6.0_24, Mac OS X 10.6.6
> Reporter: Bryan Keller
> Priority: Minor
> Fix For: 2.8.0
>
> Attachments: patch-3781.diff
>
>
> It would be nice to add an option to the JMS component to disable the use of message expirations for InOut exchanges. If a client and server have clocks that are out-of-sync, using message expiration can cause problems. More details can be found here:
> http://camel.465427.n5.nabble.com/InOut-exchanges-require-synchronized-clocks-td3411881.html
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-3781) Add option to disable expiration on
JMS component
Posted by "Bryan Keller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-3781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13015760#comment-13015760 ]
Bryan Keller commented on CAMEL-3781:
-------------------------------------
Message expiration is something handled by the message broker (not Camel). A message that has expired will not be delivered by the broker. This feature requires clocks on the server and client be synchronized to work properly.
Request timeout is used by Camel to define how long a client should wait for a response from an InOut request before throwing an exception. It is implemented on the client only and thus does not require clocks be synchronized.
I still wanted the request timeout (I don't wait forever for a response on the client), but I wanted to turn off using message expiration because I could not guarantee the client and server clocks were in sync.
> Add option to disable expiration on JMS component
> -------------------------------------------------
>
> Key: CAMEL-3781
> URL: https://issues.apache.org/jira/browse/CAMEL-3781
> Project: Camel
> Issue Type: New Feature
> Components: camel-jms
> Affects Versions: 2.6.0
> Environment: Java 1.6.0_24, Mac OS X 10.6.6
> Reporter: Bryan Keller
> Priority: Minor
> Fix For: 2.8.0
>
> Attachments: patch-3781.diff
>
>
> It would be nice to add an option to the JMS component to disable the use of message expirations for InOut exchanges. If a client and server have clocks that are out-of-sync, using message expiration can cause problems. More details can be found here:
> http://camel.465427.n5.nabble.com/InOut-exchanges-require-synchronized-clocks-td3411881.html
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-3781) Add option to disable expiration on
JMS component
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-3781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027325#comment-13027325 ]
Claus Ibsen commented on CAMEL-3781:
------------------------------------
Bryan do you mind re-attaching the patch and granting license to Apache? Otherwise can cannot accept your patch.
> Add option to disable expiration on JMS component
> -------------------------------------------------
>
> Key: CAMEL-3781
> URL: https://issues.apache.org/jira/browse/CAMEL-3781
> Project: Camel
> Issue Type: New Feature
> Components: camel-jms
> Affects Versions: 2.6.0
> Environment: Java 1.6.0_24, Mac OS X 10.6.6
> Reporter: Bryan Keller
> Assignee: Hadrian Zbarcea
> Priority: Minor
> Fix For: 2.8.0
>
> Attachments: patch-3781.diff
>
>
> It would be nice to add an option to the JMS component to disable the use of message expirations for InOut exchanges. If a client and server have clocks that are out-of-sync, using message expiration can cause problems. More details can be found here:
> http://camel.465427.n5.nabble.com/InOut-exchanges-require-synchronized-clocks-td3411881.html
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-3781) Add option to disable expiration on
JMS component
Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-3781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13016046#comment-13016046 ]
Hadrian Zbarcea commented on CAMEL-3781:
----------------------------------------
@Heath: yes, @Bryan's response does make sense. The patch is also good (said that already). I'll take another look today at the use of requestTimeout and apply the patch.
> Add option to disable expiration on JMS component
> -------------------------------------------------
>
> Key: CAMEL-3781
> URL: https://issues.apache.org/jira/browse/CAMEL-3781
> Project: Camel
> Issue Type: New Feature
> Components: camel-jms
> Affects Versions: 2.6.0
> Environment: Java 1.6.0_24, Mac OS X 10.6.6
> Reporter: Bryan Keller
> Assignee: Hadrian Zbarcea
> Priority: Minor
> Fix For: 2.8.0
>
> Attachments: patch-3781.diff
>
>
> It would be nice to add an option to the JMS component to disable the use of message expirations for InOut exchanges. If a client and server have clocks that are out-of-sync, using message expiration can cause problems. More details can be found here:
> http://camel.465427.n5.nabble.com/InOut-exchanges-require-synchronized-clocks-td3411881.html
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-3781) Add option to disable expiration on
JMS component
Posted by "Bryan Keller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-3781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13016033#comment-13016033 ]
Bryan Keller commented on CAMEL-3781:
-------------------------------------
The patch looks good. In the test, I'm not familiar with the "synchronous=true" option. Is that functionally similar to using an InOut exchange pattern?
> Add option to disable expiration on JMS component
> -------------------------------------------------
>
> Key: CAMEL-3781
> URL: https://issues.apache.org/jira/browse/CAMEL-3781
> Project: Camel
> Issue Type: New Feature
> Components: camel-jms
> Affects Versions: 2.6.0
> Environment: Java 1.6.0_24, Mac OS X 10.6.6
> Reporter: Bryan Keller
> Priority: Minor
> Fix For: 2.8.0
>
> Attachments: patch-3781.diff
>
>
> It would be nice to add an option to the JMS component to disable the use of message expirations for InOut exchanges. If a client and server have clocks that are out-of-sync, using message expiration can cause problems. More details can be found here:
> http://camel.465427.n5.nabble.com/InOut-exchanges-require-synchronized-clocks-td3411881.html
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira