You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2017/12/15 19:45:29 UTC
Review Request 64658: Modified SLRP to use the VolumeProfileAdaptor
module.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64658/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Joseph Wu.
Repository: mesos
Description
-------
This changes the Storage Local Resource Provider's source of profile
information from only using the default to using a VolumeProfileAdaptor
module.
This patch is based on https://reviews.apache.org/r/64616.
Diffs
-----
src/resource_provider/storage/provider.cpp 17acf1b430b81e31bd97b117a44477eebab7e6f4
Diff: https://reviews.apache.org/r/64658/diff/1/
Testing
-------
See later in chain. This patch will fail SLRP tests. They are fixed in a followup patch.
Thanks,
Chun-Hung Hsiao
Re: Review Request 64658: Modified SLRP to use the
VolumeProfileAdaptor module.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
> On Dec. 19, 2017, 12:12 a.m., Jie Yu wrote:
> > src/resource_provider/storage/provider.cpp
> > Lines 2587-2588 (patched)
> > <https://reviews.apache.org/r/64658/diff/6/?file=1919423#file1919423line2603>
> >
> > Maybe we need a helper here?
> >
> > `Result<string> getDiskProfile(const Resource& resource)`
Alternatively, I'll have an `Option<Resource> source` and do `source->disk().source().has_profile()`.
P.S. I don't feel that we need to do `has_disk()` and `disk().has_source()`, because the protobuf library will return an empty `Source` for `.disk().source()` if these messages don't exist.
- Chun-Hung
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64658/#review194084
-----------------------------------------------------------
On Dec. 18, 2017, 2:25 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64658/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2017, 2:25 a.m.)
>
>
> Review request for mesos, Jie Yu and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This changes the Storage Local Resource Provider's source of profile
> information from only using the default to using a VolumeProfileAdaptor
> module.
>
> This patch is based on https://reviews.apache.org/r/64616.
>
>
> Diffs
> -----
>
> src/resource_provider/storage/provider.cpp 158b6b408002209aa9a79a6772da30c984aad61a
>
>
> Diff: https://reviews.apache.org/r/64658/diff/6/
>
>
> Testing
> -------
>
> See later in chain. This patch will fail SLRP tests. They are fixed in a followup patch.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 64658: Modified SLRP to use the
VolumeProfileAdaptor module.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64658/#review194084
-----------------------------------------------------------
src/resource_provider/storage/provider.cpp
Lines 897-912 (patched)
<https://reviews.apache.org/r/64658/#comment272806>
Looks like this is not needed to me?
src/resource_provider/storage/provider.cpp
Lines 1153 (patched)
<https://reviews.apache.org/r/64658/#comment272809>
what if `watch` failed? at least print some error message?
src/resource_provider/storage/provider.cpp
Lines 1250 (patched)
<https://reviews.apache.org/r/64658/#comment272813>
Looks like this function can be called in any state?
src/resource_provider/storage/provider.cpp
Lines 1266 (patched)
<https://reviews.apache.org/r/64658/#comment272815>
remove the extra space before `=`
src/resource_provider/storage/provider.cpp
Lines 2587-2588 (patched)
<https://reviews.apache.org/r/64658/#comment272819>
Maybe we need a helper here?
`Result<string> getDiskProfile(const Resource& resource)`
- Jie Yu
On Dec. 18, 2017, 2:25 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64658/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2017, 2:25 a.m.)
>
>
> Review request for mesos, Jie Yu and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This changes the Storage Local Resource Provider's source of profile
> information from only using the default to using a VolumeProfileAdaptor
> module.
>
> This patch is based on https://reviews.apache.org/r/64616.
>
>
> Diffs
> -----
>
> src/resource_provider/storage/provider.cpp 158b6b408002209aa9a79a6772da30c984aad61a
>
>
> Diff: https://reviews.apache.org/r/64658/diff/6/
>
>
> Testing
> -------
>
> See later in chain. This patch will fail SLRP tests. They are fixed in a followup patch.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 64658: Modified SLRP to use the
VolumeProfileAdaptor module.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64658/#review194152
-----------------------------------------------------------
Fix it, then Ship it!
src/resource_provider/storage/provider.cpp
Lines 945 (patched)
<https://reviews.apache.org/r/64658/#comment272887>
at least
- Jie Yu
On Dec. 19, 2017, 2:52 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64658/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2017, 2:52 p.m.)
>
>
> Review request for mesos, Jie Yu and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This changes the Storage Local Resource Provider's source of profile
> information from only using the default to using a VolumeProfileAdaptor
> module.
>
> This patch is based on https://reviews.apache.org/r/64616.
>
>
> Diffs
> -----
>
> src/resource_provider/storage/provider.cpp 79d7f602bbc57bce308157dfbb6c2afaef806f23
>
>
> Diff: https://reviews.apache.org/r/64658/diff/7/
>
>
> Testing
> -------
>
> See later in chain. This patch will fail SLRP tests. They are fixed in a followup patch.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 64658: Modified SLRP to use the
VolumeProfileAdaptor module.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64658/
-----------------------------------------------------------
(Updated Dec. 19, 2017, 2:52 p.m.)
Review request for mesos, Jie Yu and Joseph Wu.
Changes
-------
Addressed Jie's comments and fixed a concurrency bug.
Repository: mesos
Description
-------
This changes the Storage Local Resource Provider's source of profile
information from only using the default to using a VolumeProfileAdaptor
module.
This patch is based on https://reviews.apache.org/r/64616.
Diffs (updated)
-----
src/resource_provider/storage/provider.cpp 79d7f602bbc57bce308157dfbb6c2afaef806f23
Diff: https://reviews.apache.org/r/64658/diff/7/
Changes: https://reviews.apache.org/r/64658/diff/6-7/
Testing
-------
See later in chain. This patch will fail SLRP tests. They are fixed in a followup patch.
Thanks,
Chun-Hung Hsiao
Re: Review Request 64658: Modified SLRP to use the
VolumeProfileAdaptor module.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64658/
-----------------------------------------------------------
(Updated Dec. 18, 2017, 2:25 a.m.)
Review request for mesos, Jie Yu and Joseph Wu.
Changes
-------
Always update the resource version when sending an `UPDATE_STATE` call.
Repository: mesos
Description
-------
This changes the Storage Local Resource Provider's source of profile
information from only using the default to using a VolumeProfileAdaptor
module.
This patch is based on https://reviews.apache.org/r/64616.
Diffs (updated)
-----
src/resource_provider/storage/provider.cpp 158b6b408002209aa9a79a6772da30c984aad61a
Diff: https://reviews.apache.org/r/64658/diff/6/
Changes: https://reviews.apache.org/r/64658/diff/5-6/
Testing
-------
See later in chain. This patch will fail SLRP tests. They are fixed in a followup patch.
Thanks,
Chun-Hung Hsiao
Re: Review Request 64658: Modified SLRP to use the
VolumeProfileAdaptor module.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64658/
-----------------------------------------------------------
(Updated Dec. 16, 2017, 10:28 a.m.)
Review request for mesos, Jie Yu and Joseph Wu.
Repository: mesos
Description
-------
This changes the Storage Local Resource Provider's source of profile
information from only using the default to using a VolumeProfileAdaptor
module.
This patch is based on https://reviews.apache.org/r/64616.
Diffs (updated)
-----
src/resource_provider/storage/provider.cpp 158b6b408002209aa9a79a6772da30c984aad61a
Diff: https://reviews.apache.org/r/64658/diff/5/
Changes: https://reviews.apache.org/r/64658/diff/4-5/
Testing
-------
See later in chain. This patch will fail SLRP tests. They are fixed in a followup patch.
Thanks,
Chun-Hung Hsiao
Re: Review Request 64658: Modified SLRP to use the
VolumeProfileAdaptor module.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64658/
-----------------------------------------------------------
(Updated Dec. 16, 2017, 1:34 a.m.)
Review request for mesos, Jie Yu and Joseph Wu.
Changes
-------
Added a `RECONCILING` state for profile updates.
Repository: mesos
Description
-------
This changes the Storage Local Resource Provider's source of profile
information from only using the default to using a VolumeProfileAdaptor
module.
This patch is based on https://reviews.apache.org/r/64616.
Diffs (updated)
-----
src/resource_provider/storage/provider.cpp 158b6b408002209aa9a79a6772da30c984aad61a
Diff: https://reviews.apache.org/r/64658/diff/4/
Changes: https://reviews.apache.org/r/64658/diff/3-4/
Testing
-------
See later in chain. This patch will fail SLRP tests. They are fixed in a followup patch.
Thanks,
Chun-Hung Hsiao
Re: Review Request 64658: Modified SLRP to use the
VolumeProfileAdaptor module.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64658/
-----------------------------------------------------------
(Updated Dec. 15, 2017, 9:46 p.m.)
Review request for mesos, Jie Yu and Joseph Wu.
Changes
-------
Rebased and minor name changes.
Repository: mesos
Description
-------
This changes the Storage Local Resource Provider's source of profile
information from only using the default to using a VolumeProfileAdaptor
module.
This patch is based on https://reviews.apache.org/r/64616.
Diffs (updated)
-----
src/resource_provider/storage/provider.cpp 158b6b408002209aa9a79a6772da30c984aad61a
Diff: https://reviews.apache.org/r/64658/diff/2/
Changes: https://reviews.apache.org/r/64658/diff/1-2/
Testing
-------
See later in chain. This patch will fail SLRP tests. They are fixed in a followup patch.
Thanks,
Chun-Hung Hsiao