[GitHub] [superset] zhaoyongjie commented on a change in pull request #13057: feat: Add sort by metric for pivot-table

[GitBox <gi...@apache.org>]

zhaoyongjie commented on a change in pull request #13057:
URL: https://github.com/apache/superset/pull/13057#discussion_r573827235



##########
File path: superset/viz.py
##########
@@ -865,6 +865,12 @@ def query_obj(self) -> QueryObjectDict:
             raise QueryObjectValidationError(_("Please choose at least one metric"))
         if set(groupby) & set(columns):
             raise QueryObjectValidationError(_("Group By' and 'Columns' can't overlap"))
+        sort_by = self.form_data.get("timeseries_limit_metric")

Review comment:
       I am curious, why use this control in a  not time-series chart. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org