You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "dramaticlly (via GitHub)" <gi...@apache.org> on 2026/03/03 01:56:35 UTC

[PR] Build: Disable publishing for nested iceberg-kafka-connect subproject [iceberg]

dramaticlly opened a new pull request, #15496:
URL: https://github.com/apache/iceberg/pull/15496

   Running into publish issue with `org.apache.iceberg:iceberg-kafka-connect` as I realized there's name collision in top level and nested project. Disabled nested one here to allow a happy publish 
   
   - top level: https://github.com/apache/iceberg/blob/main/settings.gradle#L192
   - nested: https://github.com/apache/iceberg/blob/main/settings.gradle#L200
   
   
   CC @bryanck @amogh-jahagirdar @huaxingao 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Build, Kafka-Connect: Disable publishing for empty grouping project [iceberg]

Posted by "bryanck (via GitHub)" <gi...@apache.org>.
bryanck commented on PR #15496:
URL: https://github.com/apache/iceberg/pull/15496#issuecomment-3992572723

   LGTM, thanks for catching this @dramaticlly . Also, thanks for the review @huaxingao !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Build, Kafka-Connect: Disable publishing for empty grouping project [iceberg]

Posted by "bryanck (via GitHub)" <gi...@apache.org>.
bryanck merged PR #15496:
URL: https://github.com/apache/iceberg/pull/15496


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Build: Disable publishing for nested iceberg-kafka-connect subproject [iceberg]

Posted by "huaxingao (via GitHub)" <gi...@apache.org>.
huaxingao commented on code in PR #15496:
URL: https://github.com/apache/iceberg/pull/15496#discussion_r2875702672


##########
kafka-connect/build.gradle:
##########
@@ -56,6 +56,11 @@ project(':iceberg-kafka-connect:iceberg-kafka-connect') {
   test {
     useJUnitPlatform()
   }
+
+  // duplicate artifact coordinates with the parent, disable publishing...

Review Comment:
   Looking at the project structure, the nested kafka-connect/kafka-connect/ project is the one with actual source code, while the parent kafka-connect/ is just a grouping project with no src. Should we disable publishing on the parent instead?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Build: Disable publishing for nested iceberg-kafka-connect subproject [iceberg]

Posted by "dramaticlly (via GitHub)" <gi...@apache.org>.
dramaticlly commented on PR #15496:
URL: https://github.com/apache/iceberg/pull/15496#issuecomment-3988359197

   also I think it will close #14549 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org