You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2022/03/23 21:22:06 UTC
[GitHub] [trafficcontrol] zrhoffman opened a new pull request #6689: GitHub Actions ATS RPM: Verify that the cached or built RPM matches the expected RPM name
zrhoffman opened a new pull request #6689:
URL: https://github.com/apache/trafficcontrol/pull/6689
<!--
Thank you for contributing! Please be sure to read our contribution guidelines: https://github.com/apache/trafficcontrol/blob/master/CONTRIBUTING.md
If this closes or relates to an existing issue, please reference it using one of the following:
Closes: #ISSUE
Related: #ISSUE
If this PR fixes a security vulnerability, DO NOT submit! Instead, contact
the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://apache.org/security regarding vulnerability disclosure.
-->
This PR adds validation to ensure that the GitHub Actions cache key corresponds with the name of the ATS RPM that that entry contains. This fixes an issue that currently makes the *CDN in a Box CI* workflow fail, because the cached RPM name is not what CDN in a Box expects the RPM name to be.
Cached RPM: `trafficserver-8.1.3-10.965df952e.el8.x86_64.rpm``
CiaB error:
> ```shell
> cp: cannot stat '../../dist/trafficserver-8.1.4-0.965df952e.el8.x86_64.rpm': No such file or directory
> ```
<!-- **^ Add meaningful description above** --><hr/>
## Which Traffic Control components are affected by this PR?
<!-- Please delete all components from this list that are NOT affected by this PR.
Feel free to add the name of a tool or script that is affected but not on the list.
-->
- Automation - building the Apache Traffic Server RPM<!-- Please specify which (GitHub Actions, Docker images, Ansible Roles, etc.) -->
- unknown
## What is the best way to verify this PR?
<!-- Please include here ALL the steps necessary to test your PR.
If your PR has tests (and most should), provide the steps needed to run the tests.
If not, please provide step-by-step instructions to test the PR manually and explain why your PR does not need tests. -->
- Verify that the *Traffic Control Cache Config integration tests* GHA workflow passes
- Verify that the *CDN-in-a-Box CI* GHA workflow passes
- Verify that the *Traffic Control Health Client integration tests* GHA workflow passes
## PR submission checklist
- [x] This PR has tests <!-- If not, please delete this text and explain why this PR does not need tests. -->
- [ ] This PR has documentation <!-- If not, please delete this text and explain why this PR does not need documentation. -->
- [ ] This PR has a CHANGELOG.md entry <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. -->
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman edited a comment on pull request #6689: GitHub Actions ATS RPM: Verify that the cached or built RPM matches the expected RPM name
Posted by GitBox <gi...@apache.org>.
zrhoffman edited a comment on pull request #6689:
URL: https://github.com/apache/trafficcontrol/pull/6689#issuecomment-1077762095
The extra validation added by this PR helps, but what ended up being the issue is that the latest ATS 8.1.x tag, [`8.1.4`](https://github.com/apache/trafficserver/releases/tag/8.1.4), is not annotated, and the `git describe` command used to version the ATS RPM only checks annotated git tags by default, so it used the last annotated tag, `8.1.3`. 44a29b4d7b fixed this by added the `--tags` option, which includes unannotated tags, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rawlinp merged pull request #6689: GitHub Actions ATS RPM: Verify that the cached or built RPM matches the expected RPM name
Posted by GitBox <gi...@apache.org>.
rawlinp merged pull request #6689:
URL: https://github.com/apache/trafficcontrol/pull/6689
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org