[GitHub] [incubator-kyuubi] zwangsheng commented on a diff in pull request #2982: [KYUUBI #2977] [BATCH] Using KyuubiApplicationManger#tagApplication help tag batch application

[GitBox <gi...@apache.org>]

zwangsheng commented on code in PR #2982:
URL: https://github.com/apache/incubator-kyuubi/pull/2982#discussion_r911664916


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/spark/SparkBatchProcessBuilder.scala:
##########
@@ -44,16 +45,14 @@ class SparkBatchProcessBuilder(
       buffer += cla
     }
 
-    // tag for YARN
-    val batchJobTag = batchConf.get(TAG_KEY).map(_ + ",").getOrElse("") + batchId
-    var allConf = batchConf ++ Map(TAG_KEY -> batchJobTag) ++ sparkAppNameConf()
+    // session conf + batch conf
+    // user set batch conf should override session conf
+    batchConf.asJava.entrySet().forEach(entry => conf.set(entry.getKey, entry.getValue))

Review Comment:
   I see, so it means we have to modify func `KyuubiApplicationManager#tagApplication` for supporting Map type. Or we can add new func to support Map params.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org