You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by "Bryan Call (JIRA)" <ji...@apache.org> on 2010/04/23 01:34:50 UTC
[jira] Created: (TS-322) fix the code so we don't have to compile
with -Wno-char-subscripts and -Wno-write-strings
fix the code so we don't have to compile with -Wno-char-subscripts and -Wno-write-strings
-----------------------------------------------------------------------------------------
Key: TS-322
URL: https://issues.apache.org/jira/browse/TS-322
Project: Traffic Server
Issue Type: Improvement
Components: Cleanup
Affects Versions: 2.1.0
Reporter: Bryan Call
Assignee: Bryan Call
This will require some changes to the internal APIs to accept const char* instead of char*.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TS-322) fix the code so we don't have to compile
with -Wno-char-subscripts and -Wno-write-strings
Posted by "George Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
George Paul updated TS-322:
---------------------------
Attachment: 0001-TS322_const_char_gp_diff3.patch
Hi Bryan,
The following patch '0001-TS322_const_char_gp_diff3.patch' is also required after applying 'const_char-bcall-001.patch' on OSX (10.5), FreeBSD-7.2 and OpenSolaris (osol0906). I also retested on linux (ubuntu904). There is still an issue with configure detecting 'strndup' on linux and freebsd (conflicting types for bulitin strndup fcn) so the new fcn is used instead for now.
-George
> fix the code so we don't have to compile with -Wno-char-subscripts and -Wno-write-strings
> -----------------------------------------------------------------------------------------
>
> Key: TS-322
> URL: https://issues.apache.org/jira/browse/TS-322
> Project: Traffic Server
> Issue Type: Improvement
> Components: Cleanup
> Affects Versions: 2.1.0
> Reporter: Bryan Call
> Assignee: Bryan Call
> Attachments: 0001-TS322_const_char_gp_diff3.patch, const_char-bcall-001.patch
>
>
> This will require some changes to the internal APIs to accept const char* instead of char*.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (TS-322) fix the code so we don't have to compile
with -Wno-char-subscripts and -Wno-write-strings
Posted by "Bryan Call (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Call resolved TS-322.
---------------------------
Fix Version/s: 2.1.0
Resolution: Fixed
> fix the code so we don't have to compile with -Wno-char-subscripts and -Wno-write-strings
> -----------------------------------------------------------------------------------------
>
> Key: TS-322
> URL: https://issues.apache.org/jira/browse/TS-322
> Project: Traffic Server
> Issue Type: Improvement
> Components: Cleanup
> Affects Versions: 2.1.0
> Reporter: Bryan Call
> Assignee: Bryan Call
> Fix For: 2.1.0
>
> Attachments: 0001-TS322_const_char_gp_diff3.patch, const_char-bcall-001.patch
>
>
> This will require some changes to the internal APIs to accept const char* instead of char*.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TS-322) fix the code so we don't have to compile
with -Wno-char-subscripts and -Wno-write-strings
Posted by "Bryan Call (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Call updated TS-322:
--------------------------
Attachment: const_char-bcall-001.patch
Patch so we don't have to compile with -Wno-char-subscripts -Wno-write-strings any more.
1. Only changed internal APIs to use const char* where need and didn't mess around with changing the external APIs.
2. Casting char to inku8 to index into arrays.
I tested this out on Fedora Core 12 x86_64 without any problems.
> fix the code so we don't have to compile with -Wno-char-subscripts and -Wno-write-strings
> -----------------------------------------------------------------------------------------
>
> Key: TS-322
> URL: https://issues.apache.org/jira/browse/TS-322
> Project: Traffic Server
> Issue Type: Improvement
> Components: Cleanup
> Affects Versions: 2.1.0
> Reporter: Bryan Call
> Assignee: Bryan Call
> Attachments: const_char-bcall-001.patch
>
>
> This will require some changes to the internal APIs to accept const char* instead of char*.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.