You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/03/10 23:24:53 UTC
[GitHub] [arrow] zeroshade opened a new pull request #9675: ARROW-11931: [Go][Arrow] bump to go1.15
zeroshade opened a new pull request #9675:
URL: https://github.com/apache/arrow/pull/9675
@emkornfield
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] sbinet commented on pull request #9675: ARROW-11931: [Go] bump to go1.15
Posted by GitBox <gi...@apache.org>.
sbinet commented on pull request #9675:
URL: https://github.com/apache/arrow/pull/9675#issuecomment-796871603
ah, that's for the Gonum (Go-1.14) and for go-parquet (Go-1.15, for the signed int shifts):
```
# github.com/apache/arrow/go/parquet/internal/bmi
internal/bmi/bmi_noasm.go:239:28: invalid operation: value << bitLen (shift count type int, must be unsigned integer)
internal/bmi/bmi_noasm.go:251:22: invalid operation: uint64(1) << idx (shift count type int, must be unsigned integer)652
internal/bmi/bmi_noasm.go:253:22: invalid operation: uint64(0) << idx (shift count type int, must be unsigned integer)
note: module requires Go 1.15
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] sbinet commented on pull request #9675: ARROW-11931: [Go] bump to go1.15
Posted by GitBox <gi...@apache.org>.
sbinet commented on pull request #9675:
URL: https://github.com/apache/arrow/pull/9675#issuecomment-796914760
I think that's fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9675: ARROW-11931: [Go][Arrow] bump to go1.15
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9675:
URL: https://github.com/apache/arrow/pull/9675#issuecomment-796280932
https://issues.apache.org/jira/browse/ARROW-11931
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #9675: ARROW-11931: [Go] bump to go1.15
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #9675:
URL: https://github.com/apache/arrow/pull/9675#issuecomment-797077363
Can we merge this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #9675: ARROW-11931: [Go] bump to go1.15
Posted by GitBox <gi...@apache.org>.
zeroshade commented on pull request #9675:
URL: https://github.com/apache/arrow/pull/9675#issuecomment-796848762
Once someone merges this in, I'll update the linked PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] sbinet closed pull request #9675: ARROW-11931: [Go] bump to go1.15
Posted by GitBox <gi...@apache.org>.
sbinet closed pull request #9675:
URL: https://github.com/apache/arrow/pull/9675
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield commented on pull request #9675: ARROW-11931: [Go] bump to go1.15
Posted by GitBox <gi...@apache.org>.
emkornfield commented on pull request #9675:
URL: https://github.com/apache/arrow/pull/9675#issuecomment-796859471
@sbinet does this seem OK. It looks like 1.15 got released relatively recently (Aug 2020?).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #9675: ARROW-11931: [Go] bump to go1.15
Posted by GitBox <gi...@apache.org>.
zeroshade commented on pull request #9675:
URL: https://github.com/apache/arrow/pull/9675#issuecomment-796911997
I'm explicitly not changing the go1.12 declaration in the arrow go.mod, so anyone currently using it shouldn't be affected.
At a worst case scenario, I can modify the go-parquet to introduce a new build and test pipeline with go1.15 rather than piggy backing off the existing go-arrow pipeline and adding the go-parquet directory. I just figured that was excessive since the other languages didn't seem to separate the arrow and parquet build and tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org